bug(iflow): Cookie auth method fails for accounts without prior OAuth Email Login

[MasuRii]

Description

The iFlow cookie authentication method doesn't work for new accounts that haven't previously authenticated using the "OAuth Email Login" method.

Steps to Reproduce

1. Set up a new iFlow account
2. Attempt to use the "Cookie" authentication method directly (without ever using OAuth Email Login)
3. Observe the error

Expected Behavior

Cookie authentication should work independently without requiring a prior OAuth Email Login.

Actual Behavior

The following error is displayed:

Validating cookie...
╭─────────────────────────────────────────────────────── Error ────────────────────────────────────────────────────────╮
│ Credential setup failed: 'NoneType' object has no attribute 'get'                                                    │
╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

Press Enter to return to main menu...

Workaround

For new accounts, the following sequence works:

1. First: Complete the "OAuth Email Login" method at least once
2. Then: Switch to the "Cookie" authentication method

After performing OAuth Email Login once, the Cookie method will work correctly.

Environment

• Provider: iFlow
• Component: Cookie authentication

[mirrobot-agent]

@MasuRii Thank you for submitting this issue. I am now beginning my analysis and will report back shortly.

[mirrobot-agent]

Initial Analysis Report

Summary: The iFlow authentication fails for new accounts due to an unhandled null response in the user info API, specifically when the data field is returned as None.
Issue Validation: Confirmed (Codebase evidence matches the error pattern).
Reproducibility Assessment: Reproducible (Logical confirmation from code analysis).
Root Cause Analysis:
In src/rotator_library/providers/iflow_auth_base.py, the _fetch_user_info method (line 461) parses the API response:

0480|         data = result.get("data", {})
0481|         api_key = data.get("apiKey", "").strip()

If the iFlow API returns {"success": true, "data": null}, the call to result.get("data", {}) returns None (since the key exists but its value is null). Subsequent access to data.get("apiKey") then raises 'NoneType' object has no attribute 'get'. This likely occurs for new accounts that haven't initialized their profile via the standard OAuth flow.

Suggested Labels: bug, provider:iflow, priority:medium
Proposed Next Steps:

1. Modify _fetch_user_info in src/rotator_library/providers/iflow_auth_base.py to safely handle None data:

   data = result.get("data") or {}

2. Add a more descriptive error message when apiKey is missing to help with future debugging.
3. Investigate why the "Cookie" authentication method mentioned in the issue is missing from the current main branch, as it might be part of an unmerged PR or a local modification by the user.

Missing Information (if any):

• Could you confirm which version or branch of the proxy you are using? The strings "Cookie authentication" and "Validating cookie..." were not found in the current main branch codebase.

Investigation Warnings

• I was unable to locate the specific "Cookie" authentication implementation or the string "Validating cookie..." in the current repository's main branch. The analysis is based on the provided error message and the matching code pattern in the existing iFlow authentication logic.

This analysis was generated by an AI assistant.

[MasuRii]

Check the dev branch, that's the one that I've been using. @mirrobot-agent

[mirrobot-agent]

@MasuRii, Understood. I'll switch to the dev branch, investigate the issue there, and prepare a fix. I'll keep you updated on my progress.

[mirrobot-agent]

@MasuRii, I have successfully implemented and committed the fix on the dev branch.

Summary

Fixed a crash in iFlow cookie authentication that occurred when the API returned a null data field for new or uninitialized accounts.

Key Changes Made

• Updated src/rotator_library/providers/iflow_auth_base.py to safely handle null data values in API responses.
• Replaced result.get("data", {}) with result.get("data") or {} in three critical authentication methods:
  • _fetch_user_info
  • _fetch_api_key_info_with_cookie
  • _refresh_api_key_with_cookie

Root Cause

The Python dict.get(key, default) method returns the value if the key exists, even if that value is None. When the iFlow API returned {"data": null}, the code received None instead of the expected dictionary, leading to the 'NoneType' object has no attribute 'get' error.

Pull Request Created

The fix is now available for review in the following pull request: #118

This update was generated by an AI assistant.