Feature/better turn#239
Open
noahklein00 wants to merge 5 commits into
Open
Conversation
ewad3
suggested changes
Mar 17, 2021
Contributor
ewad3
left a comment
ewad3
left a comment
There was a problem hiding this comment.
Other than small changes needed to be made looks good.
pieperm
suggested changes
Mar 18, 2021
Member
pieperm
left a comment
pieperm
left a comment
There was a problem hiding this comment.
Lots of comments that do a great job explaining what's happening. Could use changes with type annotations on a few variables.
pieperm
suggested changes
Mar 18, 2021
| count += 1 | ||
|
|
||
| async def turn(self, drone: System) -> bool: | ||
| async def turn(self, drone: System, degrees_turned = 180: int, left_turn = True: bool, time = 3.5: float) -> bool: |
Member
There was a problem hiding this comment.
Another possible issue I noticed is that adding these arguments is not reflected when the function is called. That is, in states/early_laps.py, the call to mover.turn() is only passed a drone. Are we planning on using the default arguments for the pylon laps?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The turn function now allows for variable input and adjusts the time, degrees, and direction of the turn based off of function variables.