[UI] Filmography Posters on Person detail is too tall overlapping detail

[ADRStudio]

Moonfin version

1.5.0

Roku device model

Roku Ultra 4800x

Roku OS version

15.3.4

Where does it happen?

Details page

Steps to reproduce

When entering on person detail the filmography posters are too tall and is overlapping the poster detail, name/date. This is an old bug. I think the date is the most important and it will be great to show the posters in ascending order by date, make sense for a biography.

Screenshots / photos (optional)

No response

[jmawet]

can you add a screenshot please so we can see

[ADRStudio]

Hi !
Here are the screen shots. I included a screen shot of a version 1.4.2 that I did a lot of modifications mostly just changing values until if fixed, it will be hard for me to tell you where I did the modification, I don't remember. I remember that the information showed up just adjusting the size. Also, entering on the person detail screen the cursor parks on the LIKE icon by default, easy to click by mistake, I also change the default to jump to the first poster. And, as you can see, I change a little the text size and got rid of the word "Favorite" to look better.... and calculated the AGE of the person.

.

[jmawet]

Any chance you'd be able to recreate the changes on 1.5 and submit a pr? Haha if not we'll take a look

[ADRStudio]

@jmawet

Hi, I just saw your request today, sorry. OK, I found where I changed it, lol. I tried to open a PR but it didn't work and I gave up. I fix it on version 1.5.0 and tested on my Roku, it worked but it also needs to adjust the "locations" of the top screen because is hiding part the text below the poster. Anyway, is very easy to describe for you to replace. The file is ExtrasRowList.brs:

On the sub updateContent(loadedContent as object) under the comment " Update content with pre-loaded data from task" just replace the numbers:

' Add Movies row if there are any
if movies.count() > 0
    row = buildRow("Movies", movies, 180)
    addRowSize([
        180
        270
    ])
    m.top.content.appendChild(row)
end if
' Add TV Shows row if there are any
if shows.count() > 0
    row = buildRow("TV Shows", shows, 180)
    addRowSize([
        180
        270
    ])
    m.top.content.appendChild(row)

Note these values are now consistent with the section 'Add rows in the desired order: Season Episodes → Seasons → Next Episode → Cast & Crew → More Like This .... above it.

As way to adjust the "Locations" I suggest modifying the file PersonDetails.xml get rid of the id="favoriteText" and adjust the size and translations of the favorite button and icon like these:

        <Poster id="favoriteButtonBg" uri="pkg:/images/hd_focus_filled.9.png" loadDisplayMode="scaleToFit" width="80" height="75" blendColor="#444444" opacity="0.6" />
        <Poster id="favoriteIcon" uri="pkg:/images/icons/heart.png" width="48" height="48" translation="[16, 10]" />

I also make change on the file LoadExtrasTask.brs to sort the movies by PremiereDate because I think makes more sense. On the function loadPersonVideos() as object under the comment " Load movies and TV shows for a person ":

replace "SortBy": "SortName" with "SortBy": "PremiereDate"

[ADRStudio]

@jmawet

Once you are working on this please change the initial focus on Person Detail page to the first item of the filmography. I did it modifying the file PersonDetails.brs adding this line to end of sub INIT:

m.extrasGrid.setFocus(true)

[jmawet]

alright I'll take a look