Fix data SDG optional imports at CLI startup#210
Open
oliverholworthy wants to merge 2 commits into
Open
Conversation
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
marcromeyn
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The long-document SDG CLI imported recipe config classes at startup, which pulled in
data_designereven for unrelated commands. In a base install without the optionaldata-sdgextra, anynemotron ...command could fail before dispatch.This makes config introspection lazy: the CLI can start normally without optional SDG deps, while per-stage rich config help still works when those deps are installed.
Testing
uv run pytest tests/recipes/test_data_sdg_cli.py -quv run ruff check src/nemo_runspec/help.py src/nemo_runspec/recipe_typer.py src/nemotron/cli/commands/data/sdg/long_document/commands.py tests/recipes/test_data_sdg_cli.pyuv run nemotron --helpuv run nemotron data sdg long-document ocr --help