Skip to content

What is the reason of filtering "_" and "~" symbols? #125

@kremnik

Description

@kremnik

Hi @rafaelvalle

In this line:

return s in _symbol_to_id and s is not '_' and s is not '~'

you are filtering "_" and "~" symbols.
Also, one of the main advice to improve alignment map convergence is to add special symbols to start and end of every sentence. Usually these symbols are exactly "_" and "~" (ex: _What is your name?~). But you filter out exactly these symbols and do not add them anywhere in the code.

It is interesting, that you've included the "_" symbol here:

_special = '_@©°½—₩€$'

but anyway filter it out next in sentence preprocessing.

So the questions are:

  1. What is the reason of filtering out "_" and "~" symbols?
  2. Why don't you use them as start and end symbols in sentences?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions