Skip to content

Lack of the arguments' correctness checks #61

@olga24912

Description

@olga24912

In depositToNear we take the nearRecipientAccountId as string: https://github.com/aurora-is-near/eth-connector/blob/master/eth-custodian/contracts/EthCustodian.sol#L87

In depositToEVM we take the ethRecipientOnNear as string: https://github.com/aurora-is-near/eth-connector/blob/master/eth-custodian/contracts/EthCustodian.sol#L56

And we don't perform any checks for these arguments. It will be nice to have some basic one:

  • nearRecipientAccountId doesn't contain :
  • ethRecipientOnNear is 40/42 length long and contain only allowed symbols.

If I understand correctly, if there is an error in the address, Eth will be blocked forever.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions