Context
This repo has no .github/workflows/ directory, so nothing runs on push or PR. novatip-contracts already has a ci.yml to model this on.
Several of the bugs currently open here — a .ts import specifier that only breaks in a built run, an undeclared dotenv dependency, a dependency name that 404s on the registry — would all have been caught by a clean-install-and-build job.
What to do
Add .github/workflows/ci.yml running on push and pull request:
npm ci on Node 18 and 20 (matching the engines field)npm run lintnpm run typechecknpx prisma generate before typecheck, since the Prisma client is generatednpm run build
npm run test currently has no test files; wire it in once tests exist, or add it now with a placeholder that doesn't fail the job.
Acceptance criteria
Context
This repo has no
.github/workflows/directory, so nothing runs on push or PR.novatip-contractsalready has aci.ymlto model this on.Several of the bugs currently open here — a
.tsimport specifier that only breaks in a built run, an undeclareddotenvdependency, a dependency name that 404s on the registry — would all have been caught by a clean-install-and-build job.What to do
Add
.github/workflows/ci.ymlrunning on push and pull request:npm cion Node 18 and 20 (matching theenginesfield)npm run lintnpm run typechecknpx prisma generatebefore typecheck, since the Prisma client is generatednpm run buildnpm run testcurrently has no test files; wire it in once tests exist, or add it now with a placeholder that doesn't fail the job.Acceptance criteria
mainnpm ciagainst the lockfile, notnpm installmainrequires the check (repo admin follow-up)