diff --git a/hr_expense_tier_validation/README.rst b/hr_expense_tier_validation/README.rst new file mode 100644 index 000000000..f05115548 --- /dev/null +++ b/hr_expense_tier_validation/README.rst @@ -0,0 +1,124 @@ +.. image:: https://odoo-community.org/readme-banner-image + :target: https://odoo-community.org/get-involved?utm_source=readme + :alt: Odoo Community Association + +======================= +Expense Tier Validation +======================= + +.. + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! source digest: sha256:8d6f5b7a94adc5635d78b792bad1ba6127ad27060e971a0850521e5c418e1717 + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fhr--expense-lightgray.png?logo=github + :target: https://github.com/OCA/hr-expense/tree/19.0/hr_expense_tier_validation + :alt: OCA/hr-expense +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/hr-expense-19-0/hr-expense-19-0-hr_expense_tier_validation + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/builds?repo=OCA/hr-expense&target_branch=19.0 + :alt: Try me on Runboat + +|badge1| |badge2| |badge3| |badge4| |badge5| + +This module extends the functionality of Expense Reports to support a +tier validation process. + +**Table of contents** + +.. contents:: + :local: + +Configuration +============= + +To configure tier validation for HR expenses: + +1. Go to *Settings > Technical > Tier Validations > Tier Definition* +2. Create the desired approval tiers for the hr.expense model. + +To define exceptions for expense approvals: + +1. Go to *Settings > Technical > System Parameters* +2. Search for "hr_expense.tier_exceptions" in the system parameters. +3. Add the necessary fields that should be excluded from tier + validation. + +Usage +===== + +To use this module, you need to: + +1. Create a Expense Report triggering at least one "Tier Definition". +2. Click on *Request Validation* button. +3. Under the tab *Reviews* have a look to pending reviews and their + statuses. +4. Once all reviews are validated click on *Approve*. + +Additional features: + +- You can filter the Expense Reports requesting your review through the + filter *Needs my Review*. +- User with rights to confirm the Expense Report (validate all tiers + that would be generated) can directly do the operation, this is, there + is no need for her/him to request a validation. + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +------- + +* Ecosoft + +Contributors +------------ + +- Pimolnat Suntian +- Saran Lim. + +Maintainers +----------- + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +.. |maintainer-ps-tubtim| image:: https://github.com/ps-tubtim.png?size=40px + :target: https://github.com/ps-tubtim + :alt: ps-tubtim + +Current `maintainer `__: + +|maintainer-ps-tubtim| + +This module is part of the `OCA/hr-expense `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/hr_expense_tier_validation/__init__.py b/hr_expense_tier_validation/__init__.py new file mode 100644 index 000000000..69f7babdf --- /dev/null +++ b/hr_expense_tier_validation/__init__.py @@ -0,0 +1,3 @@ +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from . import models diff --git a/hr_expense_tier_validation/__manifest__.py b/hr_expense_tier_validation/__manifest__.py new file mode 100644 index 000000000..d076a0090 --- /dev/null +++ b/hr_expense_tier_validation/__manifest__.py @@ -0,0 +1,15 @@ +# Copyright 2019 Ecosoft Co., Ltd. (http://ecosoft.co.th) +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +{ + "name": "Expense Tier Validation", + "version": "19.0.1.0.0", + "category": "Human Resources", + "author": "Ecosoft, Odoo Community Association (OCA)", + "license": "AGPL-3", + "website": "https://github.com/OCA/hr-expense", + "depends": ["hr_expense", "base_tier_validation"], + "data": ["data/ir_config_parameter.xml", "views/hr_expense_views.xml"], + "installable": True, + "maintainers": ["ps-tubtim"], +} diff --git a/hr_expense_tier_validation/data/ir_config_parameter.xml b/hr_expense_tier_validation/data/ir_config_parameter.xml new file mode 100644 index 000000000..08cd86f25 --- /dev/null +++ b/hr_expense_tier_validation/data/ir_config_parameter.xml @@ -0,0 +1,7 @@ + + + + hr_expense.tier_exceptions + ["message_follower_ids", "access_token"] + + diff --git a/hr_expense_tier_validation/i18n/hr_expense_tier_validation.pot b/hr_expense_tier_validation/i18n/hr_expense_tier_validation.pot new file mode 100644 index 000000000..87a074553 --- /dev/null +++ b/hr_expense_tier_validation/i18n/hr_expense_tier_validation.pot @@ -0,0 +1,122 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * hr_expense_tier_validation +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 17.0\n" +"Report-Msgid-Bugs-To: \n" +"Last-Translator: \n" +"Language-Team: \n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: \n" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__can_review +msgid "Can Review" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model,name:hr_expense_tier_validation.model_hr_expense +msgid "Expense" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model,name:hr_expense_tier_validation.model_hr_expense_sheet +msgid "Expense Report" +msgstr "" + +#. module: hr_expense_tier_validation +#: model_terms:ir.ui.view,arch_db:hr_expense_tier_validation.hr_expense_sheet_view_search +msgid "Expense report validated and ready to be approved" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__has_comment +msgid "Has Comment" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__hide_reviews +msgid "Hide Reviews" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,help:hr_expense_tier_validation.field_hr_expense_sheet__has_comment +msgid "If set, Allow the reviewer to leave a comment on the review." +msgstr "" + +#. module: hr_expense_tier_validation +#: model_terms:ir.ui.view,arch_db:hr_expense_tier_validation.hr_expense_sheet_view_search +msgid "My Expense report to review" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__need_validation +msgid "Need Validation" +msgstr "" + +#. module: hr_expense_tier_validation +#: model_terms:ir.ui.view,arch_db:hr_expense_tier_validation.hr_expense_sheet_view_search +msgid "Needs my Review" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__next_review +msgid "Next Review" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__rejected +msgid "Rejected" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__rejected_message +msgid "Rejected Message" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__reviewer_ids +msgid "Reviewers" +msgstr "" + +#. module: hr_expense_tier_validation +#. odoo-python +#: code:addons/hr_expense_tier_validation/models/hr_expense.py:0 +#, python-format +msgid "The expense report is under validation." +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model,name:hr_expense_tier_validation.model_tier_definition +msgid "Tier Definition" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__to_validate_message +msgid "To Validate Message" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__validated +#: model_terms:ir.ui.view,arch_db:hr_expense_tier_validation.hr_expense_sheet_view_search +msgid "Validated" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__validated_message +msgid "Validated Message" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__validation_status +msgid "Validation Status" +msgstr "" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__review_ids +msgid "Validations" +msgstr "" diff --git a/hr_expense_tier_validation/i18n/it.po b/hr_expense_tier_validation/i18n/it.po new file mode 100644 index 000000000..e68cc8868 --- /dev/null +++ b/hr_expense_tier_validation/i18n/it.po @@ -0,0 +1,126 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * hr_expense_tier_validation +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 15.0\n" +"Report-Msgid-Bugs-To: \n" +"PO-Revision-Date: 2025-02-27 11:06+0000\n" +"Last-Translator: mymage \n" +"Language-Team: none\n" +"Language: it\n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: nplurals=2; plural=n != 1;\n" +"X-Generator: Weblate 5.6.2\n" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__can_review +msgid "Can Review" +msgstr "Può revisionare" + +#. module: hr_expense_tier_validation +#: model:ir.model,name:hr_expense_tier_validation.model_hr_expense +msgid "Expense" +msgstr "Spesa" + +#. module: hr_expense_tier_validation +#: model:ir.model,name:hr_expense_tier_validation.model_hr_expense_sheet +msgid "Expense Report" +msgstr "Nota spese" + +#. module: hr_expense_tier_validation +#: model_terms:ir.ui.view,arch_db:hr_expense_tier_validation.hr_expense_sheet_view_search +msgid "Expense report validated and ready to be approved" +msgstr "Nota spese validata e pronta ad essere approvata" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__has_comment +msgid "Has Comment" +msgstr "Ha commenti" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__hide_reviews +msgid "Hide Reviews" +msgstr "Nascondi revisioni" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,help:hr_expense_tier_validation.field_hr_expense_sheet__has_comment +msgid "If set, Allow the reviewer to leave a comment on the review." +msgstr "" +"Se attivata, consente al revisore di lasciare un commento nella revisione." + +#. module: hr_expense_tier_validation +#: model_terms:ir.ui.view,arch_db:hr_expense_tier_validation.hr_expense_sheet_view_search +msgid "My Expense report to review" +msgstr "La mia nota spese da revisionare" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__need_validation +msgid "Need Validation" +msgstr "Richiede conferma" + +#. module: hr_expense_tier_validation +#: model_terms:ir.ui.view,arch_db:hr_expense_tier_validation.hr_expense_sheet_view_search +msgid "Needs my Review" +msgstr "Richiede la mia revisione" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__next_review +msgid "Next Review" +msgstr "Prossima revisione" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__rejected +msgid "Rejected" +msgstr "Rifiutato" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__rejected_message +msgid "Rejected Message" +msgstr "Messaggio di rifiuto" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__reviewer_ids +msgid "Reviewers" +msgstr "Revisori" + +#. module: hr_expense_tier_validation +#. odoo-python +#: code:addons/hr_expense_tier_validation/models/hr_expense.py:0 +#, python-format +msgid "The expense report is under validation." +msgstr "La nota spese è in validazione." + +#. module: hr_expense_tier_validation +#: model:ir.model,name:hr_expense_tier_validation.model_tier_definition +msgid "Tier Definition" +msgstr "Definizione livello" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__to_validate_message +msgid "To Validate Message" +msgstr "Messaggio per 'Da validare'" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__validated +#: model_terms:ir.ui.view,arch_db:hr_expense_tier_validation.hr_expense_sheet_view_search +msgid "Validated" +msgstr "Approvata" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__validated_message +msgid "Validated Message" +msgstr "Messaggio per 'Validato'" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__validation_status +msgid "Validation Status" +msgstr "Stato validazione" + +#. module: hr_expense_tier_validation +#: model:ir.model.fields,field_description:hr_expense_tier_validation.field_hr_expense_sheet__review_ids +msgid "Validations" +msgstr "Validazioni" diff --git a/hr_expense_tier_validation/models/__init__.py b/hr_expense_tier_validation/models/__init__.py new file mode 100644 index 000000000..62536aa30 --- /dev/null +++ b/hr_expense_tier_validation/models/__init__.py @@ -0,0 +1,4 @@ +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from . import hr_expense +from . import tier_definition diff --git a/hr_expense_tier_validation/models/hr_expense.py b/hr_expense_tier_validation/models/hr_expense.py new file mode 100644 index 000000000..9d9a063ef --- /dev/null +++ b/hr_expense_tier_validation/models/hr_expense.py @@ -0,0 +1,53 @@ +# Copyright 2022 Ecosoft Co., Ltd. (http://ecosoft.co.th) +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +import ast + +from odoo import api, models +from odoo.exceptions import ValidationError + + +class HrExpense(models.Model): + _name = "hr.expense" + _inherit = ["hr.expense", "tier.validation"] + + _state_field = "approval_state" + _state_from = ["submitted"] + _state_to = ["approved"] + + _tier_validation_manual_config = False + + @api.model + def _get_under_validation_exceptions(self): + """Extend for more field exceptions.""" + params_exception = ( + self.env["ir.config_parameter"] + .sudo() + .get_param("hr_expense.tier_exceptions") + or [] + ) + # Convert to list + if not isinstance(params_exception, list): + params_exception = ast.literal_eval(params_exception) + return params_exception + + def _check_allow_write_under_validation(self, vals): + """Allow to add exceptions for fields that are allowed to be written + or for reviewers for all fields, even when the record is under + validation.""" + exceptions = self._get_under_validation_exceptions() + for val in vals: + if val not in exceptions: + return False + return True + + def write(self, vals): + for rec in self: + if ( + rec.approval_state == "submitted" + and rec.review_ids + and rec.validation_status not in ("validated", "rejected") + and not rec._check_allow_write_under_validation(vals) + ): + raise ValidationError(self.env._("The expense is under validation.")) + return super().write(vals) diff --git a/hr_expense_tier_validation/models/tier_definition.py b/hr_expense_tier_validation/models/tier_definition.py new file mode 100644 index 000000000..85145216e --- /dev/null +++ b/hr_expense_tier_validation/models/tier_definition.py @@ -0,0 +1,14 @@ +# Copyright 2019 Ecosoft Co., Ltd. (http://ecosoft.co.th) +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from odoo import api, models + + +class TierDefinition(models.Model): + _inherit = "tier.definition" + + @api.model + def _get_tier_validation_model_names(self): + res = super()._get_tier_validation_model_names() + res.append("hr.expense") + return res diff --git a/hr_expense_tier_validation/pyproject.toml b/hr_expense_tier_validation/pyproject.toml new file mode 100644 index 000000000..4231d0ccc --- /dev/null +++ b/hr_expense_tier_validation/pyproject.toml @@ -0,0 +1,3 @@ +[build-system] +requires = ["whool"] +build-backend = "whool.buildapi" diff --git a/hr_expense_tier_validation/readme/CONFIGURE.md b/hr_expense_tier_validation/readme/CONFIGURE.md new file mode 100644 index 000000000..87fa5be2d --- /dev/null +++ b/hr_expense_tier_validation/readme/CONFIGURE.md @@ -0,0 +1,10 @@ +To configure tier validation for HR expenses: + +1. Go to *Settings > Technical > Tier Validations > Tier Definition* +2. Create the desired approval tiers for the hr.expense model. + +To define exceptions for expense approvals: + +1. Go to *Settings > Technical > System Parameters* +2. Search for "hr_expense.tier_exceptions" in the system parameters. +3. Add the necessary fields that should be excluded from tier validation. \ No newline at end of file diff --git a/hr_expense_tier_validation/readme/CONTRIBUTORS.md b/hr_expense_tier_validation/readme/CONTRIBUTORS.md new file mode 100644 index 000000000..e5c2f1d59 --- /dev/null +++ b/hr_expense_tier_validation/readme/CONTRIBUTORS.md @@ -0,0 +1,2 @@ +- Pimolnat Suntian \<\> +- Saran Lim. \<\> diff --git a/hr_expense_tier_validation/readme/DESCRIPTION.md b/hr_expense_tier_validation/readme/DESCRIPTION.md new file mode 100644 index 000000000..e6b9bd89c --- /dev/null +++ b/hr_expense_tier_validation/readme/DESCRIPTION.md @@ -0,0 +1,2 @@ +This module extends the functionality of Expense Reports to support a +tier validation process. diff --git a/hr_expense_tier_validation/readme/USAGE.md b/hr_expense_tier_validation/readme/USAGE.md new file mode 100644 index 000000000..9cb1d3d5c --- /dev/null +++ b/hr_expense_tier_validation/readme/USAGE.md @@ -0,0 +1,15 @@ +To use this module, you need to: + +1. Create a Expense Report triggering at least one "Tier Definition". +2. Click on *Request Validation* button. +3. Under the tab *Reviews* have a look to pending reviews and their + statuses. +4. Once all reviews are validated click on *Approve*. + +Additional features: + +- You can filter the Expense Reports requesting your review through the + filter *Needs my Review*. +- User with rights to confirm the Expense Report (validate all tiers + that would be generated) can directly do the operation, this is, there + is no need for her/him to request a validation. diff --git a/hr_expense_tier_validation/static/description/icon.png b/hr_expense_tier_validation/static/description/icon.png new file mode 100644 index 000000000..3a0328b51 Binary files /dev/null and b/hr_expense_tier_validation/static/description/icon.png differ diff --git a/hr_expense_tier_validation/static/description/index.html b/hr_expense_tier_validation/static/description/index.html new file mode 100644 index 000000000..d8ea34f66 --- /dev/null +++ b/hr_expense_tier_validation/static/description/index.html @@ -0,0 +1,469 @@ + + + + + +README.rst + + + +
+ + + +Odoo Community Association + +
+

Expense Tier Validation

+ +

Beta License: AGPL-3 OCA/hr-expense Translate me on Weblate Try me on Runboat

+

This module extends the functionality of Expense Reports to support a +tier validation process.

+

Table of contents

+ +
+

Configuration

+

To configure tier validation for HR expenses:

+
    +
  1. Go to Settings > Technical > Tier Validations > Tier Definition
    2. +
  2. Create the desired approval tiers for the hr.expense model.
    3. +
+

To define exceptions for expense approvals:

+
    +
  1. Go to Settings > Technical > System Parameters
    2. +
  2. Search for “hr_expense.tier_exceptions” in the system parameters.
    3. +
  3. Add the necessary fields that should be excluded from tier +validation.
    4. +
+
+
+

Usage

+

To use this module, you need to:

+
    +
  1. Create a Expense Report triggering at least one “Tier Definition”.
    2. +
  2. Click on Request Validation button.
    3. +
  3. Under the tab Reviews have a look to pending reviews and their +statuses.
    4. +
  4. Once all reviews are validated click on Approve.
    5. +
+

Additional features:

+
    +
  • You can filter the Expense Reports requesting your review through the +filter Needs my Review.
    • +
  • User with rights to confirm the Expense Report (validate all tiers +that would be generated) can directly do the operation, this is, there +is no need for her/him to request a validation.
    • +
+
+
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • Ecosoft
    • +
+
+
+

Contributors

+ +
+
+

Maintainers

+

This module is maintained by the OCA.

+ +Odoo Community Association + +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

Current maintainer:

+

ps-tubtim

+

This module is part of the OCA/hr-expense project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+
+ + diff --git a/hr_expense_tier_validation/tests/__init__.py b/hr_expense_tier_validation/tests/__init__.py new file mode 100644 index 000000000..2b9257d3f --- /dev/null +++ b/hr_expense_tier_validation/tests/__init__.py @@ -0,0 +1,3 @@ +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from . import test_hr_expense_tier_validation diff --git a/hr_expense_tier_validation/tests/test_hr_expense_tier_validation.py b/hr_expense_tier_validation/tests/test_hr_expense_tier_validation.py new file mode 100644 index 000000000..218ed122c --- /dev/null +++ b/hr_expense_tier_validation/tests/test_hr_expense_tier_validation.py @@ -0,0 +1,77 @@ +# Copyright 2019 Ecosoft Co., Ltd. (http://ecosoft.co.th) +# Copyright 2024 Tecnativa - Víctor Martínez +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from odoo.exceptions import ValidationError +from odoo.tests import Form, tagged + +from odoo.addons.hr_expense.tests.common import TestExpenseCommon + + +@tagged("-at_install", "post_install") +class TestHrExpenseTierValidation(TestExpenseCommon): + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.tier_def_obj = cls.env["tier.definition"] + # Create tier validation + cls.tier_def_obj.create( + { + "model_id": cls.env.ref("hr_expense.model_hr_expense").id, + "review_type": "individual", + "reviewer_id": cls.expense_user_manager.id, + } + ) + + def _create_expense( + self, + description, + employee, + product, + ): + with Form(self.env["hr.expense"]) as expense: + expense.name = description + expense.employee_id = employee + expense.product_id = product + expense = expense.save() + expense.tax_ids = False # Test no vat + return expense + + def test_get_tier_validation_model_names(self): + self.assertIn( + "hr.expense", self.tier_def_obj._get_tier_validation_model_names() + ) + + def test_edit_value_expense(self): + expense = self._create_expense( + "Test - Expense", + self.expense_employee, + self.product_a, + ) + self.assertEqual(expense.state, "draft") + expense.action_submit() + self.assertEqual(expense.state, "submitted") + + # Must request validation before approve + with self.assertRaises(ValidationError): + expense.action_approve() + + expense.request_validation() + self.assertTrue(expense) + expense.invalidate_model() + + # tier validation but state still submitted + self.assertEqual(expense.state, "submitted") + + # not allow edit expense when under validation + # Use ORM write directly: in 19.0 `name` is view-readonly on submitted + # expenses, so a Form()-based test fails at the view layer before + # reaching the model-level guard. + with self.assertRaises(ValidationError): + expense.write({"name": "Change name"}) + + # test change field exception in tier, it should allow edit + self.env["ir.config_parameter"].sudo().set_param( + "hr_expense.tier_exceptions", "['name']" + ) + expense.write({"name": "Change name"}) diff --git a/hr_expense_tier_validation/views/hr_expense_views.xml b/hr_expense_tier_validation/views/hr_expense_views.xml new file mode 100644 index 000000000..2b84d606e --- /dev/null +++ b/hr_expense_tier_validation/views/hr_expense_views.xml @@ -0,0 +1,29 @@ + + + + + hr.expense.view.search - hr_expense_tier_validation + hr.expense + + + + + + + + + +