From 7f00f98392125ee476851ff873cc8962fa8e087c Mon Sep 17 00:00:00 2001 From: DoDo Date: Wed, 19 Jun 2024 13:52:25 +0200 Subject: [PATCH 1/2] [FIX] hr_employee_second_lastname: replace mapped address_home_id Replace address_home_id mapped by work_contact_id. The relational field no longer exists on the address in V17 and replace by non relational field(Char) private_street. Forward port fix (#1370) made in version 17 close #1551 --- hr_employee_second_lastname/models/hr_employee.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hr_employee_second_lastname/models/hr_employee.py b/hr_employee_second_lastname/models/hr_employee.py index edf085ccdda..5a1ce0c9068 100644 --- a/hr_employee_second_lastname/models/hr_employee.py +++ b/hr_employee_second_lastname/models/hr_employee.py @@ -75,7 +75,7 @@ def _prepare_vals_on_write_firstname_lastname(self, vals): def _update_partner_firstname(self): for employee in self: partners = employee.mapped("user_id.partner_id") - partners |= employee.mapped("address_home_id") + partners |= employee.mapped("work_contact_id") partners.write( { "firstname": employee.firstname, From e8ed0a327ab83fdf54b1ffe482426f8272c02e38 Mon Sep 17 00:00:00 2001 From: "Xavier Bol (xbo)" Date: Tue, 26 May 2026 23:27:13 +0200 Subject: [PATCH 2/2] fixup! [FIX] hr_employee_second_lastname: replace mapped address_home_id --- .../tests/test_hr_employee_second_lastname.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hr_employee_second_lastname/tests/test_hr_employee_second_lastname.py b/hr_employee_second_lastname/tests/test_hr_employee_second_lastname.py index 8f1ff1eb329..ecbfa983d42 100644 --- a/hr_employee_second_lastname/tests/test_hr_employee_second_lastname.py +++ b/hr_employee_second_lastname/tests/test_hr_employee_second_lastname.py @@ -103,6 +103,14 @@ def test_auto_init_name(self): self.assertEqual(employee_without_name, self.employee_model) def test_change_name(self): + is_partner_lastname_installed = ( + self.employee_model._is_partner_firstname_installed() + ) + work_contact = self.employee1_id.work_contact_id + if is_partner_lastname_installed: + self.assertEqual(self.employee1_id.firstname, work_contact.firstname) + self.assertEqual(self.employee1_id.lastname, work_contact.lastname) + self.assertEqual(self.employee1_id.lastname2, work_contact.lastname2) self.employee1_id.write({"name": "Pedro Martinez Torres"}) self.employee1_id.invalidate_recordset() @@ -110,6 +118,12 @@ def test_change_name(self): self.assertEqual(self.employee1_id.lastname, "Martinez") self.assertEqual(self.employee1_id.lastname2, "Torres") + if is_partner_lastname_installed: + work_contact.invalidate_recordset(["firstname", "lastname", "lastname2"]) + self.assertEqual(work_contact.firstname, "Pedro") + self.assertEqual(work_contact.lastname, "Martinez") + self.assertEqual(work_contact.lastname2, "Torres") + def test_change_name_with_space(self): self.employee1_id.write({"name": " Jean-Pierre Carnaud-Eyck"}) self.employee1_id.invalidate_recordset()