From 6434271d58538d81dcbf0b01e947438d2992556b Mon Sep 17 00:00:00 2001 From: Nikul-OSI Date: Tue, 18 Apr 2023 18:45:21 +0530 Subject: [PATCH 01/14] [ADD] partner_middlename: Added in v16 --- partner_middlename/README.rst | 119 ++++++++++++++++++ partner_middlename/__init__.py | 4 + partner_middlename/__manifest__.py | 15 +++ partner_middlename/models/__init__.py | 5 + .../models/res_config_settings.py | 34 +++++ partner_middlename/models/res_partner.py | 119 ++++++++++++++++++ partner_middlename/readme/CONFIGURE.rst | 1 + partner_middlename/readme/CONTRIBUTORS.rst | 3 + partner_middlename/readme/DESCRIPTION.rst | 1 + partner_middlename/readme/USAGE.rst | 5 + .../static/description/icon.png | Bin 0 -> 9455 bytes partner_middlename/views/res_partner.xml | 80 ++++++++++++ partner_middlename/views/res_user.xml | 26 ++++ 13 files changed, 412 insertions(+) create mode 100644 partner_middlename/README.rst create mode 100644 partner_middlename/__init__.py create mode 100644 partner_middlename/__manifest__.py create mode 100644 partner_middlename/models/__init__.py create mode 100644 partner_middlename/models/res_config_settings.py create mode 100644 partner_middlename/models/res_partner.py create mode 100644 partner_middlename/readme/CONFIGURE.rst create mode 100644 partner_middlename/readme/CONTRIBUTORS.rst create mode 100644 partner_middlename/readme/DESCRIPTION.rst create mode 100644 partner_middlename/readme/USAGE.rst create mode 100644 partner_middlename/static/description/icon.png create mode 100644 partner_middlename/views/res_partner.xml create mode 100644 partner_middlename/views/res_user.xml diff --git a/partner_middlename/README.rst b/partner_middlename/README.rst new file mode 100644 index 00000000000..a1f27282983 --- /dev/null +++ b/partner_middlename/README.rst @@ -0,0 +1,119 @@ +======================== +Partner second last name +======================== + +.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpartner--contact-lightgray.png?logo=github + :target: https://github.com/OCA/partner-contact/tree/16.0/partner_second_lastname + :alt: OCA/partner-contact +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_second_lastname + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png + :target: https://runbot.odoo-community.org/runbot/134/16.0 + :alt: Try me on Runbot + +|badge1| |badge2| |badge3| |badge4| |badge5| + +This module was written to extend the functionality of ``partner_firstname`` to +support having a second lastname for contact partners. + +In some countries, it's important to have a second last name for contacts. + +Contact partners will need to fill at least one of the name fields +(*First name*, *First last name* or *Second last name*). + +**Table of contents** + +.. contents:: + :local: + +Configuration +============= + +You can configure some common name patterns for the inverse function +in Settings > Configuration > General settings: + +* Lastname SecondLastname Firstname: For example 'Anderson Lavarge Robert' +* Lastname SecondLastname, Firstname: For example 'Anderson Lavarge, Robert' +* Firstname Lastname SecondLastname: For example 'Robert Anderson Lavarge' + +After applying the changes, you can recalculate all partners name clicking +"Recalculate names" button. Note: This process could take so much time depending +how many partners there are in database. + +You can use *_get_inverse_name* method to get firstname, lastname and +second lastname from a simple string and also *_get_computed_name* to get a +name form the firstname, lastname and second lastname. +These methods can be overridden to change the format specified above. + +Usage +===== + +To use this module, you need to: + +* Edit any partner's form. +* Make sure the partner is not a company. +* Enter firstname and lastnames. + +If you directly enter the full name instead of entering the other fields +separately (maybe from other form), this module will try to guess the best +match for your input and split it between firstname, lastname and second +lastname using an inverse function. + +If you can, always enter it manually please. Automatic guessing could fail for +you easily in some corner cases. + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us smashing it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +~~~~~~~ + +* Tecnativa + +Contributors +~~~~~~~~~~~~ + +* Jairo Llopis . +* Antonio Espinosa. +* Pedro M. Baeza . +* Nikul Chaudhary +* Manuel Regidor + +Maintainers +~~~~~~~~~~~ + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +This module is part of the `OCA/partner-contact `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/partner_middlename/__init__.py b/partner_middlename/__init__.py new file mode 100644 index 00000000000..4c4be2fcbcb --- /dev/null +++ b/partner_middlename/__init__.py @@ -0,0 +1,4 @@ +# Copyright (C) 2023 Open Source Integrators +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from . import models diff --git a/partner_middlename/__manifest__.py b/partner_middlename/__manifest__.py new file mode 100644 index 00000000000..e9daf365ba1 --- /dev/null +++ b/partner_middlename/__manifest__.py @@ -0,0 +1,15 @@ +# Copyright (C) 2023 Open Source Integrators +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +{ + "name": "Partner Middle Name", + "summary": "Have split Middle", + "version": "16.0.1.0.0", + "license": "AGPL-3", + "website": "https://github.com/OCA/partner-contact", + "author": "Open Source Integrators, " "Odoo Community Association (OCA)", + "category": "Partner Management", + "depends": ["partner_firstname"], + "data": ["views/res_partner.xml", "views/res_user.xml"], + "installable": True, +} diff --git a/partner_middlename/models/__init__.py b/partner_middlename/models/__init__.py new file mode 100644 index 00000000000..0c4235dd497 --- /dev/null +++ b/partner_middlename/models/__init__.py @@ -0,0 +1,5 @@ +# Copyright (C) 2023 Open Source Integrators +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from . import res_config_settings +from . import res_partner diff --git a/partner_middlename/models/res_config_settings.py b/partner_middlename/models/res_config_settings.py new file mode 100644 index 00000000000..b22d9c9e6ac --- /dev/null +++ b/partner_middlename/models/res_config_settings.py @@ -0,0 +1,34 @@ +# Copyright (C) 2023 Open Source Integrators +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from odoo import models + + +class ResConfigSettings(models.TransientModel): + _inherit = "res.config.settings" + + def _partner_names_order_selection(self): + options = super()._partner_names_order_selection() + new_labels = { + "last_first": "Firstname Middlename Lastname", + "last_first_comma": "Lastname, Firstname Middlename", + } + return [(k, new_labels[k]) if k in new_labels else (k, v) for k, v in options] + + def _partners_for_recalculating(self): + return self.env["res.partner"].search( + [ + ("is_company", "=", False), + "|", + "&", + ("firstname", "!=", False), + ("lastname", "!=", False), + "|", + "&", + ("firstname", "!=", False), + ("middlename", "!=", False), + "&", + ("lastname", "!=", False), + ("middlename", "!=", False), + ] + ) diff --git a/partner_middlename/models/res_partner.py b/partner_middlename/models/res_partner.py new file mode 100644 index 00000000000..7976870fe8e --- /dev/null +++ b/partner_middlename/models/res_partner.py @@ -0,0 +1,119 @@ +# Copyright (C) 2023 Open Source Integrators +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). + +from odoo import api, fields, models + +from odoo.addons.partner_firstname import exceptions + + +class ResPartner(models.Model): + _inherit = "res.partner" + + middlename = fields.Char("Middle Name") + + @api.model + def _get_computed_name(self, lastname, firstname, middlename=None): + """Compute the name combined with the second lastname too. + + We have 2 lastnames, so lastnames and firstname will be separated by a + comma. + """ + order = self._get_names_order() + names = list() + if order == "last_first": + if firstname: + names.append(firstname) + if middlename: + names.append(middlename) + if lastname: + names.append(lastname) + else: + if lastname: + names.append(lastname) + if names and firstname and order == "last_first_comma": + names[-1] = names[-1] + "," + if firstname: + names.append(firstname) + if middlename: + names.append(middlename) + return " ".join(names) + + @api.depends("firstname", "lastname", "middlename") + def _compute_name(self): + """Write :attr:`~.name` according to splitted data.""" + for partner in self: + partner.name = self._get_computed_name( + partner.lastname, + partner.firstname, + partner.middlename, + ) + + def _inverse_name(self): + """Try to revert the effect of :meth:`._compute_name`.""" + self.ensure_one() + parts = self._get_inverse_name(self.name, self.is_company) + # Avoid to hit :meth:`~._check_name` with all 3 fields being ``False`` + before, after = {}, {} + for key, value in parts.items(): + (before if value else after)[key] = value + if any([before[k] != self[k] for k in list(before.keys())]): + self.update(before) + if any([after[k] != self[k] for k in list(after.keys())]): + self.update(after) + + @api.model + def _get_inverse_name(self, name, is_company=False): + """Compute the inverted name. + + - If the partner is a company, save it in the lastname. + - Otherwise, make a guess. + """ + result = { + "firstname": False, + "lastname": name or False, + "middlename": False, + } + + # Company name goes to the lastname + if not name or is_company: + return result + + order = self._get_names_order() + result.update(super()._get_inverse_name(name, is_company)) + + if order in ("last_first", "last_first_comma"): + parts = self._split_part("lastname", result) + if parts: + result.update({"lastname": parts[0], "middlename": " ".join(parts[1:])}) + else: + parts = self._split_part("firstname", result) + if parts: + result.update( + {"firstname": parts[-1], "middlename": " ".join(parts[:-1])} + ) + return result + + def _split_part(self, name_part, name_split): + """Split a given part of a name. + + :param name_split: The parts of the name + :type dict + + :param name_part: The part to split + :type str + """ + name = name_split.get(name_part, False) + parts = name.split(" ", 1) if name else [] + if not name or len(parts) < 2: + return False + return parts + + @api.constrains("firstname", "lastname", "middlename") + def _check_name(self): + """Ensure at least one name is set.""" + try: + return super()._check_name() + except exceptions.EmptyNamesError: + for partner in self: + if not partner.middlename: + raise diff --git a/partner_middlename/readme/CONFIGURE.rst b/partner_middlename/readme/CONFIGURE.rst new file mode 100644 index 00000000000..7251cafe1a8 --- /dev/null +++ b/partner_middlename/readme/CONFIGURE.rst @@ -0,0 +1 @@ +At Settings / General Settings / Partner Names Order, select option "Firstname Middlename Lastname" or " Lastname, Firstname Middlename". diff --git a/partner_middlename/readme/CONTRIBUTORS.rst b/partner_middlename/readme/CONTRIBUTORS.rst new file mode 100644 index 00000000000..f25441b9e8d --- /dev/null +++ b/partner_middlename/readme/CONTRIBUTORS.rst @@ -0,0 +1,3 @@ +* `Open Source Integrators `_: + * Daniel Reis + * Nikul Chaudhary diff --git a/partner_middlename/readme/DESCRIPTION.rst b/partner_middlename/readme/DESCRIPTION.rst new file mode 100644 index 00000000000..7b7b7230f88 --- /dev/null +++ b/partner_middlename/readme/DESCRIPTION.rst @@ -0,0 +1 @@ +Allows to enter contact names using three separate fields, for First name, Middle Name and Last Name. diff --git a/partner_middlename/readme/USAGE.rst b/partner_middlename/readme/USAGE.rst new file mode 100644 index 00000000000..68e4d14884f --- /dev/null +++ b/partner_middlename/readme/USAGE.rst @@ -0,0 +1,5 @@ +On the Contact form, create a new contact. + +* Set contact to "Individual". The full name will not be directly editable. +* Set all or any of the First Name, Middle name and Last Name fields. +* The full name should be automatically populated based on the name fields set, and the general setting selected. diff --git a/partner_middlename/static/description/icon.png b/partner_middlename/static/description/icon.png new file mode 100644 index 0000000000000000000000000000000000000000..3a0328b516c4980e8e44cdb63fd945757ddd132d GIT binary patch literal 9455 zcmW++2RxMjAAjx~&dlBk9S+%}OXg)AGE&Cb*&}d0jUxM@u(PQx^-s)697TX`ehR4?GS^qbkof1cslKgkU)h65qZ9Oc=ml_0temigYLJfnz{IDzUf>bGs4N!v3=Z3jMq&A#7%rM5eQ#dc?k~! zVpnB`o+K7|Al`Q_U;eD$B zfJtP*jH`siUq~{KE)`jP2|#TUEFGRryE2`i0**z#*^6~AI|YzIWy$Cu#CSLW3q=GA z6`?GZymC;dCPk~rBS%eCb`5OLr;RUZ;D`}um=H)BfVIq%7VhiMr)_#G0N#zrNH|__ zc+blN2UAB0=617@>_u;MPHN;P;N#YoE=)R#i$k_`UAA>WWCcEVMh~L_ zj--gtp&|K1#58Yz*AHCTMziU1Jzt_jG0I@qAOHsk$2}yTmVkBp_eHuY$A9)>P6o~I z%aQ?!(GqeQ-Y+b0I(m9pwgi(IIZZzsbMv+9w{PFtd_<_(LA~0H(xz{=FhLB@(1&qHA5EJw1>>=%q2f&^X>IQ{!GJ4e9U z&KlB)z(84HmNgm2hg2C0>WM{E(DdPr+EeU_N@57;PC2&DmGFW_9kP&%?X4}+xWi)( z;)z%wI5>D4a*5XwD)P--sPkoY(a~WBw;E~AW`Yue4kFa^LM3X`8x|}ZUeMnqr}>kH zG%WWW>3ml$Yez?i%)2pbKPI7?5o?hydokgQyZsNEr{a|mLdt;X2TX(#B1j35xPnPW z*bMSSOauW>o;*=kO8ojw91VX!qoOQb)zHJ!odWB}d+*K?#sY_jqPdg{Sm2HdYzdEx zOGVPhVRTGPtv0o}RfVP;Nd(|CB)I;*t&QO8h zFfekr30S!-LHmV_Su-W+rEwYXJ^;6&3|L$mMC8*bQptyOo9;>Qb9Q9`ySe3%V$A*9 zeKEe+b0{#KWGp$F+tga)0RtI)nhMa-K@JS}2krK~n8vJ=Ngm?R!9G<~RyuU0d?nz# z-5EK$o(!F?hmX*2Yt6+coY`6jGbb7tF#6nHA zuKk=GGJ;ZwON1iAfG$E#Y7MnZVmrY|j0eVI(DN_MNFJmyZ|;w4tf@=CCDZ#5N_0K= z$;R~bbk?}TpfDjfB&aiQ$VA}s?P}xPERJG{kxk5~R`iRS(SK5d+Xs9swCozZISbnS zk!)I0>t=A<-^z(cmSFz3=jZ23u13X><0b)P)^1T_))Kr`e!-pb#q&J*Q`p+B6la%C zuVl&0duN<;uOsB3%T9Fp8t{ED108<+W(nOZd?gDnfNBC3>M8WE61$So|P zVvqH0SNtDTcsUdzaMDpT=Ty0pDHHNL@Z0w$Y`XO z2M-_r1S+GaH%pz#Uy0*w$Vdl=X=rQXEzO}d6J^R6zjM1u&c9vYLvLp?W7w(?np9x1 zE_0JSAJCPB%i7p*Wvg)pn5T`8k3-uR?*NT|J`eS#_#54p>!p(mLDvmc-3o0mX*mp_ zN*AeS<>#^-{S%W<*mz^!X$w_2dHWpcJ6^j64qFBft-o}o_Vx80o0>}Du;>kLts;$8 zC`7q$QI(dKYG`Wa8#wl@V4jVWBRGQ@1dr-hstpQL)Tl+aqVpGpbSfN>5i&QMXfiZ> zaA?T1VGe?rpQ@;+pkrVdd{klI&jVS@I5_iz!=UMpTsa~mBga?1r}aRBm1WS;TT*s0f0lY=JBl66Upy)-k4J}lh=P^8(SXk~0xW=T9v*B|gzIhN z>qsO7dFd~mgxAy4V?&)=5ieYq?zi?ZEoj)&2o)RLy=@hbCRcfT5jigwtQGE{L*8<@Yd{zg;CsL5mvzfDY}P-wos_6PfprFVaeqNE%h zKZhLtcQld;ZD+>=nqN~>GvROfueSzJD&BE*}XfU|H&(FssBqY=hPCt`d zH?@s2>I(|;fcW&YM6#V#!kUIP8$Nkdh0A(bEVj``-AAyYgwY~jB zT|I7Bf@%;7aL7Wf4dZ%VqF$eiaC38OV6oy3Z#TER2G+fOCd9Iaoy6aLYbPTN{XRPz z;U!V|vBf%H!}52L2gH_+j;`bTcQRXB+y9onc^wLm5wi3-Be}U>k_u>2Eg$=k!(l@I zcCg+flakT2Nej3i0yn+g+}%NYb?ta;R?(g5SnwsQ49U8Wng8d|{B+lyRcEDvR3+`O{zfmrmvFrL6acVP%yG98X zo&+VBg@px@i)%o?dG(`T;n*$S5*rnyiR#=wW}}GsAcfyQpE|>a{=$Hjg=-*_K;UtD z#z-)AXwSRY?OPefw^iI+ z)AXz#PfEjlwTes|_{sB?4(O@fg0AJ^g8gP}ex9Ucf*@_^J(s_5jJV}c)s$`Myn|Kd z$6>}#q^n{4vN@+Os$m7KV+`}c%4)4pv@06af4-x5#wj!KKb%caK{A&Y#Rfs z-po?Dcb1({W=6FKIUirH&(yg=*6aLCekcKwyfK^JN5{wcA3nhO(o}SK#!CINhI`-I z1)6&n7O&ZmyFMuNwvEic#IiOAwNkR=u5it{B9n2sAJV5pNhar=j5`*N!Na;c7g!l$ z3aYBqUkqqTJ=Re-;)s!EOeij=7SQZ3Hq}ZRds%IM*PtM$wV z@;rlc*NRK7i3y5BETSKuumEN`Xu_8GP1Ri=OKQ$@I^ko8>H6)4rjiG5{VBM>B|%`&&s^)jS|-_95&yc=GqjNo{zFkw%%HHhS~e=s zD#sfS+-?*t|J!+ozP6KvtOl!R)@@-z24}`9{QaVLD^9VCSR2b`b!KC#o;Ki<+wXB6 zx3&O0LOWcg4&rv4QG0)4yb}7BFSEg~=IR5#ZRj8kg}dS7_V&^%#Do==#`u zpy6{ox?jWuR(;pg+f@mT>#HGWHAJRRDDDv~@(IDw&R>9643kK#HN`!1vBJHnC+RM&yIh8{gG2q zA%e*U3|N0XSRa~oX-3EAneep)@{h2vvd3Xvy$7og(sayr@95+e6~Xvi1tUqnIxoIH zVWo*OwYElb#uyW{Imam6f2rGbjR!Y3`#gPqkv57dB6K^wRGxc9B(t|aYDGS=m$&S!NmCtrMMaUg(c zc2qC=2Z`EEFMW-me5B)24AqF*bV5Dr-M5ig(l-WPS%CgaPzs6p_gnCIvTJ=Y<6!gT zVt@AfYCzjjsMEGi=rDQHo0yc;HqoRNnNFeWZgcm?f;cp(6CNylj36DoL(?TS7eU#+ z7&mfr#y))+CJOXQKUMZ7QIdS9@#-}7y2K1{8)cCt0~-X0O!O?Qx#E4Og+;A2SjalQ zs7r?qn0H044=sDN$SRG$arw~n=+T_DNdSrarmu)V6@|?1-ZB#hRn`uilTGPJ@fqEy zGt(f0B+^JDP&f=r{#Y_wi#AVDf-y!RIXU^0jXsFpf>=Ji*TeqSY!H~AMbJdCGLhC) zn7Rx+sXw6uYj;WRYrLd^5IZq@6JI1C^YkgnedZEYy<&4(z%Q$5yv#Boo{AH8n$a zhb4Y3PWdr269&?V%uI$xMcUrMzl=;w<_nm*qr=c3Rl@i5wWB;e-`t7D&c-mcQl7x! zZWB`UGcw=Y2=}~wzrfLx=uet<;m3~=8I~ZRuzvMQUQdr+yTV|ATf1Uuomr__nDf=X zZ3WYJtHp_ri(}SQAPjv+Y+0=fH4krOP@S&=zZ-t1jW1o@}z;xk8 z(Nz1co&El^HK^NrhVHa-_;&88vTU>_J33=%{if;BEY*J#1n59=07jrGQ#IP>@u#3A z;!q+E1Rj3ZJ+!4bq9F8PXJ@yMgZL;>&gYA0%_Kbi8?S=XGM~dnQZQ!yBSgcZhY96H zrWnU;k)qy`rX&&xlDyA%(a1Hhi5CWkmg(`Gb%m(HKi-7Z!LKGRP_B8@`7&hdDy5n= z`OIxqxiVfX@OX1p(mQu>0Ai*v_cTMiw4qRt3~NBvr9oBy0)r>w3p~V0SCm=An6@3n)>@z!|o-$HvDK z|3D2ZMJkLE5loMKl6R^ez@Zz%S$&mbeoqH5`Bb){Ei21q&VP)hWS2tjShfFtGE+$z zzCR$P#uktu+#!w)cX!lWN1XU%K-r=s{|j?)Akf@q#3b#{6cZCuJ~gCxuMXRmI$nGtnH+-h z+GEi!*X=AP<|fG`1>MBdTb?28JYc=fGvAi2I<$B(rs$;eoJCyR6_bc~p!XR@O-+sD z=eH`-ye})I5ic1eL~TDmtfJ|8`0VJ*Yr=hNCd)G1p2MMz4C3^Mj?7;!w|Ly%JqmuW zlIEW^Ft%z?*|fpXda>Jr^1noFZEwFgVV%|*XhH@acv8rdGxeEX{M$(vG{Zw+x(ei@ zmfXb22}8-?Fi`vo-YVrTH*C?a8%M=Hv9MqVH7H^J$KsD?>!SFZ;ZsvnHr_gn=7acz z#W?0eCdVhVMWN12VV^$>WlQ?f;P^{(&pYTops|btm6aj>_Uz+hqpGwB)vWp0Cf5y< zft8-je~nn?W11plq}N)4A{l8I7$!ks_x$PXW-2XaRFswX_BnF{R#6YIwMhAgd5F9X zGmwdadS6(a^fjHtXg8=l?Rc0Sm%hk6E9!5cLVloEy4eh(=FwgP`)~I^5~pBEWo+F6 zSf2ncyMurJN91#cJTy_u8Y}@%!bq1RkGC~-bV@SXRd4F{R-*V`bS+6;W5vZ(&+I<9$;-V|eNfLa5n-6% z2(}&uGRF;p92eS*sE*oR$@pexaqr*meB)VhmIg@h{uzkk$9~qh#cHhw#>O%)b@+(| z^IQgqzuj~Sk(J;swEM-3TrJAPCq9k^^^`q{IItKBRXYe}e0Tdr=Huf7da3$l4PdpwWDop%^}n;dD#K4s#DYA8SHZ z&1!riV4W4R7R#C))JH1~axJ)RYnM$$lIR%6fIVA@zV{XVyx}C+a-Dt8Y9M)^KU0+H zR4IUb2CJ{Hg>CuaXtD50jB(_Tcx=Z$^WYu2u5kubqmwp%drJ6 z?Fo40g!Qd<-l=TQxqHEOuPX0;^z7iX?Ke^a%XT<13TA^5`4Xcw6D@Ur&VT&CUe0d} z1GjOVF1^L@>O)l@?bD~$wzgf(nxX1OGD8fEV?TdJcZc2KoUe|oP1#=$$7ee|xbY)A zDZq+cuTpc(fFdj^=!;{k03C69lMQ(|>uhRfRu%+!k&YOi-3|1QKB z z?n?eq1XP>p-IM$Z^C;2L3itnbJZAip*Zo0aw2bs8@(s^~*8T9go!%dHcAz2lM;`yp zD=7&xjFV$S&5uDaiScyD?B-i1ze`+CoRtz`Wn+Zl&#s4&}MO{@N!ufrzjG$B79)Y2d3tBk&)TxUTw@QS0TEL_?njX|@vq?Uz(nBFK5Pq7*xj#u*R&i|?7+6# z+|r_n#SW&LXhtheZdah{ZVoqwyT{D>MC3nkFF#N)xLi{p7J1jXlmVeb;cP5?e(=f# zuT7fvjSbjS781v?7{)-X3*?>tq?)Yd)~|1{BDS(pqC zC}~H#WXlkUW*H5CDOo<)#x7%RY)A;ShGhI5s*#cRDA8YgqG(HeKDx+#(ZQ?386dv! zlXCO)w91~Vw4AmOcATuV653fa9R$fyK8ul%rG z-wfS zihugoZyr38Im?Zuh6@RcF~t1anQu7>#lPpb#}4cOA!EM11`%f*07RqOVkmX{p~KJ9 z^zP;K#|)$`^Rb{rnHGH{~>1(fawV0*Z#)}M`m8-?ZJV<+e}s9wE# z)l&az?w^5{)`S(%MRzxdNqrs1n*-=jS^_jqE*5XDrA0+VE`5^*p3CuM<&dZEeCjoz zR;uu_H9ZPZV|fQq`Cyw4nscrVwi!fE6ciMmX$!_hN7uF;jjKG)d2@aC4ropY)8etW=xJvni)8eHi`H$%#zn^WJ5NLc-rqk|u&&4Z6fD_m&JfSI1Bvb?b<*n&sfl0^t z=HnmRl`XrFvMKB%9}>PaA`m-fK6a0(8=qPkWS5bb4=v?XcWi&hRY?O5HdulRi4?fN zlsJ*N-0Qw+Yic@s0(2uy%F@ib;GjXt01Fmx5XbRo6+n|pP(&nodMoap^z{~q ziEeaUT@Mxe3vJSfI6?uLND(CNr=#^W<1b}jzW58bIfyWTDle$mmS(|x-0|2UlX+9k zQ^EX7Nw}?EzVoBfT(-LT|=9N@^hcn-_p&sqG z&*oVs2JSU+N4ZD`FhCAWaS;>|wH2G*Id|?pa#@>tyxX`+4HyIArWDvVrX)2WAOQff z0qyHu&-S@i^MS-+j--!pr4fPBj~_8({~e1bfcl0wI1kaoN>mJL6KUPQm5N7lB(ui1 zE-o%kq)&djzWJ}ob<-GfDlkB;F31j-VHKvQUGQ3sp`CwyGJk_i!y^sD0fqC@$9|jO zOqN!r!8-p==F@ZVP=U$qSpY(gQ0)59P1&t@y?5rvg<}E+GB}26NYPp4f2YFQrQtot5mn3wu_qprZ=>Ig-$ zbW26Ws~IgY>}^5w`vTB(G`PTZaDiGBo5o(tp)qli|NeV( z@H_=R8V39rt5J5YB2Ky?4eJJ#b`_iBe2ot~6%7mLt5t8Vwi^Jy7|jWXqa3amOIoRb zOr}WVFP--DsS`1WpN%~)t3R!arKF^Q$e12KEqU36AWwnCBICpH4XCsfnyrHr>$I$4 z!DpKX$OKLWarN7nv@!uIA+~RNO)l$$w}p(;b>mx8pwYvu;dD_unryX_NhT8*Tj>BTrTTL&!?O+%Rv;b?B??gSzdp?6Uug9{ zd@V08Z$BdI?fpoCS$)t4mg4rT8Q_I}h`0d-vYZ^|dOB*Q^S|xqTV*vIg?@fVFSmMpaw0qtTRbx} z({Pg?#{2`sc9)M5N$*N|4;^t$+QP?#mov zGVC@I*lBVrOU-%2y!7%)fAKjpEFsgQc4{amtiHb95KQEwvf<(3T<9-Zm$xIew#P22 zc2Ix|App^>v6(3L_MCU0d3W##AB0M~3D00EWoKZqsJYT(#@w$Y_H7G22M~ApVFTRHMI_3be)Lkn#0F*V8Pq zc}`Cjy$bE;FJ6H7p=0y#R>`}-m4(0F>%@P|?7fx{=R^uFdISRnZ2W_xQhD{YuR3t< z{6yxu=4~JkeA;|(J6_nv#>Nvs&FuLA&PW^he@t(UwFFE8)|a!R{`E`K`i^ZnyE4$k z;(749Ix|oi$c3QbEJ3b~D_kQsPz~fIUKym($a_7dJ?o+40*OLl^{=&oq$<#Q(yyrp z{J-FAniyAw9tPbe&IhQ|a`DqFTVQGQ&Gq3!C2==4x{6EJwiPZ8zub-iXoUtkJiG{} zPaR&}_fn8_z~(=;5lD-aPWD3z8PZS@AaUiomF!G8I}Mf>e~0g#BelA-5#`cj;O5>N Xviia!U7SGha1wx#SCgwmn*{w2TRX*I literal 0 HcmV?d00001 diff --git a/partner_middlename/views/res_partner.xml b/partner_middlename/views/res_partner.xml new file mode 100644 index 00000000000..2f06a8f9d10 --- /dev/null +++ b/partner_middlename/views/res_partner.xml @@ -0,0 +1,80 @@ + + + + res.partner + + + + + {'required': [('lastname', '=', False), ('middlename', '=', False), + ('is_company', '=', False), ('type', '=', 'contact')]} + + + + + {'required': [('firstname', '=', False), ('middlename', '=', False), + ('is_company', '=', False), ('type', '=', 'contact')]} + + + + + + + + + res.partner + + + + + + {'required': [('lastname', '=', False), ('middlename', '=', False), + ('is_company', '=', False), ('type', '=', 'contact')]} + + + + + {'required': [('firstname', '=', False), ('middlename', '=', False), + ('is_company', '=', False), ('type', '=', 'contact')]} + + + + + + + + + {'required': [('lastname', '=', False), ('middlename', '=', False), + ('is_company', '=', False), ('type', '=', 'contact')]} + + + + + {'required': [('firstname', '=', False), ('middlename', '=', False), + ('is_company', '=', False), ('type', '=', 'contact')]} + + + + + + + + diff --git a/partner_middlename/views/res_user.xml b/partner_middlename/views/res_user.xml new file mode 100644 index 00000000000..e976af1a9b9 --- /dev/null +++ b/partner_middlename/views/res_user.xml @@ -0,0 +1,26 @@ + + + + Add second last name + res.users + + + + + {'required': [('lastname', '=', False), ('middlename', '=', False)]} + + + + + {'required': [('firstname', '=', False), ('middlename', '=', False)]} + + + + + + + + From ef99c420347a8c433ba5ec3110876e49a257921c Mon Sep 17 00:00:00 2001 From: Daniel Reis Date: Tue, 18 Apr 2023 15:26:25 +0100 Subject: [PATCH 02/14] [FIX] partner_middlename: add to rebel module list --- partner_middlename/readme/DESCRIPTION.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/partner_middlename/readme/DESCRIPTION.rst b/partner_middlename/readme/DESCRIPTION.rst index 7b7b7230f88..a7ef6761899 100644 --- a/partner_middlename/readme/DESCRIPTION.rst +++ b/partner_middlename/readme/DESCRIPTION.rst @@ -1 +1,4 @@ Allows to enter contact names using three separate fields, for First name, Middle Name and Last Name. + +NOTE: currently this feature is incompatible with te Partner Second Last Name (``partner_second_lastname``), +please don't install them together in the same database. From 13bd0a8e1e65df63ba6373227bca97382a047e65 Mon Sep 17 00:00:00 2001 From: Nikul-OSI Date: Wed, 19 Apr 2023 14:38:55 +0530 Subject: [PATCH 03/14] [FIX] Fixed code and Added a unit test case --- partner_middlename/README.rst | 120 +----------------- .../models/res_config_settings.py | 8 -- partner_middlename/models/res_partner.py | 37 +++--- partner_middlename/tests/__init__.py | 5 + partner_middlename/tests/test_config.py | 32 +++++ partner_middlename/tests/test_name.py | 114 +++++++++++++++++ 6 files changed, 171 insertions(+), 145 deletions(-) create mode 100644 partner_middlename/tests/__init__.py create mode 100644 partner_middlename/tests/test_config.py create mode 100644 partner_middlename/tests/test_name.py diff --git a/partner_middlename/README.rst b/partner_middlename/README.rst index a1f27282983..0d7429afc0d 100644 --- a/partner_middlename/README.rst +++ b/partner_middlename/README.rst @@ -1,119 +1 @@ -======================== -Partner second last name -======================== - -.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! - !! This file is generated by oca-gen-addon-readme !! - !! changes will be overwritten. !! - !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! - -.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png - :target: https://odoo-community.org/page/development-status - :alt: Beta -.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png - :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html - :alt: License: AGPL-3 -.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpartner--contact-lightgray.png?logo=github - :target: https://github.com/OCA/partner-contact/tree/16.0/partner_second_lastname - :alt: OCA/partner-contact -.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png - :target: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_second_lastname - :alt: Translate me on Weblate -.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png - :target: https://runbot.odoo-community.org/runbot/134/16.0 - :alt: Try me on Runbot - -|badge1| |badge2| |badge3| |badge4| |badge5| - -This module was written to extend the functionality of ``partner_firstname`` to -support having a second lastname for contact partners. - -In some countries, it's important to have a second last name for contacts. - -Contact partners will need to fill at least one of the name fields -(*First name*, *First last name* or *Second last name*). - -**Table of contents** - -.. contents:: - :local: - -Configuration -============= - -You can configure some common name patterns for the inverse function -in Settings > Configuration > General settings: - -* Lastname SecondLastname Firstname: For example 'Anderson Lavarge Robert' -* Lastname SecondLastname, Firstname: For example 'Anderson Lavarge, Robert' -* Firstname Lastname SecondLastname: For example 'Robert Anderson Lavarge' - -After applying the changes, you can recalculate all partners name clicking -"Recalculate names" button. Note: This process could take so much time depending -how many partners there are in database. - -You can use *_get_inverse_name* method to get firstname, lastname and -second lastname from a simple string and also *_get_computed_name* to get a -name form the firstname, lastname and second lastname. -These methods can be overridden to change the format specified above. - -Usage -===== - -To use this module, you need to: - -* Edit any partner's form. -* Make sure the partner is not a company. -* Enter firstname and lastnames. - -If you directly enter the full name instead of entering the other fields -separately (maybe from other form), this module will try to guess the best -match for your input and split it between firstname, lastname and second -lastname using an inverse function. - -If you can, always enter it manually please. Automatic guessing could fail for -you easily in some corner cases. - -Bug Tracker -=========== - -Bugs are tracked on `GitHub Issues `_. -In case of trouble, please check there if your issue has already been reported. -If you spotted it first, help us smashing it by providing a detailed and welcomed -`feedback `_. - -Do not contact contributors directly about support or help with technical issues. - -Credits -======= - -Authors -~~~~~~~ - -* Tecnativa - -Contributors -~~~~~~~~~~~~ - -* Jairo Llopis . -* Antonio Espinosa. -* Pedro M. Baeza . -* Nikul Chaudhary -* Manuel Regidor - -Maintainers -~~~~~~~~~~~ - -This module is maintained by the OCA. - -.. image:: https://odoo-community.org/logo.png - :alt: Odoo Community Association - :target: https://odoo-community.org - -OCA, or the Odoo Community Association, is a nonprofit organization whose -mission is to support the collaborative development of Odoo features and -promote its widespread use. - -This module is part of the `OCA/partner-contact `_ project on GitHub. - -You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. +AUTOMATICALLY GENERATED diff --git a/partner_middlename/models/res_config_settings.py b/partner_middlename/models/res_config_settings.py index b22d9c9e6ac..33308ca7fa7 100644 --- a/partner_middlename/models/res_config_settings.py +++ b/partner_middlename/models/res_config_settings.py @@ -7,14 +7,6 @@ class ResConfigSettings(models.TransientModel): _inherit = "res.config.settings" - def _partner_names_order_selection(self): - options = super()._partner_names_order_selection() - new_labels = { - "last_first": "Firstname Middlename Lastname", - "last_first_comma": "Lastname, Firstname Middlename", - } - return [(k, new_labels[k]) if k in new_labels else (k, v) for k, v in options] - def _partners_for_recalculating(self): return self.env["res.partner"].search( [ diff --git a/partner_middlename/models/res_partner.py b/partner_middlename/models/res_partner.py index 7976870fe8e..292ec5f4882 100644 --- a/partner_middlename/models/res_partner.py +++ b/partner_middlename/models/res_partner.py @@ -13,30 +13,25 @@ class ResPartner(models.Model): @api.model def _get_computed_name(self, lastname, firstname, middlename=None): - """Compute the name combined with the second lastname too. - - We have 2 lastnames, so lastnames and firstname will be separated by a - comma. - """ + """Compute the 'name' field according to splitted data. + You can override this method to change the order of lastname and + firstname and middlename the computed name""" order = self._get_names_order() - names = list() - if order == "last_first": - if firstname: - names.append(firstname) - if middlename: - names.append(middlename) - if lastname: - names.append(lastname) - else: + if order == "last_first_comma": + names = list() if lastname: names.append(lastname) - if names and firstname and order == "last_first_comma": + if names and firstname: names[-1] = names[-1] + "," if firstname: names.append(firstname) if middlename: names.append(middlename) - return " ".join(names) + return " ".join(names) + elif order == "first_last": + return " ".join(p for p in (firstname, middlename, lastname) if p) + else: + return " ".join(p for p in (lastname, firstname, middlename) if p) @api.depends("firstname", "lastname", "middlename") def _compute_name(self): @@ -81,10 +76,16 @@ def _get_inverse_name(self, name, is_company=False): order = self._get_names_order() result.update(super()._get_inverse_name(name, is_company)) - if order in ("last_first", "last_first_comma"): + if order == "first_last": parts = self._split_part("lastname", result) if parts: - result.update({"lastname": parts[0], "middlename": " ".join(parts[1:])}) + result.update({"middlename": parts[0], "lastname": " ".join(parts[1:])}) + elif order == "last_first_comma": + parts = self._split_part("firstname", result) + if parts: + result.update( + {"firstname": parts[0], "middlename": " ".join(parts[1:])} + ) else: parts = self._split_part("firstname", result) if parts: diff --git a/partner_middlename/tests/__init__.py b/partner_middlename/tests/__init__.py new file mode 100644 index 00000000000..4b950899b0a --- /dev/null +++ b/partner_middlename/tests/__init__.py @@ -0,0 +1,5 @@ +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). + +from . import test_name +from . import test_config +from odoo.addons.partner_firstname.tests import test_empty diff --git a/partner_middlename/tests/test_config.py b/partner_middlename/tests/test_config.py new file mode 100644 index 00000000000..49cea5c81ac --- /dev/null +++ b/partner_middlename/tests/test_config.py @@ -0,0 +1,32 @@ +# Copyright 2017 Tecnativa - Pedro M. Baeza +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). + +from odoo.tests.common import TransactionCase + + +class TestConfig(TransactionCase): + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.wizard = cls.env["res.config.settings"].create({}) + cls.partner = cls.env["res.partner"].create( + {"firstname": "First", "middlename": "Middle", "lastname": "Last"} + ) + + def test_last_first(self): + self.wizard.partner_names_order = "last_first" + self.wizard.set_values() + self.wizard.action_recalculate_partners_name() + self.assertEqual(self.partner.name, "Last First Middle") + + def test_last_first_comma(self): + self.wizard.partner_names_order = "last_first_comma" + self.wizard.set_values() + self.wizard.action_recalculate_partners_name() + self.assertEqual(self.partner.name, "Last, First Middle") + + def test_first_last(self): + self.wizard.partner_names_order = "first_last" + self.wizard.set_values() + self.wizard.action_recalculate_partners_name() + self.assertEqual(self.partner.name, "First Middle Last") diff --git a/partner_middlename/tests/test_name.py b/partner_middlename/tests/test_name.py new file mode 100644 index 00000000000..187d64c8588 --- /dev/null +++ b/partner_middlename/tests/test_name.py @@ -0,0 +1,114 @@ +# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). +# Copyright 2015 Grupo ESOC Ingeniería de Servicios, S.L.U. +# Copyright 2015 Antiun Ingenieria S.L. - Antonio Espinosa + +from odoo.tests.common import TransactionCase + +from odoo.addons.partner_firstname.tests.base import MailInstalled + + +class PersonCase(TransactionCase): + """Test ``res.partner`` when it is a person.""" + + model = "res.partner" + context = dict() + + def setUp(self): + super().setUp() + self.env["ir.config_parameter"].set_param( + "partner_names_order", "last_first_comma" + ) + + self.firstname = "Fírstname" + self.middlename = "Middlename" + self.lastname = "Làstname1" + self.template = "%(last1)s %(first)s, %(last2)s" + + def tearDown(self): + try: + new = self.env[self.model].with_context(**self.context).create(self.params) + + # Check that each individual field matches + self.assertEqual(self.firstname, new.firstname, "First name saved badly.") + self.assertEqual(self.lastname, new.lastname, "Last name 1 saved badly.") + self.assertEqual( + self.middlename, new.middlename, "Middle name saved badly." + ) + + # Check that name gets saved fine + self.assertEqual( + self.template + % ( + { + "first": self.firstname, + "last1": self.lastname, + "last2": self.middlename, + } + ), + new.name, + "Name saved badly.", + ) + + finally: + super().tearDown() + + def test_firstname_first(self): + """Create a person setting his first name first.""" + self.env["ir.config_parameter"].set_param("partner_names_order", "first_last") + self.template = "%(first)s %(last2)s %(last1)s" + self.params = { + "is_company": False, + "name": "{} {} {}".format(self.firstname, self.middlename, self.lastname), + } + + def test_firstname_last_wo_comma(self): + """Create a person setting his first name last and the order as 'last_first'""" + self.env["ir.config_parameter"].set_param("partner_names_order", "last_first") + self.template = "%(last1)s %(first)s %(last2)s" + self.params = { + "is_company": False, + "name": "{} {} {}".format(self.lastname, self.middlename, self.firstname), + } + + def test_firstname_only(self): + """Create a person setting his first name only.""" + self.env["ir.config_parameter"].set_param("partner_names_order", "first_last") + self.firstname = self.middlename = False + self.template = "%(last1)s" + self.params = { + "is_company": False, + "name": self.lastname, + } + + def test_firstname_lastname_only(self): + """Create a person setting his first name and last name 1 only.""" + self.env["ir.config_parameter"].set_param("partner_names_order", "first_last") + self.middlename = False + self.template = "%(first)s %(last1)s" + self.params = { + "is_company": False, + "name": "{} {}".format(self.firstname, self.lastname), + } + + def test_lastname_firstname_only_wo_comma(self): + """Create a person setting his last name 1 and first name only. + Set order to 'last_first' to test name split without comma""" + self.env["ir.config_parameter"].set_param("partner_names_order", "last_first") + self.middlename = False + self.template = "%(last1)s %(first)s" + self.params = { + "is_company": False, + "name": "{} {}".format(self.lastname, self.firstname), + } + + +class UserCase(PersonCase, MailInstalled): + """Test ``res.users``.""" + + model = "res.users" + context = {"default_login": "user@example.com"} + + def tearDown(self): + # Skip if ``mail`` is installed + if not self.mail_installed(): + super().tearDown() From 107e9533a9ac319dabdb26d04f3bbeac59b8cd70 Mon Sep 17 00:00:00 2001 From: oca-ci Date: Sat, 22 Apr 2023 17:00:17 +0000 Subject: [PATCH 04/14] [UPD] Update partner_middlename.pot --- .../i18n/partner_middlename.pot | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 partner_middlename/i18n/partner_middlename.pot diff --git a/partner_middlename/i18n/partner_middlename.pot b/partner_middlename/i18n/partner_middlename.pot new file mode 100644 index 00000000000..dbe5754ef6f --- /dev/null +++ b/partner_middlename/i18n/partner_middlename.pot @@ -0,0 +1,30 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * partner_middlename +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 16.0\n" +"Report-Msgid-Bugs-To: \n" +"Last-Translator: \n" +"Language-Team: \n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: \n" + +#. module: partner_middlename +#: model:ir.model,name:partner_middlename.model_res_config_settings +msgid "Config Settings" +msgstr "" + +#. module: partner_middlename +#: model:ir.model,name:partner_middlename.model_res_partner +msgid "Contact" +msgstr "" + +#. module: partner_middlename +#: model:ir.model.fields,field_description:partner_middlename.field_res_partner__middlename +#: model:ir.model.fields,field_description:partner_middlename.field_res_users__middlename +msgid "Middle Name" +msgstr "" From de1222ab10cfc820a7a0cf85bc3e83afbb7ea341 Mon Sep 17 00:00:00 2001 From: OCA-git-bot Date: Sat, 22 Apr 2023 17:03:26 +0000 Subject: [PATCH 05/14] [UPD] README.rst --- partner_middlename/README.rst | 93 +++- .../static/description/index.html | 438 ++++++++++++++++++ 2 files changed, 530 insertions(+), 1 deletion(-) create mode 100644 partner_middlename/static/description/index.html diff --git a/partner_middlename/README.rst b/partner_middlename/README.rst index 0d7429afc0d..8bef9116c2e 100644 --- a/partner_middlename/README.rst +++ b/partner_middlename/README.rst @@ -1 +1,92 @@ -AUTOMATICALLY GENERATED +=================== +Partner Middle Name +=================== + +.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpartner--contact-lightgray.png?logo=github + :target: https://github.com/OCA/partner-contact/tree/16.0/partner_middlename + :alt: OCA/partner-contact +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_middlename + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png + :target: https://runbot.odoo-community.org/runbot/134/16.0 + :alt: Try me on Runbot + +|badge1| |badge2| |badge3| |badge4| |badge5| + +Allows to enter contact names using three separate fields, for First name, Middle Name and Last Name. + +NOTE: currently this feature is incompatible with te Partner Second Last Name (``partner_second_lastname``), +please don't install them together in the same database. + +**Table of contents** + +.. contents:: + :local: + +Configuration +============= + +At Settings / General Settings / Partner Names Order, select option "Firstname Middlename Lastname" or " Lastname, Firstname Middlename". + +Usage +===== + +On the Contact form, create a new contact. + +* Set contact to "Individual". The full name will not be directly editable. +* Set all or any of the First Name, Middle name and Last Name fields. +* The full name should be automatically populated based on the name fields set, and the general setting selected. + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us smashing it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +~~~~~~~ + +* Open Source Integrators + +Contributors +~~~~~~~~~~~~ + +* `Open Source Integrators `_: + * Daniel Reis + * Nikul Chaudhary + +Maintainers +~~~~~~~~~~~ + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +This module is part of the `OCA/partner-contact `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/partner_middlename/static/description/index.html b/partner_middlename/static/description/index.html new file mode 100644 index 00000000000..102f946bb7d --- /dev/null +++ b/partner_middlename/static/description/index.html @@ -0,0 +1,438 @@ + + + + + + +Partner Middle Name + + + +
+

Partner Middle Name

+ + +

Beta License: AGPL-3 OCA/partner-contact Translate me on Weblate Try me on Runbot

+

Allows to enter contact names using three separate fields, for First name, Middle Name and Last Name.

+

NOTE: currently this feature is incompatible with te Partner Second Last Name (partner_second_lastname), +please don’t install them together in the same database.

+

Table of contents

+ +
+

Configuration

+

At Settings / General Settings / Partner Names Order, select option “Firstname Middlename Lastname” or ” Lastname, Firstname Middlename”.

+
+
+

Usage

+

On the Contact form, create a new contact.

+
    +
  • Set contact to “Individual”. The full name will not be directly editable.
    • +
  • Set all or any of the First Name, Middle name and Last Name fields.
    • +
  • The full name should be automatically populated based on the name fields set, and the general setting selected.
    • +
+
+
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us smashing it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • Open Source Integrators
    • +
+
+ +
+

Maintainers

+

This module is maintained by the OCA.

+Odoo Community Association +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

This module is part of the OCA/partner-contact project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+ + From fbb0a7ad675a65e8a7b53c7c396cf6b19d099ac5 Mon Sep 17 00:00:00 2001 From: OCA-git-bot Date: Sun, 3 Sep 2023 15:04:50 +0000 Subject: [PATCH 06/14] [UPD] README.rst --- partner_middlename/README.rst | 15 ++++--- .../static/description/index.html | 44 ++++++++++--------- 2 files changed, 32 insertions(+), 27 deletions(-) diff --git a/partner_middlename/README.rst b/partner_middlename/README.rst index 8bef9116c2e..d14e3768f81 100644 --- a/partner_middlename/README.rst +++ b/partner_middlename/README.rst @@ -2,10 +2,13 @@ Partner Middle Name =================== -.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! +.. + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! !! This file is generated by oca-gen-addon-readme !! !! changes will be overwritten. !! !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! source digest: sha256:f407050c966c319987c0347ba93ce0a90932ed250921016146f1a14b80c9dfca + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png :target: https://odoo-community.org/page/development-status @@ -19,11 +22,11 @@ Partner Middle Name .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png :target: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_middlename :alt: Translate me on Weblate -.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png - :target: https://runbot.odoo-community.org/runbot/134/16.0 - :alt: Try me on Runbot +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/builds?repo=OCA/partner-contact&target_branch=16.0 + :alt: Try me on Runboat -|badge1| |badge2| |badge3| |badge4| |badge5| +|badge1| |badge2| |badge3| |badge4| |badge5| Allows to enter contact names using three separate fields, for First name, Middle Name and Last Name. @@ -54,7 +57,7 @@ Bug Tracker Bugs are tracked on `GitHub Issues `_. In case of trouble, please check there if your issue has already been reported. -If you spotted it first, help us smashing it by providing a detailed and welcomed +If you spotted it first, help us to smash it by providing a detailed and welcomed `feedback `_. Do not contact contributors directly about support or help with technical issues. diff --git a/partner_middlename/static/description/index.html b/partner_middlename/static/description/index.html index 102f946bb7d..987fecdb097 100644 --- a/partner_middlename/static/description/index.html +++ b/partner_middlename/static/description/index.html @@ -1,20 +1,20 @@ - + - + Partner Middle Name -
-

Partner Middle Name

+
+ + +Odoo Community Association + +
+

Partner Middle Name

-

Beta License: AGPL-3 OCA/partner-contact Translate me on Weblate Try me on Runboat

+

Beta License: AGPL-3 OCA/partner-contact Translate me on Weblate Try me on Runboat

Allows to enter contact names using three separate fields, for First name, Middle Name and Last Name.

NOTE: currently this feature is incompatible with te Partner Second Last @@ -390,12 +395,12 @@

Partner Middle Name

-

Configuration

+

Configuration

At Settings / General Settings / Partner Names Order, select option “Firstname Middlename Lastname” or “ Lastname, Firstname Middlename”.

-

Usage

+

Usage

On the Contact form, create a new contact.

  • Set contact to “Individual”. The full name will not be directly @@ -406,7 +411,7 @@

    Usage

-

Bug Tracker

+

Bug Tracker

Bugs are tracked on GitHub Issues. In case of trouble, please check there if your issue has already been reported. If you spotted it first, help us to smash it by providing a detailed and welcomed @@ -414,15 +419,15 @@

Bug Tracker

Do not contact contributors directly about support or help with technical issues.

-

Credits

+

Credits

-

Authors

+

Authors

  • Open Source Integrators
-

Maintainers

+

Maintainers

This module is maintained by the OCA.

Odoo Community Association @@ -449,5 +454,6 @@

Maintainers

+
From 0c22ed4fcdf919453fd551fd8911d9797b0b2e6a Mon Sep 17 00:00:00 2001 From: Maxime Franco Date: Fri, 22 May 2026 09:37:34 +0200 Subject: [PATCH 13/14] [IMP] partner_middlename: pre-commit auto fixes --- partner_middlename/__manifest__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/partner_middlename/__manifest__.py b/partner_middlename/__manifest__.py index 569caad0305..8485232297c 100644 --- a/partner_middlename/__manifest__.py +++ b/partner_middlename/__manifest__.py @@ -7,7 +7,7 @@ "version": "18.0.1.0.0", "license": "AGPL-3", "website": "https://github.com/OCA/partner-contact", - "author": "Open Source Integrators, " "Odoo Community Association (OCA)", + "author": "Open Source Integrators, Odoo Community Association (OCA)", "category": "Partner Management", "depends": ["partner_firstname"], "data": ["views/res_partner.xml", "views/res_user.xml"], From 6df0b7094d6d2715f199637984df438496e88b6b Mon Sep 17 00:00:00 2001 From: Maxime Franco Date: Fri, 22 May 2026 10:30:13 +0200 Subject: [PATCH 14/14] [MIG] partner_middlename: Migration to 19.0 --- partner_middlename/README.rst | 14 +++++++++----- partner_middlename/__manifest__.py | 2 +- partner_middlename/models/res_partner.py | 4 ++-- partner_middlename/readme/CONTRIBUTORS.md | 2 ++ partner_middlename/static/description/index.html | 10 +++++++--- 5 files changed, 21 insertions(+), 11 deletions(-) diff --git a/partner_middlename/README.rst b/partner_middlename/README.rst index 340fbf22c6a..1f5aa60cd43 100644 --- a/partner_middlename/README.rst +++ b/partner_middlename/README.rst @@ -21,13 +21,13 @@ Partner Middle Name :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html :alt: License: AGPL-3 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpartner--contact-lightgray.png?logo=github - :target: https://github.com/OCA/partner-contact/tree/18.0/partner_middlename + :target: https://github.com/OCA/partner-contact/tree/19.0/partner_middlename :alt: OCA/partner-contact .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png - :target: https://translation.odoo-community.org/projects/partner-contact-18-0/partner-contact-18-0-partner_middlename + :target: https://translation.odoo-community.org/projects/partner-contact-19-0/partner-contact-19-0-partner_middlename :alt: Translate me on Weblate .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png - :target: https://runboat.odoo-community.org/builds?repo=OCA/partner-contact&target_branch=18.0 + :target: https://runboat.odoo-community.org/builds?repo=OCA/partner-contact&target_branch=19.0 :alt: Try me on Runboat |badge1| |badge2| |badge3| |badge4| |badge5| @@ -67,7 +67,7 @@ Bug Tracker Bugs are tracked on `GitHub Issues `_. In case of trouble, please check there if your issue has already been reported. If you spotted it first, help us to smash it by providing a detailed and welcomed -`feedback `_. +`feedback `_. Do not contact contributors directly about support or help with technical issues. @@ -91,6 +91,10 @@ Contributors - Bhavesh Heliconia +- `ACSONE SA/NV `__ + + - Maxime Franco + Maintainers ----------- @@ -104,6 +108,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose mission is to support the collaborative development of Odoo features and promote its widespread use. -This module is part of the `OCA/partner-contact `_ project on GitHub. +This module is part of the `OCA/partner-contact `_ project on GitHub. You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/partner_middlename/__manifest__.py b/partner_middlename/__manifest__.py index 8485232297c..ece8705cece 100644 --- a/partner_middlename/__manifest__.py +++ b/partner_middlename/__manifest__.py @@ -4,7 +4,7 @@ { "name": "Partner Middle Name", "summary": "Have split Middle", - "version": "18.0.1.0.0", + "version": "19.0.1.0.0", "license": "AGPL-3", "website": "https://github.com/OCA/partner-contact", "author": "Open Source Integrators, Odoo Community Association (OCA)", diff --git a/partner_middlename/models/res_partner.py b/partner_middlename/models/res_partner.py index 292ec5f4882..d1e3c2dd68b 100644 --- a/partner_middlename/models/res_partner.py +++ b/partner_middlename/models/res_partner.py @@ -110,10 +110,10 @@ def _split_part(self, name_part, name_split): return parts @api.constrains("firstname", "lastname", "middlename") - def _check_name(self): + def _check_firstname_lastname(self): """Ensure at least one name is set.""" try: - return super()._check_name() + return super()._check_firstname_lastname() except exceptions.EmptyNamesError: for partner in self: if not partner.middlename: diff --git a/partner_middlename/readme/CONTRIBUTORS.md b/partner_middlename/readme/CONTRIBUTORS.md index 0754fea5a89..6266a3803d2 100644 --- a/partner_middlename/readme/CONTRIBUTORS.md +++ b/partner_middlename/readme/CONTRIBUTORS.md @@ -3,3 +3,5 @@ - Nikul Chaudhary \<\> - [Heliconia Solutions Pvt. Ltd.](https://www.heliconia.io) - Bhavesh Heliconia +- [ACSONE SA/NV](https://https://www.acsone.eu/) + - Maxime Franco \<\> diff --git a/partner_middlename/static/description/index.html b/partner_middlename/static/description/index.html index 70c6bdfec3b..781b775990b 100644 --- a/partner_middlename/static/description/index.html +++ b/partner_middlename/static/description/index.html @@ -374,7 +374,7 @@

Partner Middle Name

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! !! source digest: sha256:2900aece401268fdb58ee940febf3f98852d89e4e490ab88f213ef767038368d !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! --> -

Beta License: AGPL-3 OCA/partner-contact Translate me on Weblate Try me on Runboat

+

Beta License: AGPL-3 OCA/partner-contact Translate me on Weblate Try me on Runboat

Allows to enter contact names using three separate fields, for First name, Middle Name and Last Name.

NOTE: currently this feature is incompatible with te Partner Second Last @@ -415,7 +415,7 @@

Bug Tracker

Bugs are tracked on GitHub Issues. In case of trouble, please check there if your issue has already been reported. If you spotted it first, help us to smash it by providing a detailed and welcomed -feedback.

+feedback.

Do not contact contributors directly about support or help with technical issues.

@@ -438,6 +438,10 @@

Contributors

  • Bhavesh Heliconia
    • +
  • ACSONE SA/NV +
    • @@ -449,7 +453,7 @@

    Maintainers

    OCA, or the Odoo Community Association, is a nonprofit organization whose mission is to support the collaborative development of Odoo features and promote its widespread use.

    -

    This module is part of the OCA/partner-contact project on GitHub.

    +

    This module is part of the OCA/partner-contact project on GitHub.

    You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.