From 2581c6aa34015f17dae6495c6c76e4d795c882a3 Mon Sep 17 00:00:00 2001 From: Pierre Sauvage Date: Fri, 29 May 2026 17:00:01 +0200 Subject: [PATCH] fix: typo and remove french for english --- .github/workflows/docker-build-test-push-template.yml | 2 +- .github/workflows/docker-rebuild.yml | 2 +- .github/workflows/helm-lint-template.yml | 2 +- README.md | 2 +- airflow/dags/nyc_taxi_pipeline.py | 8 ++++---- airflow/tests/run_integration_tests.sh | 2 +- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/docker-build-test-push-template.yml b/.github/workflows/docker-build-test-push-template.yml index 99fd30b..7b64733 100644 --- a/.github/workflows/docker-build-test-push-template.yml +++ b/.github/workflows/docker-build-test-push-template.yml @@ -34,7 +34,7 @@ on: type: string default: 'okdp-examples' publish_to_registry: - description: Wheter to push to the registry + description: Whether to push to the registry required: false type: string default: "false" diff --git a/.github/workflows/docker-rebuild.yml b/.github/workflows/docker-rebuild.yml index 3c706e1..d231c69 100644 --- a/.github/workflows/docker-rebuild.yml +++ b/.github/workflows/docker-rebuild.yml @@ -22,7 +22,7 @@ on: # At 05:00 AM, only on Tuesday #- cron: "0 5 * * 2" # https://crontab.cronhub.io/ - # At 05:"0 AM, only on Tuesday + # At 05:00 AM, only on Tuesday - cron: "0 5 * * 2" # The release should be created manually (or with user token=pr approval/merge) in order to trigger the event ### https://github.com/orgs/community/discussions/25281 diff --git a/.github/workflows/helm-lint-template.yml b/.github/workflows/helm-lint-template.yml index 947a9e1..0c3aba1 100644 --- a/.github/workflows/helm-lint-template.yml +++ b/.github/workflows/helm-lint-template.yml @@ -20,7 +20,7 @@ on: workflow_call: inputs: skip_chart_test: - description: Wether to deploy and test the chart + description: Whether to deploy and test the chart required: false type: boolean default: false diff --git a/README.md b/README.md index 7dc5f8f..0a01cd6 100644 --- a/README.md +++ b/README.md @@ -301,7 +301,7 @@ Storage access is controlled at the service level, while user-level data access -# Know issues +# Known issues 1. [Polaris - Spark Iceberg REST Catalog refresh token](https://github.com/apache/iceberg/issues/12363) > Long-running jobs may need more metadata calls to Polaris during execution, not just one initial call 2. [Polaris - OAuth 2 grant type "refresh_token" not implemented](https://github.com/apache/iceberg/issues/12196) diff --git a/airflow/dags/nyc_taxi_pipeline.py b/airflow/dags/nyc_taxi_pipeline.py index 21effd9..defcd7d 100644 --- a/airflow/dags/nyc_taxi_pipeline.py +++ b/airflow/dags/nyc_taxi_pipeline.py @@ -1,6 +1,6 @@ """ NYC Taxi Pipeline - Airflow + Spark Operator -Utilise l'API Kubernetes Python pour soumettre un SparkApplication. +Uses the Kubernetes Python API to submit a SparkApplication. """ import os import re @@ -165,12 +165,12 @@ def submit_and_wait_nyc_taxi_etl(run_suffix, timeout_seconds=1200): .get("state", "SUBMITTED") ) if last_state == "COMPLETED": - return f"Spark ETL terminé: {app_name}" + return f"Spark ETL completed: {app_name}" if last_state in {"FAILED", "SUBMISSION_FAILED", "UNKNOWN"}: - raise RuntimeError(f"Spark ETL échoué: {app_name} state={last_state}") + raise RuntimeError(f"Spark ETL failed: {app_name} state={last_state}") time.sleep(10) - raise TimeoutError(f"Spark ETL timeout après {timeout_seconds}s: {app_name} state={last_state}") + raise TimeoutError(f"Spark ETL timeout after {timeout_seconds}s: {app_name} state={last_state}") with DAG( diff --git a/airflow/tests/run_integration_tests.sh b/airflow/tests/run_integration_tests.sh index bf718c4..735a136 100755 --- a/airflow/tests/run_integration_tests.sh +++ b/airflow/tests/run_integration_tests.sh @@ -20,7 +20,7 @@ SCHEDULER_POD="$(find_scheduler_pod)" WEBSERVER_POD="$(find_webserver_pod)" if [[ -z "${SCHEDULER_POD}" || -z "${WEBSERVER_POD}" ]]; then - echo "Pods Airflow introuvables dans namespace ${NAMESPACE}" + echo "Airflow pods not found in namespace ${NAMESPACE}" exit 1 fi