feat: deadline banners (#734), analytics (#718), tx metrics (#720), dual-auth ADR (#713)#859
Merged
Ogstevyn merged 1 commit intoJun 2, 2026
Conversation
|
@Salmatcre8 is attempting to deploy a commit to the Stephen's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Salmatcre8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four monitoring / UX / docs items, all in this repo:
Closes #734
Closes #718
Closes #720
Closes #713
#734 — Landlord deadline reminder banner
components/dashboard/DeadlineBanners.tsx— on dashboard load, shows a dismissible amber banner for each active escrow whose deadline is within 72 hours. Dismissals persist in localStorage.components/dashboard/deadline-utils.ts— JSX-free selection/format helpers (so the logic is unit-testable undernode --test).app/dashboard/page.tsx— renders<DeadlineBanners escrows={escrows} />above the portfolio summary.#718 — Privacy-first page analytics
components/ui/analytics.tsx— loads Plausible (cookieless, GDPR-compliant) vianext/script, only whenNEXT_PUBLIC_PLAUSIBLE_DOMAINis set and Do Not Track / GPC is off. ExposestrackEvent()for the key events (escrow-creation start, wallet connect, contribution complete); Plausible auto-records page views.app/layout.tsx— mounts<Analytics />.#720 — Transaction failure-rate metrics
lib/metrics.ts— in-process counters withrecordTransaction()+getMetrics()returning{ total_transactions, failed_transactions, failure_rate_percent }(plus a per-type breakdown).app/api/metrics/route.ts—GET /api/metrics.lib/stellar/actions/contribute.ts— wraps submit/confirm to record success/failure.#713 — ADR for the dual authentication system
docs/adr/002-dual-auth.md— documents why email-JWT and Stellar-wallet auth must coexist (account identity vs. on-chain financial identity, custody boundary, onboarding), plus a migration path if either is removed. Follows the format of the existing001-file-storage.md.Verified terminal output
tsc --noEmit: no new errors in changed files (repo has 21 pre-existing baseline errors unrelated to this PR).Acceptance criteria
GET /api/metricsreturns accurate transaction failure statistics