chore(deps-dev): bump vitest from 1.6.1 to 4.1.8#80
Merged
Conversation
Updates vitest in drs-sdk, drs-mcp-server, and drs-mcp-client to 4.1.8. All tests (147), typecheck, and build pass with the upgrade. The upgrade is non-breaking for this project as we use standard vitest APIs and Node.js >=20 requirement is compatible with vitest 4.x (requires ^20.0.0 || ^22.0.0 || >=24.0.0). Closes dependabot PR for vitest-4.1.0
There was a problem hiding this comment.
This lockfile update correctly reflects the vitest upgrade from v1.6.1 to v4.1.8 across three packages (drs-sdk, drs-mcp-server, drs-mcp-client). All dependency changes are consistent with the major version upgrade, including the addition of new vitest v4.x dependencies and removal of obsolete dependencies. The changes align with the PR description stating all tests pass with the upgrade.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
The test was flipping the last base64url character of the Ed25519 signature between A and B. That character only carries 2 real data bits from byte 63 — the lower 4 bits are padding zeros. When the original happened to end in 'A' (byte63 & 0x03 == 0), flipping to 'B' only changed padding bits, producing the same decoded signature. The verifier correctly returned valid=true, but the test expected valid=false. ~19% of test runs hit this case, making the E2E gate flaky — it passed locally but failed ~19% of CI runs. Fix: tamper sig[0] instead, which encodes 6 full data bits from byte 0. Any A↔B flip there guarantees actual data mutation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates vitest in drs-sdk, drs-mcp-server, and drs-mcp-client to 4.1.8. All tests (147), typecheck, and build pass with the upgrade.
The upgrade is non-breaking for this project as we use standard vitest APIs and Node.js >=20 requirement is compatible with vitest 4.x (requires ^20.0.0 || ^22.0.0 || >=24.0.0).
Closes dependabot PR for vitest-4.1.0