Skip to content

chore(deps-dev): bump vitest from 1.6.1 to 4.1.8#80

Merged
OkeyAmy merged 2 commits into
mainfrom
fix/security-ci-hardening-clean
Jun 8, 2026
Merged

chore(deps-dev): bump vitest from 1.6.1 to 4.1.8#80
OkeyAmy merged 2 commits into
mainfrom
fix/security-ci-hardening-clean

Conversation

@OkeyAmy

@OkeyAmy OkeyAmy commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Updates vitest in drs-sdk, drs-mcp-server, and drs-mcp-client to 4.1.8. All tests (147), typecheck, and build pass with the upgrade.

The upgrade is non-breaking for this project as we use standard vitest APIs and Node.js >=20 requirement is compatible with vitest 4.x (requires ^20.0.0 || ^22.0.0 || >=24.0.0).

Closes dependabot PR for vitest-4.1.0

Updates vitest in drs-sdk, drs-mcp-server, and drs-mcp-client to 4.1.8.
All tests (147), typecheck, and build pass with the upgrade.

The upgrade is non-breaking for this project as we use standard vitest APIs
and Node.js >=20 requirement is compatible with vitest 4.x (requires ^20.0.0 || ^22.0.0 || >=24.0.0).

Closes dependabot PR for vitest-4.1.0

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lockfile update correctly reflects the vitest upgrade from v1.6.1 to v4.1.8 across three packages (drs-sdk, drs-mcp-server, drs-mcp-client). All dependency changes are consistent with the major version upgrade, including the addition of new vitest v4.x dependencies and removal of obsolete dependencies. The changes align with the PR description stating all tests pass with the upgrade.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

The test was flipping the last base64url character of the Ed25519
signature between A and B. That character only carries 2 real data
bits from byte 63 — the lower 4 bits are padding zeros. When the
original happened to end in 'A' (byte63 & 0x03 == 0), flipping to
'B' only changed padding bits, producing the same decoded signature.
The verifier correctly returned valid=true, but the test expected
valid=false.

~19% of test runs hit this case, making the E2E gate flaky — it
passed locally but failed ~19% of CI runs.

Fix: tamper sig[0] instead, which encodes 6 full data bits from
byte 0. Any A↔B flip there guarantees actual data mutation.
@OkeyAmy OkeyAmy merged commit c84eab5 into main Jun 8, 2026
14 checks passed
@OkeyAmy OkeyAmy deleted the fix/security-ci-hardening-clean branch June 8, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant