[Feature]: Add RF SerialConsole support

[cjh1]

Describe the feature

We currently have a RFD open related to SMD adding support for this. There is also a proposed SMD PR that adds the support. Magellan should be able to discover this information as well.

Why do you want this feature?

This is needed for the remote-console service, so it knows what protocol to use to connect to a given console.

Alternatives you've considered

I considered doing...

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[davidallendj]

Is this just including the necessary data in the output to SMD? That should be pretty trivial to change if so.

[cjh1]

Is this just including the necessary data in the output to SMD? That should be pretty trivial to change if so.

Yes, it should just be a case of forwarding on the output to SMD, in fact it might not require any changes, I am not familiar enough with magellan to know. Does it just forward the RF data or does it explicitly create the components?

[davidallendj]

It explicitly creates the components in the format for SMD. We'll just need to pull the RF data and add it to the data structure that's used in the request made in send.

[cjh1]

@davidallendj The changes for SMD have been merged, can you outline what changes would be needed here and I can take a stab at it?

[davidallendj]

Yeah, the only thing that needs to happen is return the appropriate data using gofish from the BMC and include it in the output for the request made to SMD. Fetching the data from the BMC should be done in pkg/crawler/main.go I think. IIRC I don't think you would have to change anything if the data is included under the Systems property.

[cjh1]

Yeah, the only thing that needs to happen is return the appropriate data using gofish from the BMC and include it in the output for the request made to SMD. Fetching the data from the BMC should be done in pkg/crawler/main.go I think. IIRC I don't think you would have to change anything if the data is included under the Systems property.

Great thanks, I will test this out when I get a chance, would be nice if no changes were needed.

[davidallendj]

If needed, I can take a look at it since my time is a bit freed up for now and have you review the PR if that would help.

[cjh1]

If needed, I can take a look at it since my time is a bit freed up for now and have you review the PR if that would help.

Thanks, let me update my tests to use magellan instead of smd for discovery and see if it just works. Could you point me at an appropriate magellan invocation that will do the discovery and populate smd?

[davidallendj]

If needed, I can take a look at it since my time is a bit freed up for now and have you review the PR if that would help.

Thanks, let me update my tests to use magellan instead of smd for discovery and see if it just works. Could you point me at an appropriate magellan invocation that will do the discovery and populate smd?

Typically, you would do a scan, collect, then send to load your data to SMD. Alternatively, you can crawl a BMC directly and send the data if you already know the IP address of all of your BMCs on your network. I believe there are examples on the main README on how to do all of this or you can refer to the man pages.

[davidallendj]

Completed in #126.