Skip to content

Commit c7a2490

Browse files
Tajudeenclaude
andcommitted
phase9(docs): record Compile & Hygiene CI unblock + note PR #62 is merged
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 94f1198 commit c7a2490

1 file changed

Lines changed: 34 additions & 2 deletions

File tree

‎docs/MODERNIZATION-BASELINE.md‎

Lines changed: 34 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -654,8 +654,40 @@ IPv4-mapped to hex; `git checkout <commit> -- <file>` STAGES the file (use `git
654654
to fully revert); routingPolicy lives in GlobalSettings (encrypted storage), NOT IConfigurationService,
655655
so electron-main can only read the migrated `cortexide.global.localFirstAI` config without IPC threading.
656656

657-
### Phases 4, 6-7, 9-10 — NOT STARTED
658-
Real RAG; agentic UX; MCP/plugins; CI/release; positioning. Multi-session work.
657+
### Phase 9 — CI/release: Compile & Hygiene unblocked (2026-06-11)
658+
659+
NOTE: PR #62 was MERGED (commit `4ef5a9448a6` on `origin/main`) with CI still RED. So Phases 0-3/5/8
660+
ARE in main now; this branch (`modernize-agentic-editor-foundation`) is exactly `origin/main` + the
661+
continuation-prompt doc + this commit. New work here will need a FRESH PR (the old one is closed/merged).
662+
663+
`94f11981378` -- fixed the TWO pre-existing "Compile & Hygiene" CI blockers (both were red on main too,
664+
NOT introduced by the branch; confirmed against the actual failed run 27359817568 / job 80843876227):
665+
- **core-ci/tsgo `TS2307`**: `browser/helpers/findDiffs.ts:7` imports the GENERATED
666+
`../react/out/diff/index.js`. CI runs the typecheck BEFORE `npm run buildreact`, so the artifact is
667+
absent and the module is unresolvable. KEY mechanism discovered: the 6 sibling react/out modules
668+
(onboarding/settings/tooltip/editor-widgets/quick-edit-tsx/sidebar-tsx) already ship COMMITTED
669+
`index.d.ts` files -- `out/` is gitignored but those `.d.ts` are force-added -- which is why ONLY
670+
findDiffs failed (diff/ had no `.d.ts`). FIX: hand-write + force-add `out/diff/index.d.ts`
671+
(`export interface Change {...}; export declare function diffLines(...)`), matching the sibling
672+
pattern, so the import is type-resolvable WITHOUT building react. `tsup.config.js` has `dts` disabled
673+
+ `clean:false`, so a local `buildreact` emits only `.js` and will NOT clobber the committed `.d.ts`.
674+
- **hygiene**: `scripts/appimage/create_appimage.sh` fails on (a) intentional translated (non-ASCII)
675+
desktop-menu names (JP/KR/RU/ZH "New Empty Window") at lines 124-131 and (b) its own space indentation
676+
at lines 10-69. FIX: exclude the file from `unicodeFilter` + `indentationFilter` in `build/filters.ts`
677+
(the same treatment `build/**/*.sh` and the cortexide React tree already get) rather than stripping
678+
the translations.
679+
Verification: reproduced both failures locally first (`node build/hygiene.ts <file>` -> 14 errors;
680+
tsgo TS2307 by hiding `out/diff/index.js`). After the fix: tsgo with `react/out/diff/index.js` HIDDEN
681+
(the exact CI condition -- react unbuilt) -> **0 errors, no findDiffs error**; normal-state tsgo -> 0;
682+
`node build/hygiene.ts scripts/appimage/create_appimage.sh` -> exit 0; hygiene on the new `.d.ts` ->
683+
exit 0; cortexide node subset still **551 passing, 0 failing**. The full `core-ci`+`hygiene` gulp job
684+
is not run locally (heavy: downloads marketplace extensions), but the captured CI log listed EXACTLY
685+
these two files' errors and no others, and tsgo/hygiene are the same tools the job uses. NOT pushed (no
686+
new PR; user's call). Remaining Phase 9: CDP smoke in CI; mac/win/linux packaging smoke; Windows
687+
branding (`win32NameVersion`/`serverApplicationName`); regression tests for known fixed bugs.
688+
689+
### Phases 4, 6-7, 10 — NOT STARTED
690+
Real RAG; agentic UX; MCP/plugins; positioning. Multi-session work.
659691

660692
### Audit reliability note
661693
Of the audit's headline criticals, **two were materially wrong** (secret redaction IS done +

0 commit comments

Comments
 (0)