chore: remove orphaned repository-selection dir and unused pagination/interactive-chip UI#1234
chore: remove orphaned repository-selection dir and unused pagination/interactive-chip UI#1234hieptl wants to merge 2 commits into
Conversation
…/interactive-chip UI
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| Status | Test | Duration |
|---|
Posted by the Mock-LLM E2E workflow · results are deterministic (scripted LLM responses)
✅ Mock-LLM E2E Tests42/42 passed Commit:
Posted by the Mock-LLM E2E workflow · results are deterministic (scripted LLM responses) |
✅ Mock-LLM E2E Tests42/42 passed Commit:
Posted by the Mock-LLM E2E workflow · results are deterministic (scripted LLM responses) |
📸 Snapshot Test Report✅ All snapshots match the main branch baselines.
✅ Unchanged snapshots (73)
Generated by the Snapshot Tests workflow. This comment was created by an AI agent (OpenHands) on behalf of the repo maintainers. |
🔶 Mock-LLM Docker E2E Test Results37/42 passed · 5 skipped Commit:
Posted by the Mock-LLM E2E workflow · results are deterministic (scripted LLM responses) |
Why
Description:
Ten UI files (~412 LOC) with zero importers:
src/components/features/home/repository-selection/— the entire 8-file directory. Nothing outside the directory references it at all (git grep "repository-selection"→ zero external hits). Its ownindex.tsbarrel re-exports only 3 of its 8 sibling files — internally vestigial too. The live repo/branch/provider selection UI is implemented by the sibling modulesgit-branch-dropdown/,git-provider-dropdown/,git-repo-dropdown/, andrepo-selection-form.tsx.src/ui/pagination.tsx(129 LOC) andsrc/ui/interactive-chip.tsx(33 LOC). Their last importers were removed in "[Phase 1] Strip SaaS-specific code from the OSS repo" ([Phase 1] Strip SaaS-specific code from the OSS repo #17); they have been unreferenced ever since (later commits only swept them in token renames).Verified not part of the published library API: unreachable from
src/index.ts→src/lib/index.tsand from all sevenexports-map barrels.Scope (delete 10 files, ~412 LOC):
src/components/features/home/repository-selection/index.tssrc/components/features/home/repository-selection/branch-dropdown.tsxsrc/components/features/home/repository-selection/branch-error-state.tsxsrc/components/features/home/repository-selection/branch-loading-state.tsxsrc/components/features/home/repository-selection/git-provider-dropdown.tsxsrc/components/features/home/repository-selection/repository-dropdown.tsxsrc/components/features/home/repository-selection/repository-error-state.tsxsrc/components/features/home/repository-selection/repository-loading-state.tsxsrc/ui/pagination.tsxsrc/ui/interactive-chip.tsxAcceptance Criteria:
npm run lintandnpm testpass (no new tests written).npm run build:libpasses; freshly-builtdist/components/features/home/contains norepository-selection/anddist/ui/contains no pagination/chip declarations.git grep "repository-selection"returns nothing.Out of scope / Notes:
BranchDropdowningit-branch-dropdown/,GitProviderDropdowningit-provider-dropdown/). Those are untouched — surviving grep hits for those names are expected and correct.pagination.tsximported#/assets/chevron-left/chevron-right; both assets stay (still used byimage-carousel.tsx).tsconfig.lib.jsonincludessrc/components/**wholesale, so these files previously emitted.d.tsintodist/. Those declarations were emitted-but-unreachable: the packageexportsmap exposes only seven named subpaths, and thepreserveModulesJS output never contained these modules (unreachable fromsrc/lib/index.ts). Removing them is not a breaking change to any supported consumer entry.Summary
Removes ten orphaned UI files (~412 LOC): the entire
repository-selection/directory (fully superseded by the livegit-branch-dropdown/git-provider-dropdown/git-repo-dropdown/repo-selection-formmodules) and thepagination/interactive-chipcomponents whose importers were stripped with the SaaS-only code in #17.Changes
src/components/features/home/repository-selection/— all 8 files (index barrel + branch/repository dropdown, error, loading states + a vestigial git-provider-dropdown)src/ui/pagination.tsx(129 LOC),src/ui/interactive-chip.tsx(33 LOC)Verification
npm run lint✅ ·npm test✅ — 403 test files passed, 3016 tests passed, 0 failuresnpm run build:lib✅ — vite lib build +tsc -p tsconfig.lib.jsonclean; spot-checked freshdist/:dist/components/features/home/no longer containsrepository-selection/,dist/ui/contains no pagination/chip output, and all live sibling modules still emitgit grep "repository-selection"→ zero hitsRisk
Low. These files emitted
.d.tsintodist/(becausetsconfig.lib.jsonincludessrc/components/**wholesale), but those declarations were unreachable through the packageexportsmap (seven named subpaths only) and absent from the JS bundle (preserveModulesfromsrc/index.tsnever reached them) — so no supported consumer entry changes. Reviewer note:BranchDropdown/GitProviderDropdownstill grep in the codebase — those are the live components in the siblinggit-branch-dropdown//git-provider-dropdown/modules, unrelated namesakes of the deleted files.Rollback
Revert this single commit; independent of all other units.
Issue Number
Resolves #1233
Type
🐳 Docker images for this PR
• GHCR package: https://github.com/OpenHands/agent-canvas/pkgs/container/agent-canvas
ghcr.io/openhands/agent-canvasghcr.io/openhands/agent-server:1.26.0-pythonopenhands-automation==1.0.0a6844e5d6416115e2d4927a859c9c83b68b2999106Pull (multi-arch manifest)
# Multi-arch manifest — Docker automatically pulls the correct architecture docker pull ghcr.io/openhands/agent-canvas:sha-844e5d6Run
All tags pushed for this build
About Multi-Architecture Support
sha-844e5d6) is a multi-arch manifest supporting both amd64 and arm64sha-844e5d6-amd64) are also available if needed