fix: add tzdata dependency for Windows timezone support#177
Merged
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
jamiechicago312
force-pushed
the
add-tzdata-dependency
branch
from
0e057da to
8f73a01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tzdata>=2024.1 to dependencies. croniter and Python's zoneinfo require timezone data; on Windows this must be provided by the tzdata package. Without it, the scheduler crashes with ModuleNotFoundError: tzdata / ZoneInfoNotFoundError.
Per reviewer feedback on agent-canvas#1257, this dependency belongs here rather than being patched downstream.
PR #1257 on agent-canvas
That PR is already closed with zero diff — all the workaround patches were properly stripped out. No cleanup needed there.
Related context
#172 (already merged) — Fixed the Windows .venv/bin/python vs .venv/Scripts/python.exe issue
#170 — Open issue about Windows venv entrypoint (partially covered by #172)
The shared conversation you linked was the earlier session that stripped PR #1257 down to just the tzdata fix, which then got stripped further to zero based on @malhotra5's review