From b1dfbd1c6a26d7442b030578614400e701b8bff0 Mon Sep 17 00:00:00 2001 From: michaldev0 <125133223+michaldev0@users.noreply.github.com> Date: Tue, 26 May 2026 13:26:49 +0200 Subject: [PATCH] OLMIS-8191: Make remarks editable on approval Remarks column is now editable and adjusts to the number of characters. --- CHANGELOG.md | 2 ++ src/requisition-product-grid/product-grid-cell.directive.js | 4 +++- .../product-grid-cell.directive.spec.js | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5957eed3..fde0ffb0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,7 @@ Upcoming Version (WIP) ================== +Bug fixes: +* [OLMIS-8191](https://openlmis.atlassian.net/browse/OLMIS-8191): Remarks column editable and size adjustable dynamically. 7.0.16 / 2026-02-05 ================= diff --git a/src/requisition-product-grid/product-grid-cell.directive.js b/src/requisition-product-grid/product-grid-cell.directive.js index 2bba35f9..d555d64c 100644 --- a/src/requisition-product-grid/product-grid-cell.directive.js +++ b/src/requisition-product-grid/product-grid-cell.directive.js @@ -190,9 +190,11 @@ function isApprovalColumn(requisition, column) { var approvalColumns = requisition.template.patientsTabEnabled ? - [TEMPLATE_COLUMNS.TOTAL_RECEIVED_QUANTITY, TEMPLATE_COLUMNS.REMARKS] : + [TEMPLATE_COLUMNS.TOTAL_RECEIVED_QUANTITY] : [TEMPLATE_COLUMNS.APPROVED_QUANTITY]; + approvalColumns.push(TEMPLATE_COLUMNS.REMARKS); + return approvalColumns.indexOf(column.name) !== -1; } } diff --git a/src/requisition-product-grid/product-grid-cell.directive.spec.js b/src/requisition-product-grid/product-grid-cell.directive.spec.js index 12eb36ef..00d72a2b 100644 --- a/src/requisition-product-grid/product-grid-cell.directive.spec.js +++ b/src/requisition-product-grid/product-grid-cell.directive.spec.js @@ -228,7 +228,7 @@ describe('ProductGridCell', function() { cell = angular.element(this.getCompiledElement().children()[0]); - expect(cell.text()).toEqual('readOnlyFieldValue'); + expect(cell.text()).not.toEqual('readOnlyFieldValue'); }); it('should produce editable cell if user can edit and column is editable', function() {