Adding release info to fixes/improvements when closed #428
Replies: 5 comments 8 replies
|
I fully understand you comment, and yes we must do it better than today and we also want to do it. Until then the best reference is our changelog, where we try to describe everything we have added since last release.. |
|
A related question: There is a closed issue that said column contents except for cache Name were now centered? I see some columns look centered, but others, like "Placed By", "Hidden Date" or "Container", (if text display is chosen for Container), are not centered. Maybe this is one that was finished and closed but did not make it into beta17? 
|
|
Good catch. I will create an issue and work on this. |
|
For reference: #431 |
|
Great. Thanks. Maybe I am following this too closely and just need to be more relaxed looking for the changes. But it is just too exciting having OSAK come to maturity and I am on the edge of my chair with nose to the computer screen trying each new change out! |
|
No, please continue :) I love this software challenges as well. Whenever I have some free time, I come here :) |
|
@CheminerWill the bug is fixed and will be included in the next release. Tomorrow morning we will launch the 1.14.00. |
|
Yes, I understand. For reference I usually create an issue on GitHub side (improvement, feature, bug) to track each topic progress. But sometimes it is chaotic and since I watch/work several issues in parallel the message sometimes does not get sent. By default, and since we are using beta versions, each fix/improvement will be part of the exact next version and future ones. @AgreeDK I propose a small GitHub Actions workflow to handle this automatically, with zero overhead for maintainers. Since all PRs target beta, the standard GitHub "closes #X" auto-close never fires. But we can add a workflow that:
No milestones, no manual steps, no extra process, it just runs silently on every merge. Since any fix merged to beta is by definition part of the next beta cut, the comment is always accurate. Users following issues get a notification the moment the PR lands. I can open a PR with the workflow file if you're open to it. |
|
FYI. I tool the liberty to test the workflow here: #434 |
|
@Fabio-A-Sa |
|
I think it is working, but since the new workflow is only in the beta branch, it will only start running when we merge everything into main (tomorrow, with the 1.14.0 release). We can make further adjustments after that, but at least people who open issues will now have visibility on when their fix is done and when it will be available on their machine :) |
I think with all the updates and features in OSAK 1.14 now and with some publicity on the GSAK discussion board, and Facebook, hopefully a bunch of new people will try it out! But of course the real rush of new users will come with implementation of features the API will allow. Come on Groundspeak.... you are torturing impatient people like me with the long time to approve. Hopefully it will go smoothly and happen soon! |
|
This is now live — see .github/workflows/notify-linked-issues.yml. Every PR merged to beta with a Closes #X reference will auto-comment and close the linked issue. Thanks for the great suggestion, @CheminerWill and @Fabio-A-Sa! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This is just a small thing but for those of us that follow every issue etc. on GitHub it would be nice. I know once in a while an issue or feature does indicate which release it will be in, but sometimes I look to try out a bug fix or feature improvement in a latest beta release and I can't find that it has been implemented. I just assume it was finalized and closed after the latest beta was ready and wait for the next release or two to look for it. But there have been a time or two when it seems like the issue was completed long enough ago that it would be in the latest beta but I still cannot find it. If it is not too uncertain to know at the time of closing, it would be great if whenever a fix of improvement is completed, as part of the completion description it was indicated which future release it was to be included with.
By the way, the changes and fixes included from beta 11 which I had been running up until this morning, then to beta 14, and now beta 17 are just fantastic! So much work being done so quickly by everyone! OpenSAK is now maturing to the point where not having the API yet is frustrating. Hope they get it approved soon.
All reactions