From 2482d060f1262e0c52c0488f9e500ef9fe6626c2 Mon Sep 17 00:00:00 2001 From: Yann Le Goff Date: Tue, 30 Sep 2025 11:01:47 +0200 Subject: [PATCH 1/2] remove not necessary fork --- .../PyramidPluginEditOnRunning.class.st | 21 ++++++------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidPluginEditOnRunning.class.st b/src/Pyramid-Bloc/PyramidPluginEditOnRunning.class.st index 6c9f5d17..2bdd962b 100644 --- a/src/Pyramid-Bloc/PyramidPluginEditOnRunning.class.st +++ b/src/Pyramid-Bloc/PyramidPluginEditOnRunning.class.st @@ -10,7 +10,6 @@ Class { 'editOnRunning', 'spaceIds', 'shortcut', - 'shortcutFork', 'keyCombination', 'breakpoint' ], @@ -51,20 +50,12 @@ PyramidPluginEditOnRunning class >> cleanUp: anObject [ PyramidPluginEditOnRunning class >> doShortcutAction: anEvent [ | space editor whenClosedDo | - self flag: - 'labordep: this is a temporary processing because this fork is due to a Bloc opened issue'. - (shortcutFork notNil and: [ shortcutFork isTerminated not ]) ifTrue: [ - ^ self ]. - - shortcutFork := [ - self editOnRunning ifTrue: [ - space := anEvent source space. - (self canEditSpace: space) ifTrue: [ - editor := space editWithPyramid. - whenClosedDo := editor window whenClosedDo. - editor window whenClosedDo: [ whenClosedDo value ] ] ] ] - forkAt: Processor userBackgroundPriority - named: 'Pyramid edit-on-running plugin shortcut' + self editOnRunning ifFalse: [ ^ self ]. + space := anEvent source space. + (self canEditSpace: space) ifTrue: [ + editor := space editWithPyramid. + whenClosedDo := editor window whenClosedDo. + editor window whenClosedDo: [ whenClosedDo value ] ] ] { #category : #'as yet unclassified' } From 9570de88c7b894e83006e6ad87dafc4a2310876a Mon Sep 17 00:00:00 2001 From: Yann Le Goff Date: Tue, 30 Sep 2025 11:04:04 +0200 Subject: [PATCH 2/2] Clean up not used variables --- src/Pyramid-Bloc/PyramidPluginEditOnRunning.class.st | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidPluginEditOnRunning.class.st b/src/Pyramid-Bloc/PyramidPluginEditOnRunning.class.st index 2bdd962b..8c2589c3 100644 --- a/src/Pyramid-Bloc/PyramidPluginEditOnRunning.class.st +++ b/src/Pyramid-Bloc/PyramidPluginEditOnRunning.class.st @@ -3,12 +3,8 @@ Class { #superclass : #Object, #traits : 'TPyramidPlugin', #classTraits : 'TPyramidPlugin classTrait', - #instVars : [ - 'editOnRunning' - ], #classInstVars : [ 'editOnRunning', - 'spaceIds', 'shortcut', 'keyCombination', 'breakpoint' @@ -52,10 +48,10 @@ PyramidPluginEditOnRunning class >> doShortcutAction: anEvent [ | space editor whenClosedDo | self editOnRunning ifFalse: [ ^ self ]. space := anEvent source space. - (self canEditSpace: space) ifTrue: [ - editor := space editWithPyramid. - whenClosedDo := editor window whenClosedDo. - editor window whenClosedDo: [ whenClosedDo value ] ] + (self canEditSpace: space) ifFalse: [ ^ self ]. + editor := space editWithPyramid. + whenClosedDo := editor window whenClosedDo. + editor window whenClosedDo: [ whenClosedDo value ] ] { #category : #'as yet unclassified' }