ExtractBlueprintDirectReferences doesn't support WeakResourceLink

[hmmvot]

Modifications can't use content which referenced by WeakResourceLink (BlueprintPortrait for example).

[BurlyWurly]

Any idea when we can expect to see this fixed?

[factubsio]

@BurlyWurly

Try replacing the Run method in Assets\Editor\Build\Tasks\ExtractBlueprintDirectReferences.cs with this:

  public ReturnCode Run()
        {
            string directReferencesAssetPath = Path.Combine(
                m_ModificationParameters.GeneratedPath, BuilderConsts.BlueprintDirectReferences + ".asset");
            
            var result = ScriptableObject.CreateInstance<BlueprintReferencedAssets>();
            AssetDatabase.CreateAsset(result, directReferencesAssetPath);

            string bundleName = Path.Combine(
                BuilderConsts.OutputBundles,
                m_ModificationParameters.TargetFolderName + "_" +
                Kingmaker.Modding.OwlcatModification.BlueprintDirectReferencesBundleName);

            string[] blueprints = Directory.GetFiles(m_ModificationParameters.BlueprintsPath);
            foreach (string blueprintPath in blueprints)
            {
                if (!blueprintPath.EndsWith(".jbp") && !blueprintPath.EndsWith(".patch"))
                {
                    continue;
                }

                JObject root;
                using (var fs = File.Open(blueprintPath, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
                using (var sr = new StreamReader(fs))
                {
                    root = JObject.Parse(sr.ReadToEnd());
                }

                var allObjs = root.DescendantsAndSelf().OfType<JObject>();

                foreach (var obj in allObjs)
                {
                    var gp = obj["guid"]?.Value<string>();
                    var fp = obj["fileid"]?.Value<long>();

                    if (gp != null && fp != null)
                    {
                        var asset = LoadAsset(gp, fp);
                        if (asset)
                        {
                            AssetDatabase.TryGetGUIDAndLocalFileIdentifier(asset, out string assetId, out long fileId);
                            if (result.Get(assetId, fileId) == null)
                            {
                                result.Add(asset, assetId, fileId);
                                EditorUtility.SetDirty(result);
                                AddToBundle(asset, bundleName);
                            }
                        }

                        continue;
                    }

                    // check if this is a sharedstring asset
                    var ag = obj["assetguid"]?.Value<string>();
                    var sk = obj["stringkey"];
                    if (ag != null && sk != null)
                    {
                        var asset = AssetDatabase.LoadAssetAtPath<SharedStringAsset>(AssetDatabase.GUIDToAssetPath(ag));
                        if (asset)
                        {
                            AssetDatabase.TryGetGUIDAndLocalFileIdentifier(asset, out string assetId, out long fileId);
                            if (result.Get(assetId, fileId) == null)
                            {
                                result.Add(asset, assetId, fileId);
                                EditorUtility.SetDirty(result);
                                AddToBundle(asset, bundleName);
                            }
                        }
                        continue;
                    }

                    var assetLink = obj["AssetId"]?.Value<string>();
                    Debug.Log("looking for assetlink");
                    if (assetLink != null) {
                        var asset = AssetDatabase.LoadAssetAtPath<UnityEngine.Object>(AssetDatabase.GUIDToAssetPath(assetLink));
                        if (asset)
                        {
                            AssetDatabase.TryGetGUIDAndLocalFileIdentifier(asset, out string assetId, out long fileId);
                            if (result.Get(assetId, fileId) == null)
                            {
                                result.Add(asset, assetId, fileId);
                                EditorUtility.SetDirty(result);
                                AddToBundle(asset, bundleName);
                            }
                        }
                        continue;
                    }
                }
            }

            AssetDatabase.SaveAssets();
            
            AddToBundle(result, bundleName);

            return ReturnCode.Success;
        }

[hmmvot]

@factubsio pull requests are welcome)
But SharedStringAsset is wrong type for referenced asset. It should be UnityEngine.Object.

[factubsio]

@hmmvot sorry, good catch! I did it once then lost it then did it again super quick without testing! I am terrible 😆!

I'll do a pr with comments and whatnot later, I broke my local setup and managed to delete my .git so I need to clone fresh.