* Multi-Site: an agent on the UniFi gateway gets the gateway update instructions (#1107) * Agent list: recognize a gateway agent on the main site The upgrade one-liner a site's agent row offers was picked off a per-site verdict that is false for the main site twice over: the call site guarded on !site.IsDefault, and AgentOnGatewayDetector.IsAgentOnGatewayAsync answers false for the default slug by contract. A main-site agent running on the gateway was therefore handed the bare-metal, Docker and Proxmox LXC commands, none of which apply to it. Ask the per-address question instead - MatchGatewayAddressAsync, which is deliberately not default-site gated - and key the answer by agent rather than by site, since a site has one gateway and only one of its agents may be on it. The site-level verdict keeps its existing contract, so the speed-test surfaces that rely on it are untouched. An agent with no open tunnel falls back to its last known LAN IP: an outdated agent is exactly the one whose upgrade command this drives, and it may well be the one that is down. * Agent list: make gateway detection survive a console that is not up The per-agent question was asked with MatchGatewayAddressAsync, which resolves the gateway addresses live and has no memory. Those addresses come from the site's UniFi Console, and on an agent site the console reconnects through that agent's own tunnel - so opening the panel after a restart or an agent update asks before the console can answer, the comparison set is empty, and every agent resolves to a silent no. A gateway agent was then handed the bare-metal, Docker and Proxmox commands. The site-level verdict never showed this because it seeds from a persisted answer and keeps the last one when the console is down, which is why WAN Speed Test stayed right on the same site at the same moment. Give the per-agent question the same durability: a persisted verdict per agent, seeded before the refresh starts, with a degraded refresh keeping the last answer instead of inventing a no. Deliberately does NOT wait on the console - Settings is where a broken or unconfigured console gets fixed, so it has to stay responsive there. The existing entry points are untouched, so the speed-test consumers keep the site-level contract exactly as it was. The default site now reaches the persistence path for the first time, so it writes to the main database rather than asking for a per-site one it does not have. * TODOs for the remaining agent-on-gateway detection cleanup (#1106) Marks the call sites still using the live, memoryless MatchGatewayAddressAsync where the durable per-agent overload belongs, the one that needs the matched address rather than a yes/no and so does not drop in, the narrow gateway address set, and the uncovered first resolve. Comments and TODO.md only - no behavior change. * TODO: keep the address-set example generic * Record the known gaps the regression review turned up (#1106) The Any() reducer in SiteHasGatewayAgent: its one caller mirrors what a blank override resolves to, and SiteSpeedTestTargetResolver resolves against one agent, so a site with a gateway agent and a real-box agent makes the two disagree. Secondary sites only - the main site does not render the field. The per-agent key also puts every already-enrolled gateway agent through the cold-start window once, since nothing reads the site-level row back under the new key. Noted alongside why backfilling it is not worth building. * Adaptive SQM: give the boot script room to install its dependencies A first deploy runs the boot script over SSH with no timeout argument, so it inherited the 30 second default. The script installs its dependencies inline before it does anything else: it adds the Ookla packagecloud repo, which runs its own apt-get update and fetches a GPG key, then apt-get installs speedtest, bc and jq. On a cold apt cache or a slow WAN that comfortably outruns 30 seconds, and the deploy then tore down a deployment that was still working and reported that the boot script had failed. Give that one command five minutes, which clears a slow first install without leaving the page sitting on a boot script that has genuinely wedged. Re-deploys skip the whole block once the dependencies are present, which is why this only ever bit the first attempt. (cherry picked from commit cb8400b) * Add UPS-2U-Pro device support * Classify UniFi power devices as SmartPower * Display Smart Power device type with spacing * Address SmartPower review feedback --------- Co-authored-by: TJ @ Ozark Connect <109822114+tvancott42@users.noreply.github.com> Co-authored-by: TJ da Tuna <tjvc42@gmail.com>

Uh oh!

Uh oh!

Move remaining agent-on-gateway checks onto the durable per-agent detector, and widen the gateway address set #1106

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions