From 7c128ac7528beec3b213ea6d287aedb55b0f57bb Mon Sep 17 00:00:00 2001 From: CausticKirbyZ Date: Mon, 7 Oct 2024 17:06:56 -0500 Subject: [PATCH 1/2] Update ssl.cr changed HostDataSSLCert#serial type to a UInt128. This supports bigger serial numbers and fixes any parsing issues with numbers larger than an Int64 supports --- src/shodan/parsers/host_services/ssl.cr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shodan/parsers/host_services/ssl.cr b/src/shodan/parsers/host_services/ssl.cr index 3e95223..07429ca 100644 --- a/src/shodan/parsers/host_services/ssl.cr +++ b/src/shodan/parsers/host_services/ssl.cr @@ -68,7 +68,7 @@ module Shodan property version : Int32? property extensions : Array(HostDataSSLExtensions)? property fingerprint : Hash(String, String)? - property serial : Int64? + property serial : UInt128? property subject : HostDataSslSubject property issuer : HostDataSslIssuer end From 7d02b02e3dd980947221264e08ec5e63ad214d75 Mon Sep 17 00:00:00 2001 From: CausticKirbyZ Date: Mon, 7 Oct 2024 17:31:00 -0500 Subject: [PATCH 2/2] Update ssl.cr changed it to a string for more support as UInt128 still wasnt big enough --- src/shodan/parsers/host_services/ssl.cr | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/shodan/parsers/host_services/ssl.cr b/src/shodan/parsers/host_services/ssl.cr index 07429ca..7ad7eef 100644 --- a/src/shodan/parsers/host_services/ssl.cr +++ b/src/shodan/parsers/host_services/ssl.cr @@ -68,7 +68,12 @@ module Shodan property version : Int32? property extensions : Array(HostDataSSLExtensions)? property fingerprint : Hash(String, String)? - property serial : UInt128? + + # property serial : UInt128? + # changed to the below as there are certs with larger serial numbers than an UInt128 supports + @[JSON::Field(converter: String::RawConverter)] + property serial : String? + property subject : HostDataSslSubject property issuer : HostDataSslIssuer end