From fec5f0a1b96c74dd6d38988d549b69983fc4116f Mon Sep 17 00:00:00 2001 From: Andrea Pozzetti Date: Mon, 11 May 2026 00:51:08 +0200 Subject: [PATCH] desktop: fix .rstrip(".git") mangling node names ending in g/i/t/. str.rstrip takes a set of chars to strip, not a suffix -- so "ComfyUI-UniRig.git".rstrip(".git") yields "ComfyUI-UniR" (the trailing "ig" gets eaten after .git). Every downstream fetch (pyproject.toml, comfy-test.toml, workflows/) then 404s on the mangled URL and the run reports "no workflows ran" with rc=0. Use str.removesuffix(".git") so only the actual ".git" suffix is trimmed. Manifested on UniRig (ends in 'g') -- would also break any node ending in g/i/t/. (e.g. *-Lit, *-Edit, *-Pi). Co-Authored-By: Claude Opus 4.7 (1M context) --- src/comfy_test/cli/_desktop_runner.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/comfy_test/cli/_desktop_runner.py b/src/comfy_test/cli/_desktop_runner.py index c7ec8c0..15caae8 100644 --- a/src/comfy_test/cli/_desktop_runner.py +++ b/src/comfy_test/cli/_desktop_runner.py @@ -749,7 +749,11 @@ def _sig_cleanup(signum, _frame): # rate-limit). cdp_driver picks up the list via COMFY_TEST_WORKFLOWS env. from comfy_test.cli._nodelink import clone_node, expand_nodelink - url = expand_nodelink(args.nodelink).rstrip(".git") + # NOT .rstrip(".git") -- that strips ANY trailing chars in {'.','g','i','t'}, + # so "ComfyUI-UniRig.git" becomes "ComfyUI-UniR" and every downstream fetch + # (pyproject.toml, comfy-test.toml, workflows/) 404s, leaving the run with + # "no workflows ran" but rc=0. + url = expand_nodelink(args.nodelink).removesuffix(".git") node_name = url.rsplit("/", 1)[-1] clone_root = Path(tempfile.mkdtemp(prefix="comfy-test-desktop-clone-"))