From 3886583ef15b7e6b6721097f16ecd74fc6f4d692 Mon Sep 17 00:00:00 2001 From: Promansis Date: Tue, 19 May 2026 22:11:59 +0800 Subject: [PATCH] agents: fix spotify redirect setup copy --- .../agents/components/AgentEditor.tsx | 5 ++- updates/people/promansis.md | 33 +++++++++++++++++-- 2 files changed, 33 insertions(+), 5 deletions(-) diff --git a/src/features/agents/components/AgentEditor.tsx b/src/features/agents/components/AgentEditor.tsx index c7d5a08..a8155da 100644 --- a/src/features/agents/components/AgentEditor.tsx +++ b/src/features/agents/components/AgentEditor.tsx @@ -1524,9 +1524,8 @@ export function AgentEditor() {

Spotify only accepts https:// redirect URIs or loopback ( http://127.0.0.1). If you're running Marinara on another - machine over plain HTTP, register the loopback URI anyway and use the paste-back fallback that - appears under the Connect button — or set{" "} - SPOTIFY_REDIRECT_URI to your HTTPS URL. + machine, register the loopback URI shown above and use the paste-back fallback that appears under + the Connect button.

diff --git a/updates/people/promansis.md b/updates/people/promansis.md index defa9d6..2982eba 100644 --- a/updates/people/promansis.md +++ b/updates/people/promansis.md @@ -2,11 +2,40 @@ ## Current Work -No current work listed. +- Spotify setup redirect URI instructions + - Status: Ready for review on `fix/spotify-redirect-uri-setup` + - Impact area: Spotify agent setup UI, native Spotify OAuth capability contract + - Next step: Review the focused local commit and manually confirm the Spotify setup copy in the agent editor. + - Blockers: None. ## Owned Bugs -No owned bugs currently listed. +## Spotify setup tells users to set a redirect URI env var that native auth ignores + +- Status: Ready for review on `fix/spotify-redirect-uri-setup` +- Owner: Promansis +- Impact area: UI | Rust capability +- Reported: Local backlog item 20 +- Last updated: 2026-05-19 + +### Steps + +1. Open the Spotify DJ agent setup. +2. Read the Spotify redirect URI instructions. + +### Expected + +The setup instructions should describe the redirect URI that native Spotify auth actually uses. + +### Actual + +The setup copy told users they could set `SPOTIFY_REDIRECT_URI` to an HTTPS URL, but the frontend status and Rust OAuth flow use the fixed loopback callback. + +### Notes + +- Owner is the Spotify agent setup UI copy, with the Rust Spotify OAuth callback contract reviewed as the dependent capability. +- Fixed by documenting the supported loopback redirect URI and paste-back fallback instead of advertising an unsupported environment override. +- Verification: `pnpm typecheck`; `cargo check --manifest-path src-tauri/Cargo.toml`. ## Status Notes