feat: implement idempotent execution for batch payout#836
Open
Jopsan-gm wants to merge 1 commit into
Open
Conversation
|
@Jopsan-gm Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Fix workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: feat(crowdfund): add idempotent retry protection for batch payout
Summary
This PR implements idempotent retry protection for the
batch_payoutmechanism in thecrowdfund_vaultcontract to prevent unintended double-executions of payouts.Changes include:
ExecutedBatch(BytesN<32>)to theDataKeyenum instorage.rsto persist execution hashes.DuplicateExecutioncustom error inerrors.rs.batch_payoutfunction inlib.rsto require abatch_id: BytesN<32>and reject duplicate calls if the batch hash is already present in persistent storage.test_batch_payout_duplicate_execution, to explicitly verify the idempotency mechanism works correctly.Linked Issue
Closes #689
Type of Change
Validation
Documentation
Screenshots
Checklist
feat/,fix/, ordocs/