Skip to content

Commit ec14aa0

Browse files
authored
Merge pull request #78 from Jammy2211/feature/visualizer_refactor
fix unit tests
2 parents 4d5312e + 702f574 commit ec14aa0

5 files changed

Lines changed: 15 additions & 6 deletions

File tree

autocti/charge_injection/plot/fit_ci_plotters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ def figures_1d(
265265
)
266266

267267
if noise_map:
268-
y = self.extract_region_from(array=self.fit.image, region=region)
268+
y = self.extract_region_from(array=self.fit.data, region=region)
269269

270270
self.mat_plot_1d.plot_yx(
271271
y=y,

autocti/model/analysis.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ def save_results_combined(self, paths: af.DirectoryPaths, result: ResultImagingC
7575
The result of a model fit, including the non-linear search and samples.
7676
"""
7777

78+
if result.samples is None:
79+
return
80+
7881
weight_list = []
7982
delta_ellipticity_list = []
8083

docs/api/data.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ grids of (y,x) Cartesian coordinates.
1818
Mask2D
1919
Array2D
2020
Grid2D
21-
Grid2DIterate
2221
Grid2DIrregular
2322

2423
Charge Injection Imaging

test_autocti/aggregator/conftest.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
from autoconf import conf
77
import autofit as af
88
import autocti as ac
9+
from autoconf.conf import with_config
910
from autofit.non_linear.samples import Sample
1011

1112

@@ -28,6 +29,12 @@ def clean(database_file):
2829
shutil.rmtree(result_path)
2930

3031

32+
@with_config(
33+
"general",
34+
"output",
35+
"samples_to_csv",
36+
value=True,
37+
)
3138
def aggregator_from(database_file, analysis, model, samples):
3239
result_path = path.join(conf.instance.output_path, database_file)
3340

test_autocti/charge_injection/model/test_analysis_ci.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ def test__full_and_extracted_fits_from_instance_and_imaging_ci(
212212

213213
fit = ac.FitImagingCI(dataset=masked_dataset, post_cti_data=post_cti_data)
214214

215-
assert fit.image.shape == (7, 1)
215+
assert fit.data.shape == (7, 1)
216216
assert fit_analysis.log_likelihood == pytest.approx(fit.log_likelihood)
217217

218218
fit_full_analysis = analysis.fit_via_instance_and_dataset_from(
@@ -221,7 +221,7 @@ def test__full_and_extracted_fits_from_instance_and_imaging_ci(
221221

222222
fit = ac.FitImagingCI(dataset=imaging_ci_7x7, post_cti_data=post_cti_data)
223223

224-
assert fit.image.shape == (7, 7)
224+
assert fit.data.shape == (7, 7)
225225
assert fit_full_analysis.log_likelihood == pytest.approx(fit.log_likelihood)
226226

227227

@@ -273,7 +273,7 @@ def test__extracted_fits_from_instance_and_imaging_ci__include_noise_scaling(
273273
},
274274
)
275275

276-
assert fit.image.shape == (7, 1)
276+
assert fit.data.shape == (7, 1)
277277
assert fit.log_likelihood == pytest.approx(fit_analysis.log_likelihood, 1.0e-4)
278278

279279
fit = ac.FitImagingCI(
@@ -300,7 +300,7 @@ def test__extracted_fits_from_instance_and_imaging_ci__include_noise_scaling(
300300
},
301301
)
302302

303-
assert fit.image.shape == (7, 7)
303+
assert fit.data.shape == (7, 7)
304304
assert fit.log_likelihood == pytest.approx(fit_full_analysis.log_likelihood, 1.0e-4)
305305

306306
fit = ac.FitImagingCI(

0 commit comments

Comments
 (0)