Installing maturin_import_hook causes the binary file from pip to fail on Windows.

[wangzhen0518]

Bug Description

After installing maturin_import_hook, I failed to execute binary file installed from pip, e.g.,

> python -m maturin_import_hook site install
> pip
Could not import runpy module
Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1138, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1078, in _find_spec
  File "C:\Users\Admin\wangzhen\project\LearnRustPython\rs4py\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 143, in find_spec
    project_dir, is_editable = _load_dist_info(search_path, package_name)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Admin\wangzhen\project\LearnRustPython\rs4py\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 407, in _load_dist_info      
    dist_info_path = _find_dist_info_path(path, package_name)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Admin\wangzhen\project\LearnRustPython\rs4py\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 395, in _find_dist_info_path 
    names = os.listdir(directory)
            ^^^^^^^^^^^^^^^^^^^^^
NotADirectoryError: [WinError 267] 目录名称无效。: 'C:\\Users\\Admin\\wangzhen\\project\\LearnRustPython\\rs4py\\.venv\\Scripts\\pip.exe'
> pipx
Could not import runpy module
Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1138, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1078, in _find_spec
  File "C:\Users\Admin\wangzhen\project\LearnRustPython\rs4py\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 143, in find_spec
    project_dir, is_editable = _load_dist_info(search_path, package_name)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Admin\wangzhen\project\LearnRustPython\rs4py\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 407, in _load_dist_info      
    dist_info_path = _find_dist_info_path(path, package_name)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Admin\wangzhen\project\LearnRustPython\rs4py\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 395, in _find_dist_info_path 
    names = os.listdir(directory)
            ^^^^^^^^^^^^^^^^^^^^^
NotADirectoryError: [WinError 267] 目录名称无效。: 'C:\\Users\\Admin\\wangzhen\\project\\LearnRustPython\\rs4py\\.venv\\Scripts\\pipx.exe'

Other binary files, such as ipython, also fail.

I have found how to fix it. Just add a exception type when dealing exception in _find_dist_info_path, i.e., change

maturin-import-hook/src/maturin_import_hook/project_importer.py

Lines 393 to 397 in a6de9d0

	def _find_dist_info_path(directory: Path, package_name: str) -> Optional[Path]:
	try:
	names = os.listdir(directory)
	except FileNotFoundError:
	return None

to

def _find_dist_info_path(directory: Path, package_name: str) -> Optional[Path]:
    try:
        names = os.listdir(directory)
    except (FileNotFoundError, NotADirectoryError):
        return None

Shall I make a pr to fix it?

Steps to Reproduce

> uv venv --python 3.11
> uv pip install maturin_import_hook maturin pip pipx
> pip
Could not import runpy module
Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1138, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1078, in _find_spec
  File "C:\Users\Admin\wangzhen\project\LearnRustPython\rs4py\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 143, in find_spec
    project_dir, is_editable = _load_dist_info(search_path, package_name)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Admin\wangzhen\project\LearnRustPython\rs4py\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 407, in _load_dist_info      
    dist_info_path = _find_dist_info_path(path, package_name)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Admin\wangzhen\project\LearnRustPython\rs4py\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 395, in _find_dist_info_path 
    names = os.listdir(directory)
            ^^^^^^^^^^^^^^^^^^^^^
NotADirectoryError: [WinError 267] 目录名称无效。: 'C:\\Users\\Admin\\wangzhen\\project\\LearnRustPython\\rs4py\\.venv\\Scripts\\pip.exe'
> pipx
Could not import runpy module
Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1138, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1078, in _find_spec
  File "C:\Users\Admin\wangzhen\project\LearnRustPython\rs4py\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 143, in find_spec
    project_dir, is_editable = _load_dist_info(search_path, package_name)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Admin\wangzhen\project\LearnRustPython\rs4py\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 407, in _load_dist_info      
    dist_info_path = _find_dist_info_path(path, package_name)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Admin\wangzhen\project\LearnRustPython\rs4py\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 395, in _find_dist_info_path 
    names = os.listdir(directory)
            ^^^^^^^^^^^^^^^^^^^^^
NotADirectoryError: [WinError 267] 目录名称无效。: 'C:\\Users\\Admin\\wangzhen\\project\\LearnRustPython\\rs4py\\.venv\\Scripts\\pipx.exe'

Please provide the output of python -m maturin_import_hook version (or provide manually)

OS: Windows-10-10.0.26100-SP0
Python: CPython 3.11.12
maturin-import-hook: 0.2.0
maturin: maturin 1.8.6
rustc: rustc 1.86.0 (05f9846f8 2025-03-31)
pip: 25.1.1

Does maturin develop work when run manually for your project?

• Yes/No (leave blank if not applicable)

[mbway]

Thanks for the bug report.

I took a look and the issue is triggered on windows when any script (not just pip) is run and the import hook is used (not just installed site wide). Scripts gets installed to venv\Scripts\script_name.exe and when run, sys.path contains the .exe in addition to search directories.

I agree that just handling the NotADirectoryError is sufficient. I would like to have a unit test checking for this so I put together a PR here.

[wangzhen0518]

Hi, thanks for helping. I install maturin-import-hook from this pr #23, and it seems the problem is not solved.

> git clone git@github.com:PyO3/maturin-import-hook.git
> cd maturin-import-hook
> git config --add remote.origin.fetch "+refs/pull/*/head:refs/remotes/origin/pr/*"
> git checkout pr/23
> uv venv --python 3.11
> .\.venv\Scripts\activate
> uv pip install .
> uv pip install maturin ipython
> python -m maturin_import_hook site install
> ipython
Could not import runpy module
Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1138, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1078, in _find_spec
  File "D:\Project\LearnRustPython\maturin-import-hook\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 143, in find_spec
    project_dir, is_editable = _load_dist_info(search_path, package_name)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Project\LearnRustPython\maturin-import-hook\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 407, in _load_dist_info
    dist_info_path = _find_dist_info_path(path, package_name)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Project\LearnRustPython\maturin-import-hook\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 395, in _find_dist_info_path
    names = [item.name for item in directory.iterdir()]
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Project\LearnRustPython\maturin-import-hook\.venv\Lib\site-packages\maturin_import_hook\project_importer.py", line 395, in <listcomp>
    names = [item.name for item in directory.iterdir()]
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\wangzhen0518\AppData\Roaming\uv\python\cpython-3.11.12-windows-x86_64-none\Lib\pathlib.py", line 931, in iterdir
    for name in os.listdir(self):
                ^^^^^^^^^^^^^^^^
NotADirectoryError: [WinError 267] 目录名称无效。: 'D:\\Project\\LearnRustPython\\maturin-import-hook\\.venv\\Scripts\\ipython.exe'

Path.iterdir also uses os.listdir which does not support non-directory items.

[mbway]

sorry, I don't know if it was in draft at the point you tried it, but I wanted the new test to fail first to demonstrate that it successfully exhibits the issue, then I fixed it as-of this commit 753cf3b

if you pull the latest from the branch it should be fixed

[wangzhen0518]

Oh, yes! I used commit c285c5b, which was the latest commit. I pulled again, and the problem was solved. Thanks again!

[mbway]

Once #23 and #14 are merged I'll create a new release