refactor: decouple default product id from device duid and share DEFAULT_PRODUCT_ID constant

Author: allenporter

roborock/testing/__init__.py

@@ -65,7 +65,12 @@ async def test_start_vacuum_service():
 
 from roborock.testing.channel import FakeChannel
 from roborock.testing.cloud import FakeRoborockCloud, FakeWebApiClient
-from roborock.testing.simulator import RoborockDeviceSimulator
+from roborock.testing.simulator import (
+    DEFAULT_KEY_T,
+    DEFAULT_LOCAL_KEY,
+    DEFAULT_PRODUCT_ID,
+    RoborockDeviceSimulator,
+)
 from roborock.testing.v1_simulator import (
     DEFAULT_APP_INIT,
     DEFAULT_CLEAN_SUMMARY,
@@ -82,8 +87,11 @@ async def test_start_vacuum_service():
     "DEFAULT_CLEAN_SUMMARY",
     "DEFAULT_CONSUMABLE",
     "DEFAULT_DND_TIMER",
+    "DEFAULT_KEY_T",
     "DEFAULT_LAST_CLEAN_RECORD",
+    "DEFAULT_LOCAL_KEY",
     "DEFAULT_NETWORK_INFO",
+    "DEFAULT_PRODUCT_ID",
     "DEFAULT_STATUS",
     "FakeChannel",
     "FakeRoborockCloud",

roborock/testing/simulator.py

@@ -16,6 +16,7 @@
 # Shared authentication key constants
 DEFAULT_LOCAL_KEY = "fake_localkey_16bytes"
 DEFAULT_KEY_T = "qiCNieZa"
+DEFAULT_PRODUCT_ID = "product-id-123"
 
 
 class RoborockDeviceSimulator:
@@ -56,7 +57,7 @@ def __init__(
     ):
         self.duid = duid
         self.product = product or HomeDataProduct(
-            id=f"product_{self.duid}",
+            id=DEFAULT_PRODUCT_ID,
             name="Roborock Vacuum",
             model="roborock.vacuum.s7",
             category=RoborockCategory.VACUUM,