remove timing logs, cleanup non-existant @params

Author: qqmyers

src/main/java/edu/harvard/iq/dataverse/FileDownloadServiceBean.java

@@ -129,9 +129,6 @@ public void writeGuestbookAndStartBatchDownload(GuestbookResponse guestbookRespo
         boolean useCustomZipService = customZipDownloadUrl != null; 
         String zipServiceKey = null;
 
-        totalPrepNanos = 0L;
-        totalWriteNanos = 0L;
-        long totalStartNanos = System.nanoTime();
         long numFiles = guestbookResponse.getSelectedFileIds().split(",").length;
         // Do we need to write GuestbookRecord entries for the files? 
         if (!doNotSaveGuestbookRecord) {
@@ -162,14 +159,6 @@ public void writeGuestbookAndStartBatchDownload(GuestbookResponse guestbookRespo
             }
 
         }
-        logger.info(String.format(
-                Locale.ROOT,
-                "downloadDatafiles timing: total=%d ms, prep=%d ms, write=%d ms, files=%d",
-                TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - totalStartNanos),
-                TimeUnit.NANOSECONDS.toMillis(totalPrepNanos),
-                TimeUnit.NANOSECONDS.toMillis(totalWriteNanos),
-                numFiles
-        ));
         if (useCustomZipService) {
             redirectToCustomZipDownloadService(customZipDownloadUrl, zipServiceKey);
         } else {
@@ -247,7 +236,6 @@ public List<String> writeGuestbookResponseRecords(GuestbookResponse guestbookRes
         if (guestbookResponse == null || guestbookResponse.getSelectedFileIds() == null || guestbookResponse.getSelectedFileIds().isBlank()) {
             return Collections.emptyList();
         }
-        long prepStartNanos = System.nanoTime();
 
         List<DataFile> selectedDataFiles = resolveSelectedDataFiles(guestbookResponse.getSelectedFileIds());
         if (selectedDataFiles.isEmpty()) {
@@ -260,11 +248,7 @@ public List<String> writeGuestbookResponseRecords(GuestbookResponse guestbookRes
             perFileResponse.setDataFile(dataFile);
             responsesToPersist.add(perFileResponse);
         }
-        Long writeStartNanos = System.nanoTime();
-        totalPrepNanos = writeStartNanos - prepStartNanos;
         List<String> savedIds = saveGuestbookResponseRecordsAndMDCLogEntries(responsesToPersist);
-        totalWriteNanos = System.nanoTime() - writeStartNanos;
-
         return savedIds;
     }
 
@@ -349,13 +333,10 @@ public List<String> saveGuestbookResponseRecordsAndMDCLogEntries(List<GuestbookR
         return savedIds;
     }
 
-    long totalPrepNanos = 0L;
-    long totalWriteNanos = 0L;
     public String writeGuestbookResponseRecord(GuestbookResponse guestbookResponse) {
         String guestbookResponseIds = "";
 
         try {
-            long storageStartNanos = System.nanoTime();
             CreateGuestbookResponseCommand cmd = new CreateGuestbookResponseCommand(
                     dvRequestService.getDataverseRequest(),
                     guestbookResponse,

src/main/java/edu/harvard/iq/dataverse/api/Access.java

@@ -1014,21 +1014,18 @@ private Response downloadDatafiles(ContainerRequestContext crc, String body, boo
 //        ToDo - cache dataset perms, e.g. editdataset let's you get all files (assuming one dataset)
         // Same for filedownload if assigned at the dataset level
 
-        long totalAuthorizationNanos = 0L;
         for (int i = 0; i < fileIdParams.length; i++) {
             DataFile df = findDataFileOrDieWrapper(fileIdParams[i]);
             if (guestbookResponseRequired == null) {
                 // Only need to check this on the first file
                 guestbookResponseRequired = checkGuestbookRequiredResponse(crc, uriInfo, df, gbrids);
             }
-            long authStartNanos = System.nanoTime();
             if(i==1) logger.info("Downloading" + fileIdParams.length + " files. GBR required: " + guestbookResponseRequired);
             datafilesMap.put(df.getId(), df);
             datasetIds.add(df.getOwner() != null ? df.getOwner().getId() : 0L);
             if (isAccessAuthorized(user, df)) {
                 authorizedDatafileIds.add(df.getId());
             }
-            totalAuthorizationNanos += System.nanoTime() - authStartNanos;
 
             if (datasetIds.size() > 1) {
                 // All files must be from the same Dataset
@@ -1052,12 +1049,6 @@ private Response downloadDatafiles(ContainerRequestContext crc, String body, boo
                 }
             }
         }
-        logger.info(String.format(
-                Locale.ROOT,
-                "downloadDatafiles timing: authorization=%d ms, files=%d",
-                TimeUnit.NANOSECONDS.toMillis(totalAuthorizationNanos),
-                fileIdParams.length
-        ));
 
         if (useCustomZipService) {
             URI redirect_uri = null;
@@ -1456,7 +1447,6 @@ private String getWebappImageResource(String imageName) {
      * @param isPublic
      * @param type
      * @param fileInputStream
-     * @param contentDispositionHeader
      * @param formDataBodyPart
      * @return 
      *
@@ -1525,12 +1515,7 @@ public Response saveAuxiliaryFileWithVersion(@Context ContainerRequestContext cr
      * @param fileId
      * @param formatTag
      * @param formatVersion
-     * @param origin
-     * @param isPublic
-     * @param fileInputStream
-     * @param contentDispositionHeader
-     * @param formDataBodyPart
-     * @return 
+     * @return
      */
     @DELETE
     @AuthRequired