Resolve review comments

Author: JosueNina

lean/commands/backtest.py

@@ -299,7 +299,7 @@ def backtest(project: Path,
              extra_config: Optional[Tuple[str, str]],
              extra_docker_config: Optional[str],
              no_update: bool,
-             parameter: List[Tuple[str, str]] = None,
+             parameter: List[Tuple[str, str]],
              **kwargs) -> None:
     """Backtest a project locally using Docker.
 
@@ -399,8 +399,7 @@ def backtest(project: Path,
                                 kwargs, logger, environment_name, container_module_version)
 
     if parameter:
-        from lean.components.config.lean_config_manager import LeanConfigManager
-        parameters = LeanConfigManager.parse_parameters(parameter)
+        parameters = dict(parameter)
         logger.debug(f"Using parameters from command line: {parameters}")
         lean_config["parameters"] = parameters
 

lean/commands/cloud/backtest.py

@@ -55,8 +55,10 @@ def backtest(project: str, name: Optional[str], push: bool, open_browser: bool,
     if name is None:
         name = container.name_generator.generate_name()
 
-    from lean.components.config.lean_config_manager import LeanConfigManager
-    parameters = LeanConfigManager.parse_parameters(parameter)
+    parameters = None
+    if parameter:
+        parameters = dict(parameter)
+        logger.debug(f"Using parameters: {parameters}")
 
     cloud_runner = container.cloud_runner
     finished_backtest = cloud_runner.run_backtest(cloud_project, name, parameters)

lean/components/api/backtest_client.py

@@ -40,7 +40,7 @@ def get(self, project_id: int, backtest_id: str) -> QCBacktest:
 
         return QCBacktest(**data["backtest"])
 
-    def create(self, project_id: int, compile_id: str, name: str, parameters: Dict[str, Union[int, float, str]] = None) -> QCBacktest:
+    def create(self, project_id: int, compile_id: str, name: str, parameters: Dict[str, str] = None) -> QCBacktest:
         """Creates a new backtest.
 
         :param project_id: the id of the project to create a backtest for

lean/components/cloud/cloud_runner.py

@@ -75,7 +75,7 @@ def is_backtest_done(self, backtest_data: QCBacktest, delay: float = 10.0):
             self._logger.error(f"Error checking backtest completion status for ID {backtest_data.backtestId}: {e}")
             raise
 
-    def run_backtest(self, project: QCProject, name: str, parameters: Dict[str, Union[int, float, str]] = None) -> QCBacktest:
+    def run_backtest(self, project: QCProject, name: str, parameters: Dict[str, str] = None) -> QCBacktest:
         """Runs a backtest in the cloud.
 
         :param project: the project to backtest
@@ -87,8 +87,6 @@ def run_backtest(self, project: QCProject, name: str, parameters: Dict[str, Unio
         created_backtest = self._api_client.backtests.create(project.projectId, finished_compile.compileId, name, parameters)
 
         self._logger.info(f"Started backtest named '{name}' for project '{project.name}'")
-        if parameters:
-            self._logger.debug(f"Using parameters: {parameters}")
         self._logger.info(f"Backtest url: {created_backtest.get_url()}")
 
         try:

lean/components/config/lean_config_manager.py

@@ -13,7 +13,8 @@
 
 from os.path import normcase, normpath
 from pathlib import Path
-from typing import Any, Dict, Optional, List, Tuple, Union
+from typing import Any, Dict, Optional, List
+
 
 from lean.components.cloud.module_manager import ModuleManager
 from lean.components.config.cli_config_manager import CLIConfigManager
@@ -352,16 +353,3 @@ def parse_json(self, content) -> Dict[str, Any]:
             # just in case slower fallback
             from json5 import loads
             return loads(content)
-
-    @staticmethod
-    def parse_parameters(parameters: List[Tuple[str, str]]) -> Dict[str, Union[int, float, str]]:
-        """Parse parameters from command line to appropriate types."""
-        parsed: Dict[str, Union[int, float, str]] = {}
-        for key, value in parameters:
-            try:
-                num = float(value)
-                parsed_value = int(num) if num.is_integer() else num
-            except ValueError:
-                parsed_value = value
-            parsed[key] = parsed_value
-        return parsed

tests/commands/cloud/test_backtest.py

@@ -271,7 +271,7 @@ def test_cloud_backtest_with_parameters() -> None:
     parameters = args[2]
 
     # --parameter values should be parsed correctly
-    assert parameters["integer"] == 123.0
-    assert parameters["float"] == 456.789
+    assert parameters["integer"] == "123"
+    assert parameters["float"] == "456.789"
     assert parameters["string"] == "hello world"
-    assert parameters["negative"] == -42.5
+    assert parameters["negative"] == "-42.5"

tests/commands/test_backtest.py

@@ -750,10 +750,10 @@ def test_backtest_with_parameters() -> None:
     parameters = lean_config["parameters"]
 
     # --parameter values should be parsed correctly
-    assert parameters["integer"] == 123.0
-    assert parameters["float"] == 456.789
+    assert parameters["integer"] == "123"
+    assert parameters["float"] == "456.789"
     assert parameters["string"] == "hello world"
-    assert parameters["negative"] == -42.5
+    assert parameters["negative"] == "-42.5"
 
 
 def test_backtest_parameters_override_config_json() -> None:
@@ -805,7 +805,7 @@ def test_backtest_parameters_override_config_json() -> None:
     # Only CLI --parameter values should remain
     assert "param1" not in parameters
     assert "param2" not in parameters
-    assert parameters["integer"] == 123
-    assert parameters["float"] == 456.789
+    assert parameters["integer"] == "123"
+    assert parameters["float"] == "456.789"
     assert parameters["string"] == "hello world"
-    assert parameters["negative"] == -42.5
+    assert parameters["negative"] == "-42.5"