fix test_get_values_one_industry

Author: jnelson16

README.md

@@ -176,7 +176,7 @@ There are two different ways to download data retrieved from RegCensusAPI:
 
 1. Use the pandas `df.to_csv(outpath)` function, which allows the user to download a csv of the data, with the given outpath. See the pandas [documentation][3] for more features.
 
-2. The __get_values__ function includes a `download` argument, which allows the user to simply download a csv of the data in the same line as the API call. See below for an example of this call.
+2. As of version 0.2.0, the __get_values__ function includes a `download` argument, which allows the user to simply download a csv of the data in the same line as the API call. See below for an example of this call.
 
 ```
 rc.get_values(series = [1,2], jurisdiction = 38, date = [2010, 2019], download='regdata2010to2019.csv')

regcensus/api.py

@@ -136,6 +136,7 @@ def get_values(series, jurisdiction, date, filtered=True, summary=True,
     # Prints error message if call fails
     if (output.columns[:3] == ['title', 'status', 'detail']).all():
         print('WARNING:', output.iloc[0][-1])
+        return
     elif download:
         if type(download) == str:
             clean_columns(output).to_csv(download, index=False)

tests/test_api.py

@@ -65,7 +65,8 @@ def test_get_values_multiple_series():
 
 
 def test_get_values_incorrect_series(capsys):
-    rc.get_values(series=None, jurisdiction=38, date=2019)
+    results = rc.get_values(series=None, jurisdiction=38, date=2019)
+    assert not results
     assert capsys.readouterr().out == (
         'Valid series ID required. Select from the following list:\n'
     )
@@ -99,14 +100,17 @@ def test_get_values_multiple_industries():
 
 def test_get_values_one_industry():
     results = rc.get_values(
-        series=9, jurisdiction=58, date=2019, industry='111', summary=False
+        series=9, jurisdiction=58, date='2019-05-15',
+        industry='111', summary=False
     )
-    # No document-level industry results exists for this jurisdiction
-    assert not results
+    assert order_results(results, 'seriesValue') == [
+        0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0
+    ]
 
 
 def test_get_values_incorrect_jurisdiction(capsys):
-    rc.get_values(series=1, jurisdiction=None, date=2019)
+    results = rc.get_values(series=1, jurisdiction=None, date=2019)
+    assert not results
     assert capsys.readouterr().out == 'Valid jurisdiction ID required.\n'
 
 
@@ -128,7 +132,8 @@ def test_get_values_multiple_dates():
 
 
 def test_get_values_incorrect_dates(capsys):
-    rc.get_values(series=1, jurisdiction=38, date=None)
+    results = rc.get_values(series=1, jurisdiction=38, date=None)
+    assert not results
     assert capsys.readouterr().out == 'Valid date is required.\n'
 
 
@@ -153,20 +158,33 @@ def test_get_values_multiple_agencies():
 
 
 def test_get_values_download():
-    rc.get_values(
+    results = rc.get_values(
         series=91, jurisdiction=38, date=2019, agency=195, download='test.csv'
     )
+    assert not results
     assert os.path.exists('test.csv')
     os.remove('test.csv')
 
 
 def test_get_values_incorrect_download(capsys):
-    rc.get_values(
+    results = rc.get_values(
         series=91, jurisdiction=38, date=2019, agency=195, download=True
     )
+    assert not results
     assert capsys.readouterr().out == 'Valid outpath required to download.\n'
 
 
+def test_get_values_error(capsys):
+    results = rc.get_values(series=1, jurisdiction=38, date=1900)
+    assert not results
+    assert capsys.readouterr().out == (
+        'WARNING: SeriesValue was not found for the specified parameters'
+        '{parameters={jurisdiction=[38], date=[1900], industry=null, '
+        'agency=null, dateIsRange=false, filteredOnly=true, summary=true, '
+        'documentType=3, documentID=null}}\n'
+    )
+
+
 def test_list_document_types():
     results = rc.list_document_types()
     assert results['All Regulations'] == 3