Merge pull request #1252 from QueryaHub/chore/1241-async-lints

chore(lint): enable unawaited_futures, cancel_subscriptions, close_sinks and avoid_void_async (#1241)

Author: ZhuchkaTriplesix

analysis_options.yaml

@@ -22,4 +22,8 @@ linter:
   rules:
     - prefer_const_constructors
     - prefer_const_declarations
+    - unawaited_futures
+    - cancel_subscriptions
+    - close_sinks
+    - avoid_void_async
 

lib/core/database/connection_pool_lock.dart

@@ -31,7 +31,7 @@ class PoolEntryLock<T> {
         // Ensure the pending entry is removed once the creation finishes, and
         // swallow errors on the cleanup chain so they don't become unhandled.
         final guarded = future.whenComplete(() => _pending.remove(key));
-        guarded.then((_) {}, onError: (_) {});
+        unawaited(guarded.then((_) {}, onError: (_) {}));
         result = future;
       }
     } finally {

lib/core/database/mongodb_connection.dart

@@ -399,7 +399,7 @@ class MongoConnection {
         _openedDbs[databaseName] = db;
         return db;
       } finally {
-        _openingDbs.remove(databaseName);
+        unawaited(_openingDbs.remove(databaseName));
       }
     });
   }

lib/core/mcp/mcp_socket_host.dart

@@ -116,18 +116,25 @@ class McpSocketHost {
         unawaited(onSession(StreamChannel.withCloseGuarantee(
             incoming.stream, outgoing.sink)));
       },
-      onDone: () => _closed(socket, incoming, authed),
-      onError: (_) => _closed(socket, incoming, authed),
+      onDone: () => _closed(socket, incoming, outgoing, authed),
+      onError: (_) => _closed(socket, incoming, outgoing, authed),
       cancelOnError: true,
     );
   }
 
-  void _closed(Socket socket, StreamController<String> incoming, bool authed) {
+  void _closed(
+    Socket socket,
+    StreamController<String> incoming,
+    StreamController<String> outgoing,
+    bool authed,
+  ) {
     if (_sockets.remove(socket) && authed) {
       _sessions--;
       _changes.add(null);
     }
     unawaited(incoming.close());
+    // The channel guarantees no write after the incoming side closed.
+    unawaited(outgoing.close());
     socket.destroy();
   }
 

lib/core/security/ssh_tunnel_manager.dart

@@ -80,10 +80,10 @@ class _PooledTunnelSession {
       await serverSocket.close();
     } catch (_) {}
     try {
-      client.close();
+      unawaited(client.close());
     } catch (_) {}
     try {
-      jumpClient?.close();
+      unawaited(jumpClient?.close());
     } catch (_) {}
   }
 }
@@ -274,8 +274,8 @@ class SshTunnelManager {
     try {
       await client.authenticated;
     } catch (e) {
-      client.close();
-      jumpClient?.close();
+      unawaited(client.close());
+      unawaited(jumpClient?.close());
       if (observedFingerprint != null &&
           config.knownHostFingerprint != null &&
           config.knownHostFingerprint!.isNotEmpty) {
@@ -303,8 +303,8 @@ class SshTunnelManager {
       (clientSocket) async {
         try {
           final forward = await client.forwardLocal(remoteHost, remotePort);
-          forward.stream.cast<List<int>>().pipe(clientSocket).catchError((_) {});
-          clientSocket.cast<List<int>>().pipe(forward.sink).catchError((_) {});
+          unawaited(forward.stream.cast<List<int>>().pipe(clientSocket).catchError((_) {}));
+          unawaited(clientSocket.cast<List<int>>().pipe(forward.sink).catchError((_) {}));
         } catch (e) {
           clientSocket.destroy();
         }
@@ -461,7 +461,7 @@ class SshTunnelManager {
             testRemoteHost.trim(),
             testRemotePort,
           );
-          forward.close();
+          unawaited(forward.close());
         } catch (e) {
           return SshTestResult(
             ok: false,
@@ -483,8 +483,8 @@ class SshTunnelManager {
         error: 'SSH Connection failed: $e',
       );
     } finally {
-      client?.close();
-      jumpClient?.close();
+      unawaited(client?.close());
+      unawaited(jumpClient?.close());
     }
   }
 }

lib/main.dart

@@ -17,7 +17,7 @@ import 'core/theme/theme_controller.dart';
 import 'features/updater/update_controller.dart';
 
 void main([List<String> args = const []]) async {
-  runZonedGuarded(() async {
+  unawaited(runZonedGuarded(() async {
     WidgetsFlutterBinding.ensureInitialized();
     FileLaunchService.instance.processLaunchArguments(args);
 
@@ -46,5 +46,5 @@ void main([List<String> args = const []]) async {
     });
   }, (error, stack) {
     debugPrint('Unhandled async error: $error\n$stack');
-  });
+  }));
 }

test/core/extensions/harness/extension_harness_test.dart

@@ -34,8 +34,12 @@ class _FakePlugin implements HarnessPluginProcess {
   final calls = <String>[];
   final _stdout = StreamController<List<int>>();
   final _stderr = StreamController<List<int>>();
+  // The fake owns this stream for the whole test.
+  // ignore: close_sinks
   final _stdinController = StreamController<List<int>>();
   final _exit = Completer<int>();
+  // The fake owns this stream for the whole test.
+  // ignore: close_sinks
   late final IOSink _stdin = IOSink(_stdinController);
 
   void _reply(Map<String, Object?> body) {

test/core/extensions/rpc/json_rpc_stdio_client_test.dart

@@ -160,7 +160,7 @@ void main() {
       var peakAhead = 0;
       var handled = 0;
       for (final r in replies) {
-        r.then((_) => handled++);
+        unawaited(r.then((_) => handled++));
       }
       final watcher = Timer.periodic(const Duration(milliseconds: 1), (_) {
         peakAhead = math.max(peakAhead, produced - handled);

test/core/extensions/rpc/plugin_rpc_bridge_test.dart

@@ -34,6 +34,8 @@ class _FakeProcess implements Process {
   int get pid => 99;
 
   @override
+  // The fake owns this stream for the whole test.
+  // ignore: close_sinks
   late final IOSink stdin;
 
   @override

test/core/extensions/sandbox/sandbox_credentials_injector_test.dart

@@ -32,6 +32,8 @@ class _FakeProcess implements Process {
   int get pid => 4242;
 
   @override
+  // The fake owns this stream for the whole test.
+  // ignore: close_sinks
   late final IOSink stdin;
 
   @override
@@ -131,6 +133,8 @@ void main() {
   group('JsonRpcStdioClient', () {
     test('sends request and completes with result', () async {
       final stdout = StreamController<List<int>>();
+      // The fake owns this stream for the whole test.
+      // ignore: close_sinks
       final stdin = StreamController<List<int>>();
       final client = JsonRpcStdioClient(
         stdout: stdout.stream,
@@ -158,6 +162,8 @@ void main() {
 
     test('maps JSON-RPC errors', () async {
       final stdout = StreamController<List<int>>();
+      // The fake owns this stream for the whole test.
+      // ignore: close_sinks
       final stdin = StreamController<List<int>>();
       final client = JsonRpcStdioClient(
         stdout: stdout.stream,