From f03491b2dc214fff007d16f7af83ac7169e8207b Mon Sep 17 00:00:00 2001 From: trillian Date: Sat, 20 Sep 2025 22:54:56 +0300 Subject: [PATCH 1/4] upload artifacts on github workflow --- .github/workflows/cmake.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml index af2f7d73..331fec07 100644 --- a/.github/workflows/cmake.yml +++ b/.github/workflows/cmake.yml @@ -11,7 +11,7 @@ on: env: # Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.) - BUILD_TYPE: Release + BUILD_TYPE: MinSizeRel jobs: build: @@ -47,3 +47,10 @@ jobs: - name: Tests run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}} --target run-tests + + - uses: actions/upload-artifact@v4 + with: + name: binaries-${{ matrix.name }} + path: | + ${{ github.workspace }}/build/asar/bin/**/asar* + ${{ github.workspace }}/build/asar/lib/**/*asar.* From 819a192606948b432ba47c55eb5027acea5b2d9f Mon Sep 17 00:00:00 2001 From: trillian Date: Sat, 20 Sep 2025 23:31:14 +0300 Subject: [PATCH 2/4] bleh --- .github/workflows/cmake.yml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml index 331fec07..57a4b572 100644 --- a/.github/workflows/cmake.yml +++ b/.github/workflows/cmake.yml @@ -50,7 +50,12 @@ jobs: - uses: actions/upload-artifact@v4 with: - name: binaries-${{ matrix.name }} + # only on windows: + # on osx, the binaries wouldn't be easily runnable anyways due to code + # signing bullshit; on linux, the test binaries are built with asan and + # i don't want to distribute those + name: win-binaries + if: ${{ matrix.name == 'windows' }} path: | - ${{ github.workspace }}/build/asar/bin/**/asar* - ${{ github.workspace }}/build/asar/lib/**/*asar.* + ${{ github.workspace }}/build/asar/bin/**/asar.exe + ${{ github.workspace }}/build/asar/lib/**/asar.dll From 287577c49514b7c1090220ff54528b08bfa4bf77 Mon Sep 17 00:00:00 2001 From: trillian Date: Sat, 20 Sep 2025 23:33:50 +0300 Subject: [PATCH 3/4] im so good at this --- .github/workflows/cmake.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml index 57a4b572..673731cc 100644 --- a/.github/workflows/cmake.yml +++ b/.github/workflows/cmake.yml @@ -49,13 +49,13 @@ jobs: run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}} --target run-tests - uses: actions/upload-artifact@v4 + if: ${{ matrix.name == 'windows' }} with: # only on windows: # on osx, the binaries wouldn't be easily runnable anyways due to code # signing bullshit; on linux, the test binaries are built with asan and # i don't want to distribute those name: win-binaries - if: ${{ matrix.name == 'windows' }} path: | ${{ github.workspace }}/build/asar/bin/**/asar.exe ${{ github.workspace }}/build/asar/lib/**/asar.dll From 2d18decb6e864279bd8e26c8153cef38976baaaa Mon Sep 17 00:00:00 2001 From: trillian Date: Sun, 21 Sep 2025 00:22:04 +0300 Subject: [PATCH 4/4] nop