fix: tests & clippy

Author: Leandros

src/args.rs

@@ -26,7 +26,7 @@ impl Default for CliArgs {
 }
 
 impl CliArgs {
-    /// Thin wrapper over [`Self::from_iter`].
+    /// Thin wrapper over [`Self::from_args`].
     pub fn from_env() -> Result<Self> {
         Self::from_args(std::env::args())
     }

src/collector.rs

@@ -1,6 +1,6 @@
 //! Collector for metrics.
+#![allow(clippy::new_without_default)]
 
-use std::cell::RefCell;
 use std::sync::Arc;
 
 use anyhow::Result;

src/http.rs

@@ -10,7 +10,7 @@ use smol_hyper::rt::{FuturesIo, SmolTimer};
 use crate::collector::Collector;
 use crate::http_utils::{internal_server_error, not_found};
 
-async fn serve_metrics(collector: &Collector) -> Result<Response<BoxBody<Bytes, hyper::Error>>> {
+async fn serve_metrics(_collector: &Collector) -> Result<Response<BoxBody<Bytes, hyper::Error>>> {
     Err(anyhow::anyhow!("no"))
 }
 

src/main.rs

@@ -19,7 +19,7 @@ fn main() {
 /// Real, asynchronous entrypoint.
 async fn async_main(_ex: &Rc<smol::LocalExecutor<'_>>) {
     let args = CliArgs::from_env().expect("invalid args");
-    let config = UserConfig::from_path(&args.config_path)
+    let _config = UserConfig::from_path(&args.config_path)
         .await
         .expect("invalid config");
 

src/metrics/collector.rs

@@ -361,7 +361,7 @@ impl Metric for SystemdUnitStateCollector {
 
             if let Some(client) = self.systemd_client.lock().await.as_ref() {
                 for unit_name in &*units {
-                    match client.active_state(&unit_name).await {
+                    match client.active_state(unit_name).await {
                         Ok(state) => {
                             for state_name in ActiveState::all_states() {
                                 let labels = SystemdUnitLabels {

src/metrics/fs.rs

@@ -43,7 +43,7 @@ impl FilesystemUsage {
     ///
     /// # Example
     ///
-    /// ```
+    /// ```ignore,no_run
     /// use litemon::metrics::fs::FilesystemUsage;
     ///
     /// fn main() -> anyhow::Result<()> {

src/metrics/memory.rs

@@ -1,12 +1,7 @@
 //! Memory metrics collection.
 
-use std::sync::atomic::AtomicU64;
-
 use anyhow::{Context, Result};
 use procfs::Current;
-use prometheus_client::metrics::gauge::Gauge;
-
-use super::{DynFuture, Metric};
 
 /// Returns the percentage of memory currently used on the system.
 ///

tests/integration/cliargs.rs

@@ -6,13 +6,13 @@ use litemon::args::CliArgs;
 
 #[test]
 fn parse_args_default() {
-    let args = CliArgs::from_iter(["litemon"]).unwrap();
+    let args = CliArgs::from_args(["litemon"]).unwrap();
     assert_eq!(args, CliArgs::default());
 }
 
 #[test]
 fn parse_args_short() {
-    let args = CliArgs::from_iter([
+    let args = CliArgs::from_args([
         "litemon",
         "-n",
         "localhost",
@@ -33,7 +33,7 @@ fn parse_args_short() {
 
 #[test]
 fn parse_args_long() {
-    let args = CliArgs::from_iter([
+    let args = CliArgs::from_args([
         "litemon",
         "--listen",
         "localhost",