Fix metric visibility in deep dive#1
Draft
RajvardhanPatil07 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
st.metricrow in the deep-dive view with a custom responsive metric gridWhy
The close price in the deep-dive metrics was getting cut off (
INR 1,4...) on narrower layouts, which made a key market value hard to read.User impact
The
Closemetric now stays readable in real time across desktop widths, while the rest of the metrics continue to wrap responsively.Validation
python3 -m py_compile app.py alphawatch/*.pystreamlit.testing.v1.AppTest