Skip to content

user.inputStream() fails with TypeError: cannot set whisperId of undefined #110

Description

@ppacher

Hi,

I just found a bug when using inputStream() on a user object.

MumbleClient.inputStreamForUser requires the session ID as well as streaming options, however, User.inputStream() only passes the session ID which causes a TypeError when setting the whisperId on the undefined options object.

See https://github.com/Rantanen/node-mumble/blob/master/lib/MumbleClient.js#L293
and https://github.com/Rantanen/node-mumble/blob/master/lib/User.js#L118 .

Btw, the typescript bindings are outdated. I'd be fine to provide updated ones or try to integrate TS definitions from JSDocs.

Cheers,
Patrick

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions