fix(homepage): correct ArgoCD dashboard icon slug to argo-cd.png#218
Merged
Conversation
Homepage resolves bare icon names against the homarr-labs/dashboard-icons CDN by exact filename. The ArgoCD tile referenced `argocd.png`, which 404s there (the file is named `argo-cd.png`), so the dashboard rendered a broken-image placeholder instead of the logo. Verified: argocd.png -> HTTP 403, argo-cd.png -> HTTP 200. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The ArgoCD tile on the Homepage dashboard (
dashboard.lab.jackhall.dev) rendered a broken-image placeholder instead of the logo:Root cause
Homepage resolves bare icon names against the homarr-labs/dashboard-icons CDN by exact filename. The ArgoCD HTTPRoute annotation referenced
argocd.png, but the file on the CDN is namedargo-cd.png(hyphenated). The browser got a missing file and fell back to the broken-image placeholder — a silent failure that logs nothing in-cluster.Fix
kubernetes/apps/argocd/manifests/httproute.yaml:Verification
argocd.png→ HTTP 403 (missing)argo-cd.png→ HTTP 200 ✅Renders once merged and ArgoCD syncs the argocd app (Homepage regenerates its config from the HTTPRoute annotation automatically).
🤖 Generated with Claude Code