From 5bbfbe79985904362411bd0f5e979bcefa8fedb4 Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Thu, 4 Jun 2026 12:43:17 -0600 Subject: [PATCH 1/2] Refactor QueryPage rendering to use renderWithUnmount utility - Removed ReactDOM.render in favor of renderWithUnmount for improved component lifecycle management. - Simplified import statements by removing unused ExtensionApiContextProvider. --- src/components/QueryPage.tsx | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/components/QueryPage.tsx b/src/components/QueryPage.tsx index b605a3d2..db784a0a 100644 --- a/src/components/QueryPage.tsx +++ b/src/components/QueryPage.tsx @@ -10,17 +10,15 @@ import fireQuery from "../utils/fireQuery"; import parseQuery from "../utils/parseQuery"; import type { Result } from "roamjs-components/types/query-builder"; import ResultsView from "./ResultsView"; -import ReactDOM from "react-dom"; import QueryEditor from "./QueryEditor"; import getSubTree from "roamjs-components/util/getSubTree"; import { createComponentRender } from "roamjs-components/components/ComponentContainer"; +import renderWithUnmount from "roamjs-components/util/renderWithUnmount"; import getBasicTreeByParentUid from "roamjs-components/queries/getBasicTreeByParentUid"; import createBlock from "roamjs-components/writes/createBlock"; import deleteBlock from "roamjs-components/writes/deleteBlock"; import { OnloadArgs } from "roamjs-components/types/native"; -import ExtensionApiContextProvider, { - useExtensionAPI, -} from "roamjs-components/components/ExtensionApiContext"; +import { useExtensionAPI } from "roamjs-components/components/ExtensionApiContext"; import { Column, ExportTypes } from "../utils/types"; type QueryPageComponent = (props: { @@ -200,11 +198,6 @@ export const render = ({ onloadArgs, ...props }: { parent: HTMLElement; onloadArgs: OnloadArgs } & Props) => - ReactDOM.render( - - - , - parent - ); + renderWithUnmount(, parent, onloadArgs); export default QueryPage; From 4c8dc6ce78e8c85daf3d6ecd7abe131c5a674dfe Mon Sep 17 00:00:00 2001 From: Michael Gartner Date: Thu, 4 Jun 2026 12:46:09 -0600 Subject: [PATCH 2/2] 1.37.2 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 5dae94f6..ff76a1af 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "query-builder", - "version": "1.37.1", + "version": "1.37.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "query-builder", - "version": "1.37.1", + "version": "1.37.2", "hasInstallScript": true, "license": "MIT", "dependencies": { diff --git a/package.json b/package.json index afbfe43e..b480ce8c 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "query-builder", - "version": "1.37.1", + "version": "1.37.2", "description": "Introduces new user interfaces for building queries in Roam", "main": "./build/main.js", "author": {