ICE resolve_path

[matthiaskrgr]

auto-reduced (treereduce-rust):

//@compile-flags: -frust-incomplete-and-experimental-compiler-do-not-use
mod framing {

    pub use ::*;
}

original:

// https://github.com/rust-lang/rust/pull/113099

mod framing {
    mod public_message {
        use super::super::*;

        #[derive(Debug)]
        pub struct ConfirmedTranscriptHashInput;
    }

    mod public_message_in {
        use super::*;

        #[derive(Debug)]
        pub struct ConfirmedTranscriptHashInput;
    }

    pub use self::public_message::*;
    pub use self::public_message_in::*;
}

use crate::framing::ConfirmedTranscriptHashInput;
//~^ ERROR `ConfirmedTranscriptHashInput` is ambiguous
//~| WARNING this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!

fn main() { }

Version information:

145e66e

Possibly related line of code:

gccrs/gcc/rust/resolve/rust-forever-stack.hxx

Lines 710 to 722 in 145e66e

	ForeverStack<N>::resolve_path (
	const std::vector<S> &segments, ResolutionMode mode,
	std::function<void (const S &, NodeId)> insert_segment_resolution,
	std::vector<Error> &collect_errors,
	std::reference_wrapper<Node> starting_point)
	{
	rust_assert (!segments.empty ());
	switch (mode)
	{
	case ResolutionMode::Normal:
	break; // default
	case ResolutionMode::FromRoot:

Command:
/home/matthias/vcs/github/gccrs/gccrs-build/gcc/crab1 -frust-incomplete-and-experimental-compiler-do-not-use

Program output

crab1: error: failed to locate crate ‘core’
crab1: error: unknown crate ‘core’
crab1: internal compiler error: in resolve_path, at rust/resolve/rust-forever-stack.hxx:716
0x30d80b9 internal_error(char const*, ...)
	../../gcc/diagnostic-global-context.cc:787
0xc3ae5d fancy_abort(char const*, int, char const*)
	../../gcc/diagnostics/context.cc:1805
0x10022c3 tl::optional<Rust::Resolver2_0::Rib::Definition> Rust::Resolver2_0::ForeverStack<(Rust::Resolver2_0::Namespace)1>::resolve_path<Rust::AST::SimplePathSegment>(std::vector<Rust::AST::SimplePathSegment, std::allocator<Rust::AST::SimplePathSegment> > const&, Rust::Resolver2_0::ResolutionMode, std::function<void (Rust::AST::SimplePathSegment const&, unsigned int)>, std::vector<Rust::Error, std::allocator<Rust::Error> >&, std::reference_wrapper<Rust::Resolver2_0::ForeverStack<(Rust::Resolver2_0::Namespace)1>::Node>)
	../../gcc/rust/resolve/rust-forever-stack.hxx:716
0x1004c64 tl::optional<Rust::Resolver2_0::Rib::Definition> Rust::Resolver2_0::ForeverStack<(Rust::Resolver2_0::Namespace)1>::resolve_path<Rust::AST::SimplePathSegment>(std::vector<Rust::AST::SimplePathSegment, std::allocator<Rust::AST::SimplePathSegment> > const&, Rust::Resolver2_0::ResolutionMode, std::function<void (Rust::AST::SimplePathSegment const&, unsigned int)>, std::vector<Rust::Error, std::allocator<Rust::Error> >&)
	../../gcc/rust/resolve/rust-forever-stack.hxx:704
0x1004c64 tl::optional<Rust::Resolver2_0::Rib::Definition> Rust::Resolver2_0::NameResolutionContext::resolve_path<Rust::AST::SimplePathSegment>(std::vector<Rust::AST::SimplePathSegment, std::allocator<Rust::AST::SimplePathSegment> > const&, Rust::Resolver2_0::ResolutionMode, std::vector<Rust::Error, std::allocator<Rust::Error> >&, Rust::Resolver2_0::Namespace)
	../../gcc/rust/resolve/rust-name-resolution-context.h:575
0xffa585 tl::optional<Rust::Resolver2_0::Rib::Definition> Rust::Resolver2_0::NameResolutionContext::resolve_path<Rust::AST::SimplePathSegment>(std::vector<Rust::AST::SimplePathSegment, std::allocator<Rust::AST::SimplePathSegment> > const&, Rust::Resolver2_0::ResolutionMode, tl::optional<std::vector<Rust::Error, std::allocator<Rust::Error> >&>, Rust::Resolver2_0::Namespace)
	../../gcc/rust/resolve/rust-name-resolution-context.h:633
0xffa585 tl::optional<Rust::Resolver2_0::Rib::Definition> Rust::Resolver2_0::NameResolutionContext::resolve_path<Rust::AST::SimplePathSegment>(std::vector<Rust::AST::SimplePathSegment, std::allocator<Rust::AST::SimplePathSegment> > const&, bool, tl::optional<std::vector<Rust::Error, std::allocator<Rust::Error> >&>, Rust::Resolver2_0::Namespace)
	../../gcc/rust/resolve/rust-name-resolution-context.h:671
0xffa585 tl::optional<Rust::Resolver2_0::Rib::Definition> Rust::Resolver2_0::NameResolutionContext::resolve_path<Rust::AST::SimplePathSegment>(std::vector<Rust::AST::SimplePathSegment, std::allocator<Rust::AST::SimplePathSegment> > const&, bool, Rust::Resolver2_0::Namespace)
	../../gcc/rust/resolve/rust-name-resolution-context.h:681
0xffa585 tl::optional<Rust::Resolver2_0::Rib::Definition> Rust::Resolver2_0::NameResolutionContext::resolve_path<Rust::Resolver2_0::Namespace>(Rust::AST::SimplePath const&, Rust::Resolver2_0::Namespace&&)
	../../gcc/rust/resolve/rust-name-resolution-context.h:699
0xffa585 Rust::Resolver2_0::Early::resolve_glob_import(unsigned int, Rust::Resolver2_0::TopLevel::ImportKind&&)
	../../gcc/rust/resolve/rust-early-name-resolver-2.0.cc:78
0xffc7cb Rust::Resolver2_0::Early::build_import_mapping(std::pair<unsigned int, std::vector<Rust::Resolver2_0::TopLevel::ImportKind, std::allocator<Rust::Resolver2_0::TopLevel::ImportKind> > >&&)
	../../gcc/rust/resolve/rust-early-name-resolver-2.0.cc:156
0xffcc95 Rust::Resolver2_0::Early::visit(Rust::AST::UseDeclaration&)
	../../gcc/rust/resolve/rust-early-name-resolver-2.0.cc:491
0xe864bf void Rust::AST::DefaultASTVisitor::visit<Rust::AST::Item>(std::unique_ptr<Rust::AST::Item, std::default_delete<Rust::AST::Item> >&)
	../../gcc/rust/ast/rust-ast-visitor.h:420
0xe864bf Rust::AST::DefaultASTVisitor::visit(Rust::AST::Module&)
	../../gcc/rust/ast/rust-ast-visitor.cc:835
0xfe5f09 operator()
	../../gcc/rust/resolve/rust-default-resolver.cc:61
0xfe5f09 scope_inner<Rust::Resolver2_0::CanonicalPathCtx::scope<Rust::Resolver2_0::DefaultResolver::visit(Rust::AST::Module&)::<lambda()> >(Rust::NodeId, std::string, Rust::Resolver2_0::DefaultResolver::visit(Rust::AST::Module&)::<lambda()>&&)::<lambda()>, Rust::Resolver2_0::DefaultResolver::visit(Rust::AST::Module&)::<lambda()> >
	../../gcc/rust/resolve/rust-name-resolution-context.h:470
0xfe5f09 scope<Rust::Resolver2_0::DefaultResolver::visit(Rust::AST::Module&)::<lambda()> >
	../../gcc/rust/resolve/rust-name-resolution-context.h:413
0xfe5f09 scope<Rust::Resolver2_0::DefaultResolver::visit(Rust::AST::Module&)::<lambda()> >
	../../gcc/rust/resolve/rust-name-resolution-context.h:406
0xfe5f09 operator()
	../../gcc/rust/resolve/rust-default-resolver.cc:64
0xfe5f09 __invoke_impl<void, Rust::Resolver2_0::DefaultResolver::visit(Rust::AST::Module&)::<lambda()>&>
	/usr/include/c++/15.2.1/bits/invoke.h:63
Please submit a full bug report, with preprocessed source (by using -freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Harishankar14]

@matthiaskrgr Valid crashout, but you can ignore the
crab1: error: failed to locate crate ‘core’
crab1: error: unknown crate ‘core’
by adding
![feature(no_core)]
#![no_core]

let me try if i can provide a fix for the other ones!!

[Harishankar14]

@matthiaskrgr I do kind of have a fix for this but i guess, the code snippet which you mentioned is indeed doing its job and the issue is i guess in the upstream upstream part of it, to be specific, it would be around (gccrs/gcc/rust/resolve/rust-early-name-resolver-2.0.cc).

if you like see this code to be specific in the file mentioned by you.
if (res && !res->is_ambiguous ()) insert_segment_resolution (outer_seg, res->get_node_id ());
The function resolve_path explicitly checks !res->is_ambiguous() before trying to access the NodeId.

When i locally tried to reproduce the error

crab1: internal compiler error: in get_node_id, at rust/resolve/rust-rib.h:149 0x2afef07 internal_error(char const*, ...)     ../../gccrs/gcc/diagnostic-global-context.cc:787 0xb4e2f5 fancy_abort(char const*, int, char const*)     ../../gccrs/gcc/diagnostics/context.cc:1805 0x913516 Rust::Resolver2_0::Rib::Definition::get_node_id() const     ../../gccrs/gcc/rust/resolve/rust-rib.h:149 0x913634 Rust::Resolver2_0::Rib::Definition::get_node_id() const     ../../gccrs/gcc/rust/util/optional.h:1327 0x913634 Rust::Resolver2_0::Early::finalize_rebind_import(Rust::Resolver2_0::Early::ImportPair const&)     ../../gccrs/gcc/rust/resolve/rust-early-name-resolver-2.0.cc:468 0xe89321 Rust::Resolver2_0::Early::visit(Rust::AST::UseDeclaration&)     ../../gccrs/gcc/rust/resolve/rust-early-name-resolver-2.0.cc:505 0xd3df4f void Rust::AST::DefaultASTVisitor::visit<Rust::AST::Item>(std::unique_ptr<Rust::AST::Item, std::default_delete<Rust::AST::Item> >&)     ../../gccrs/gcc/rust/ast/rust-ast-visitor.h:420 0xd3df4f Rust::AST::DefaultASTVisitor::visit(Rust::AST::Crate&)     ../../gccrs/gcc/rust/ast/rust-ast-visitor.cc:39 0xe77ed8 operator()     ../../gccrs/gcc/rust/resolve/rust-default-resolver.cc:34 0xe77ed8 scope_inner<Rust::Resolver2_0::CanonicalPathCtx::scope_crate<Rust::Resolver2_0::DefaultResolver::visit(Rust::AST::Crate&)::<lambda()>&>(Rust::NodeId, std::string, Rust::Resolver2_0::DefaultResolver::visit(Rust::AST::Crate&)::<lambda()>&)::<lambda()>, Rust::Resolver2_0::DefaultResolver::visit(Rust::AST::Crate&)::<lambda()>&>     ../../gccrs/gcc/rust/resolve/rust-name-resolution-context.h:470 0xe77ed8 scope_crate<Rust::Resolver2_0::DefaultResolver::visit(Rust::AST::Crate&)::<lambda()>&>     ../../gccrs/gcc/rust/resolve/rust-name-resolution-context.h:445 0xe77ed8 Rust::Resolver2_0::DefaultResolver::visit(Rust::AST::Crate&)     ../../gccrs/gcc/rust/resolve/rust-default-resolver.cc:43 0xe85ee0 Rust::Resolver2_0::Early::go(Rust::AST::Crate&)     ../../gccrs/gcc/rust/resolve/rust-early-name-resolver-2.0.cc:70 0xd6fbfc Rust::Session::expansion(Rust::AST::Crate&, Rust::Resolver2_0::NameResolutionContext&)     ../../gccrs/gcc/rust/rust-session-manager.cc:1016 0xd7955f Rust::Session::compile_crate(char const*)     ../../gccrs/gcc/rust/rust-session-manager.cc:682