Add an A-B loop button.

[zhouxinghong]

Expected behavior of the wanted feature

Add an A-B loop button.

[Samillion]

Since this is a niche feature, the likelihood of adding a dedicated button is not high.

However, you can access this feature in multiple ways already.

Method #1

The context menu already lists this as an item, which is easily accessible:

• Playback => Set A/B Loop

Method #2

You can use a keybind to directly trigger it, by assigning it within input.conf:

• x ab-loop
• Change x to whichever keybind you prefer

Method #3

You can also make the current loop button right click trigger it

# modernz.conf
file_loop_mbtn_right_command=ab-loop

Method #4

Alternatively, you can adjust the Play/Pause button mouse commands, the same way described in method #3:

play_pause_mbtn_mid_command=cycle-values loop-playlist inf no
play_pause_mbtn_right_command=cycle-values loop-file inf no

[zhouxinghong]

This feature is used very frequently; having a button eliminates the need for manual button presses.

Many other media players provide this button, such as VLC and MPC.

[zhouxinghong]

Adding a button icon is actually not difficult, since you have already implemented the core functionality.

[Samillion]

Adding a button icon is actually not difficult

The reason we're always hesitant to add new buttons is the clutter/space available, not because it's difficult or not.

I've changed the labels, if we get enough feedback, I'll consider adding it.

However, as I said in #743 (comment) this is already possible with four methods.

For this to be implemented:

• An icon for each theme needs to be provided. Fluent and Material
• If generic icons are used, they have to match the relevant theme in style and overall shape
• They must be licensed in a way that allows use and inclusion within ModernZ's code and license

[zhouxinghong]

The reason we're always hesitant to add new buttons is the clutter/space available, not because it's difficult or not.

If space is insufficient, users can hide buttons they don't need based on their usage frequency. For example, if we rarely use the screenshot button, we can hide it and show the A-B loop button instead.

However, this is a boon for people who prefer using a mouse to a keyboard.

[Samillion]

However, this is a boon for people who prefer using a mouse to a keyboard.

Three of the four methods I mentioned use mouse, not keyboard.

Either way, if someone wants to implement this, I mentioned what would be required here #743 (comment)

[Keith94]

Could borrow the custom button feature from stock osc.

https://github.com/mpv-player/mpv/blob/ce71cd8aebc0b990eb3207897424b9c092805721/player/lua/osc.lua#L2673

[Samillion]

Do Fluent and Material have an all purpose type icon shape?

[Keith94]

Something like this document icon?

https://github.com/microsoft/fluentui-system-icons/blob/3efd6de6490ae7ab7d5917bcbc96265b0a92f884/assets/Document/SVG/ic_fluent_document_32_regular.svg

https://materialui.co/icon/insert-drive-file