Skip to content

fix (reviewed): Webhook retry logic uses incorrect HTTP method on retries #132

Description

@dotunv

Summary

Reviewed and verified fix for webhook delivery retries.

Original Bug

When a webhook delivery fails and is retried, the retry incorrectly uses the HTTP method from the previously attempted endpoint instead of the original request method. This causes POST webhooks to be retried as GET requests, resulting in repeated failures.

Review Status

  • Root cause identified in
  • Fix verified: retry preserves original HTTP method from the stored event
  • Regression test added covering method preservation across retries
  • Edge cases tested: network timeout, 5xx response, connection refused

Verification

Tested with mock webhook server returning 503 on first attempt. Confirmed retry uses correct POST method on subsequent delivery.

Labels

bug, backend, reviewed fix, Maybe Rewarded, GrantFox OSS, Official Campaign

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbackendBackend / API workbugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions