From c905ae79d85ad2d8b8043228e9f3e07c36be97cb Mon Sep 17 00:00:00 2001 From: tu11aa Date: Fri, 31 Jul 2026 14:45:39 +0700 Subject: [PATCH] Fix stale @starknet-react/core import and cairo test arity mismatch app/page.tsx still imported useBlockNumber from the old @starknet-react/core package name; the repo migrated to @starknet-start/react everywhere else. test_set_greeting_no_allowance called set_greeting with 2 args instead of the 3 the contract requires, failing compilation (E2030) before tests could even run. --- packages/nextjs/app/page.tsx | 2 +- packages/snfoundry/contracts/tests/test_contract.cairo | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/nextjs/app/page.tsx b/packages/nextjs/app/page.tsx index a783b2f..e15e0a0 100644 --- a/packages/nextjs/app/page.tsx +++ b/packages/nextjs/app/page.tsx @@ -5,7 +5,7 @@ import { useState } from "react"; import { useScaffoldReadContract } from "~~/hooks/scaffold-stark/useScaffoldReadContract"; import { useScaffoldEventHistory } from "~~/hooks/scaffold-stark/useScaffoldEventHistory"; import { useScaffoldMultiWriteContract } from "~~/hooks/scaffold-stark/useScaffoldMultiWriteContract"; -import { useBlockNumber } from "@starknet-react/core"; +import { useBlockNumber } from "@starknet-start/react"; import { useDeployedContractInfo } from "~~/hooks/scaffold-stark/useDeployedContractInfo"; import { useScaffoldWriteContract } from "~~/hooks/scaffold-stark/useScaffoldWriteContract"; import { useTargetNetwork } from "~~/hooks/scaffold-stark/useTargetNetwork"; diff --git a/packages/snfoundry/contracts/tests/test_contract.cairo b/packages/snfoundry/contracts/tests/test_contract.cairo index e2357ff..58fdac7 100644 --- a/packages/snfoundry/contracts/tests/test_contract.cairo +++ b/packages/snfoundry/contracts/tests/test_contract.cairo @@ -107,7 +107,10 @@ fn test_set_greeting_no_allowance() { let new_greeting: ByteArray = "Learn Scaffold-Stark 2! :)"; cheat_caller_address(your_contract_address, user, CheatSpan::TargetCalls(1)); - your_contract_dispatcher.set_greeting(new_greeting.clone(), Option::Some(500)); + your_contract_dispatcher + .set_greeting( + new_greeting.clone(), Option::Some(500), Option::Some(ETH_TOKEN_CONTRACT_ADDRESS), + ); } #[test]