From 35143a8cc8bb5c15f4868b505ee34368de4a59c6 Mon Sep 17 00:00:00 2001 From: ChrisRackauckas-Claude Date: Sat, 13 Jun 2026 07:08:10 -0400 Subject: [PATCH] Normalize root nopre test group into canonical QA The root nopre group carried only the standard JET static-analysis check, so it is renamed to the canonical QA group at versions ["lts","1"]. The dep env test/nopre is renamed to test/qa, the runtests dispatch keys on GROUP == "QA", and the CI.yml comment is updated. Root package only; lib/* sublibraries are unaffected. Co-Authored-By: Chris Rackauckas Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/CI.yml | 2 +- test/{nopre => qa}/Project.toml | 0 test/{nopre => qa}/jet_tests.jl | 0 test/runtests.jl | 12 ++++++------ test/test_groups.toml | 9 ++++----- 5 files changed, 11 insertions(+), 12 deletions(-) rename test/{nopre => qa}/Project.toml (100%) rename test/{nopre => qa}/jet_tests.jl (100%) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 7900274e..89587e03 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -15,7 +15,7 @@ concurrency: cancel-in-progress: ${{ github.ref_name != github.event.repository.default_branch || github.ref != 'refs/tags/v*' }} jobs: tests: - # Root-only test groups (Core, nopre) are declared in test/test_groups.toml. + # Root-only test groups (Core, QA) are declared in test/test_groups.toml. # The lib/* sublibraries (DataDrivenDMD, DataDrivenSR, DataDrivenSparse, # DataDrivenLux) are covered by SublibraryCI.yml via the project model and # must not be double-tested through this root matrix. diff --git a/test/nopre/Project.toml b/test/qa/Project.toml similarity index 100% rename from test/nopre/Project.toml rename to test/qa/Project.toml diff --git a/test/nopre/jet_tests.jl b/test/qa/jet_tests.jl similarity index 100% rename from test/nopre/jet_tests.jl rename to test/qa/jet_tests.jl diff --git a/test/runtests.jl b/test/runtests.jl index 6845c8cf..2ea71f1a 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -50,9 +50,9 @@ const GROUP = get(ENV, "GROUP", "All") Pkg.test(base_group, coverage = true) end else - # nopre is a dep-adding group (JET in test/nopre/Project.toml), excluded - # from `All` (curated to Core) and -- as its name says -- not run on - # prerelease Julia (enforced by test/test_groups.toml versions). + # QA is a dep-adding group (JET in test/qa/Project.toml), excluded from + # `All` (curated to Core) and not run on prerelease Julia (enforced by + # test/test_groups.toml versions). run_tests(; core = function () @safetestset "Basis" begin @@ -78,11 +78,11 @@ const GROUP = get(ENV, "GROUP", "All") end end, groups = Dict( - "nopre" => (; - env = joinpath(@__DIR__, "nopre"), + "QA" => (; + env = joinpath(@__DIR__, "qa"), body = function () @safetestset "JET Static Analysis" begin - include("nopre/jet_tests.jl") + include("qa/jet_tests.jl") end end, ), diff --git a/test/test_groups.toml b/test/test_groups.toml index dfe8e145..94c3a752 100644 --- a/test/test_groups.toml +++ b/test/test_groups.toml @@ -1,12 +1,11 @@ # Test group declarations for the DataDrivenDiffEq root package. # The base-environment Core group runs in the package's main test env and is -# the only group in the `All` run. The `nopre` group is a dep-adding group: it -# carries JET in test/nopre/Project.toml, is excluded from `All`, and (as its -# name says) does not run on prerelease Julia. Its CI.yml matrix group input is -# lowercase, so the group name here is kept lowercase to stay consistent. +# the only group in the `All` run. The `QA` group is a dep-adding group: it +# carries JET in test/qa/Project.toml, is excluded from `All`, and does not run +# on prerelease Julia. [Core] versions = ["lts", "1", "pre"] -[nopre] +[QA] versions = ["lts", "1"]