Skip to content

QA: Aqua/JET findings marked @test_broken pending fix #118

Description

@ChrisRackauckas-Claude

The QA test group (Aqua + JET) was made green for the centralized grouped-tests CI by marking genuine, currently-failing Aqua sub-checks as @test_broken in test/qa/qa.jl. These should be fixed and then un-broken.

Findings observed on Julia 1.11 with Aqua.test_all(DiffEqPhysics):

  1. Stale dependencies (Aqua.test_stale_deps):

    isempty(stale_deps) == false
    Evaluated: isempty(PkgId[PkgId(UUID("459566f4-90b8-5000-8ac3-15dfb0a30def"), "DiffEqCallbacks")])
    

    DiffEqCallbacks is declared in [deps] of Project.toml but is not used in the package source, so Aqua flags it as a stale dependency. Fix: either remove DiffEqCallbacks from [deps]/[compat] or actually use it.

  2. Deps compat — extras (Aqua.test_deps_compat, check_extras):

    DiffEqPhysics does not declare a compat entry for the following extras:
      Pkg [44cfe95a-1eb2-52ea-b672-e2afdf69b78f]
    

    The Pkg test-extra has no [compat] entry. Fix: add a Pkg compat bound (e.g. Pkg = "1") to [compat].

Both of these are real Project.toml hygiene issues. They are currently @test_broken false in test/qa/qa.jl (with the passing Aqua sub-checks — ambiguities, unbound_args, undefined_exports, project_extras, deps_compat for deps/weakdeps, piracies, persistent_tasks — left running, and JET.test_package left running). When fixed, remove the corresponding @test_broken lines and re-enable stale_deps/deps_compat in Aqua.test_all.

Ignore until reviewed by @ChrisRackauckas.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions