Skip to content

QA: Aqua/JET findings marked @test_broken pending fix #50

Description

@ChrisRackauckas-Claude

The new GROUP=QA test group surfaces the following genuine Aqua/JET findings. To keep the QA CI group GREEN, each failing check is marked @test_broken in test/qa/qa.jl (the passing Aqua sub-checks remain enabled). These should be fixed and the corresponding @test_broken un-broken.

Exact findings (Julia 1.11, Aqua 0.8, JET 0.x):

  1. Aqua deps_compat (extras)Aqua.test_all fails because DimensionalPlotRecipes does not declare compat entries for its test-only [extras]:

    DimensionalPlotRecipes does not declare a compat entry for the following extras:
      Aqua [4c88cf16-eb10-579e-8560-4a9242c79595]
      JET  [c3a54625-cd67-489e-a8e7-0a5a0ff4e31b]
    

    Fix: add [compat] bounds for Aqua and JET in the root Project.toml.

  2. Aqua piracies — flagged as type-piracy:

    apply_recipe(plotattributes::AbstractDict{Symbol, Any}, x::AbstractArray{T}, y::Array{Complex{T2}})
      where {T<:Real, T2<:Number} @ DimensionalPlotRecipes (RecipesBase.jl)
    

    This is the method generated by the @recipe/@recipe function f(...) macro, which defines RecipesBase.apply_recipe. Aqua treats it as piracy because the method is owned by RecipesBase and dispatches on Base/stdlib argument types. Common fix: configure Aqua.test_all(...; piracies=(treat_as_own=[...],)) or otherwise exclude the recipe method.

  3. JET test_packagereport_package finds:

    apply_recipe(...) where {...} @ DimensionalPlotRecipes (RecipesBase.jl:298)
      no matching method found `is_key_supported(::Symbol)`:
      (RecipesBase).is_key_supported(:transformation)
    

    This originates from the transformation = :split3D attribute handling inside the @recipe block interacting with RecipesBase.is_key_supported.

All three are currently @test_broken false so the QA group passes; they should be investigated and fixed/un-broken. Ignore until reviewed by @ChrisRackauckas.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions