From 0730b99eb9e2b6d202d8f0ed2a5a4807f6be31b1 Mon Sep 17 00:00:00 2001 From: ChrisRackauckas-Claude Date: Wed, 3 Jun 2026 12:25:37 -0400 Subject: [PATCH] Centralize CI on SciML reusable workflows Convert Documentation, Downgrade, Runic (FormatCheck), and SpellCheck to the centralized SciML/.github reusable workflows pinned at @v1, with `secrets: "inherit"` on every caller. Tests already used tests.yml@v1. - Documentation.yml -> documentation.yml@v1 - Downgrade.yml -> downgrade.yml@v1 (julia-version 1.10, skip Pkg,TOML) - FormatCheck.yml -> runic.yml@v1 - SpellCheck.yml -> spellcheck.yml@v1 Fix one typo (constratins -> constraints). Drop the crate-ci/typos dependabot ignore and extend the julia dependabot block to /docs and /examples (both have Project.toml). Co-Authored-By: Chris Rackauckas Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/dependabot.yml | 5 ++--- .github/workflows/Documentation.yml | 17 ++--------------- .github/workflows/Downgrade.yml | 23 +++++------------------ .github/workflows/FormatCheck.yml | 11 ++--------- .github/workflows/SpellCheck.yml | 9 ++------- src/api/constraints.jl | 2 +- 6 files changed, 14 insertions(+), 53 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index bac0082..2417638 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -5,12 +5,11 @@ updates: directory: "/" # Location of package manifests schedule: interval: "weekly" - ignore: - - dependency-name: "crate-ci/typos" - update-types: ["version-update:semver-patch", "version-update:semver-minor"] - package-ecosystem: "julia" directories: - "/" + - "/docs" + - "/examples" schedule: interval: "daily" groups: diff --git a/.github/workflows/Documentation.yml b/.github/workflows/Documentation.yml index 90dacca..7ee6d63 100644 --- a/.github/workflows/Documentation.yml +++ b/.github/workflows/Documentation.yml @@ -9,18 +9,5 @@ on: jobs: build: - runs-on: ubuntu-latest - permissions: - contents: write - statuses: write - steps: - - uses: actions/checkout@v6 - - uses: julia-actions/setup-julia@v3 - with: - version: '1' - - uses: julia-actions/cache@v3 - - uses: julia-actions/julia-buildpkg@v1 - - uses: julia-actions/julia-docdeploy@v1 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - DOCUMENTER_KEY: ${{ secrets.DOCUMENTER_KEY }} + uses: "SciML/.github/.github/workflows/documentation.yml@v1" + secrets: "inherit" diff --git a/.github/workflows/Downgrade.yml b/.github/workflows/Downgrade.yml index fd0d0c2..d13d42d 100644 --- a/.github/workflows/Downgrade.yml +++ b/.github/workflows/Downgrade.yml @@ -12,21 +12,8 @@ on: - 'docs/**' jobs: test: - runs-on: ubuntu-latest - strategy: - matrix: - downgrade_mode: ['alldeps'] - julia-version: ['1.10'] - steps: - - uses: actions/checkout@v6 - - uses: julia-actions/setup-julia@v3 - with: - version: ${{ matrix.julia-version }} - - uses: julia-actions/julia-downgrade-compat@v2 - continue-on-error: true - with: - skip: Pkg,TOML - - uses: julia-actions/julia-buildpkg@v1 - - uses: julia-actions/julia-runtest@v1 - with: - ALLOW_RERESOLVE: false + uses: "SciML/.github/.github/workflows/downgrade.yml@v1" + with: + julia-version: "1.10" + skip: "Pkg,TOML" + secrets: "inherit" diff --git a/.github/workflows/FormatCheck.yml b/.github/workflows/FormatCheck.yml index ee667ce..8dad791 100644 --- a/.github/workflows/FormatCheck.yml +++ b/.github/workflows/FormatCheck.yml @@ -11,12 +11,5 @@ on: jobs: runic: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v6 - - uses: julia-actions/setup-julia@v3 - with: - version: '1' - - uses: fredrikekre/runic-action@v1 - with: - version: '1' + uses: "SciML/.github/.github/workflows/runic.yml@v1" + secrets: "inherit" diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml index a8e5983..434bc76 100644 --- a/.github/workflows/SpellCheck.yml +++ b/.github/workflows/SpellCheck.yml @@ -4,10 +4,5 @@ on: [pull_request] jobs: typos-check: - name: Spell Check with Typos - runs-on: ubuntu-latest - steps: - - name: Checkout Actions Repository - uses: actions/checkout@v6 - - name: Check spelling - uses: crate-ci/typos@v1.18.0 + uses: "SciML/.github/.github/workflows/spellcheck.yml@v1" + secrets: "inherit" diff --git a/src/api/constraints.jl b/src/api/constraints.jl index 6cb4128..03228ca 100644 --- a/src/api/constraints.jl +++ b/src/api/constraints.jl @@ -75,7 +75,7 @@ isfeasible(c::AbstractConstraints, x) = isfeasible(c.bounds, x, value(c, x)) # Implementations -"""Type for an empty set of constratins""" +"""Type for an empty set of constraints""" struct NoConstraints <: AbstractConstraints end isfeasible(c::NoConstraints, x) = true getproperty(c::NoConstraints, s::Symbol) =