From a38d60ddefec85e697c445719ee0aebc44ec90ca Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 15 Jun 2026 10:39:58 -0400 Subject: [PATCH] Route umbrella QA group through the `qa` keyword The root `test/runtests.jl` passed the QA (Aqua/JET) group via `groups = Dict("QA" => ...)`, but "QA" is a reserved group name in SciMLTesting's `run_tests`: it is dispatched to the `qa` keyword, not through `groups`. With `qa` unset, `GROUP="QA"` hit ArgumentError: run_tests: GROUP="QA" was requested but no `qa` body was provided failing the `tests / QA` checks. Pass the group via `qa = (; env, body)` so the reserved name is routed correctly. Verified locally on Julia 1.12 (the `julia 1` matrix entry): `GROUP=QA Pkg.test()` now runs the umbrella Aqua+JET suite to "QA | 12 12" all-pass / "tests passed". Co-Authored-By: Chris Rackauckas Co-Authored-By: Claude Opus 4.8 (1M context) --- test/runtests.jl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/runtests.jl b/test/runtests.jl index 01bda88..a721092 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -56,10 +56,10 @@ const GROUP = get(ENV, "GROUP", "All") elseif GROUP == "All" || GROUP == "Core" || GROUP == "QA" run_tests(; core = () -> @safetestset("Umbrella Load", include("umbrella_load.jl")), - # QA (Aqua/JET): dep-adding group in its own sub-env (test/qa), excluded from "All". - groups = Dict( - "QA" => (; env = joinpath(@__DIR__, "qa"), body = joinpath(@__DIR__, "qa", "qa.jl")), - ), + # QA (Aqua/JET): dep-adding group in its own sub-env (test/qa). It is the + # reserved "QA" group, so it must be passed via the `qa` keyword (the + # reserved name is not routed through `groups`). + qa = (; env = joinpath(@__DIR__, "qa"), body = joinpath(@__DIR__, "qa", "qa.jl")), ) end end # @time