Skip to content

Commit a43299b

Browse files
Merge pull request #11 from ScriptedAlchemy/fix/main-ci-workflows
fix(ci): pin the new preview trigger and gate npm publishing
2 parents 6aa32ee + ae1836d commit a43299b

2 files changed

Lines changed: 15 additions & 4 deletions

File tree

‎.github/workflows/release.yml‎

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,23 @@ jobs:
1717
runs-on: ubuntu-latest
1818
steps:
1919
- uses: actions/checkout@v7
20-
- uses: pnpm/setup@v1
20+
# No npm release is cut yet; skip publishing until an NPM_TOKEN secret
21+
# exists instead of failing every push to main. Previews stay on
22+
# pkg.pr.new (docs/preview-packages.md).
23+
- id: gate
24+
env:
25+
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
26+
run: echo "enabled=${{ env.NPM_TOKEN != '' }}" >> "$GITHUB_OUTPUT"
27+
- if: steps.gate.outputs.enabled == 'true'
28+
uses: pnpm/setup@v1
2129
with:
2230
cache: true
2331
install: false
2432
runtime: node@22.19.0
25-
- run: pnpm install --frozen-lockfile
26-
- uses: changesets/action@v1
33+
- if: steps.gate.outputs.enabled == 'true'
34+
run: pnpm install --frozen-lockfile
35+
- if: steps.gate.outputs.enabled == 'true'
36+
uses: changesets/action@v1
2737
with:
2838
publish: pnpm release
2939
version: pnpm version-packages

‎packages/agent-bundle/tests/package-preview-workflow.test.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ it('publishes one locked package preview for pull requests', async () => {
3232
};
3333
const steps = parsed.jobs?.publish?.steps ?? [];
3434

35-
expect(Object.keys(parsed.on ?? {})).toEqual(['pull_request']);
35+
expect(Object.keys(parsed.on ?? {})).toEqual(['pull_request', 'push']);
36+
expect((parsed.on as Readonly<Record<string, unknown>>)['push']).toEqual({ branches: ['main'] });
3637
expect(parsed.permissions).toEqual({});
3738
expect(steps.map((step) => step.uses ?? step.run)).toEqual([
3839
'actions/checkout@v7',

0 commit comments

Comments
 (0)